DPDK patches and discussions
 help / color / mirror / Atom feed
From: Bruce Richardson <bruce.richardson@intel.com>
To: Wei Dai <wei.dai@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] lpm: remove redundant check when adding lpm rule
Date: Tue, 2 Aug 2016 17:04:10 +0100	[thread overview]
Message-ID: <20160802160410.GC17728@bricha3-MOBL3> (raw)
In-Reply-To: <1470103765-18226-1-git-send-email-wei.dai@intel.com>

On Tue, Aug 02, 2016 at 10:09:25AM +0800, Wei Dai wrote:
> When a rule with depth > 24 is added into an existing
> rule with depth <=24, a new tbl8 is allocated, the existing
> rule first fulfill whole new tbl8, so the filed vaild of

typo "valid"

> each entry in this tbl8 is always true and depth of each
> entry is always < 24 before adding new rule with depth > 24.
> 
> Signed-off-by: Wei Dai <wei.dai@intel.com>

Acked-by: Bruce Richardson <bruce.richardson@intel.com>

Having to make this change twice shows up the fact that we are still carrying
around some version changes for older releases. Given that we are now past the
16.07 release, the old code can probably be removed. Any volunteers to maybe
do up a patch for that.

	Regards,
	/Bruce

  reply	other threads:[~2016-08-02 16:06 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-01 13:47 [dpdk-dev] [PATCH] " Wei Dai
2016-08-02  2:09 ` [dpdk-dev] [PATCH v2] " Wei Dai
2016-08-02 16:04   ` Bruce Richardson [this message]
2016-08-02 21:36     ` Thomas Monjalon
2016-08-03  9:16       ` Bruce Richardson
2016-08-03  7:04   ` [dpdk-dev] [PATCH v3 3/3] " Wei Dai
2016-08-03  7:17     ` Dai, Wei
2016-08-03  7:20     ` Dai, Wei
2016-08-08  6:42     ` [dpdk-dev] [PATCH v4 " Wei Dai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160802160410.GC17728@bricha3-MOBL3 \
    --to=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=wei.dai@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).