From: Neil Horman <nhorman@tuxdriver.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: Declan Doherty <declan.doherty@intel.com>, dev@dpdk.org
Subject: Re: [dpdk-dev] [RFC 0/4] Use Google Test as DPDK unit test framework
Date: Wed, 3 Aug 2016 07:31:55 -0400 [thread overview]
Message-ID: <20160803113155.GB3603@hmsreliant.think-freely.org> (raw)
In-Reply-To: <5511822.hGlaykcsx3@xps13>
On Tue, Aug 02, 2016 at 11:52:24PM +0200, Thomas Monjalon wrote:
> 2016-08-02 21:37, Declan Doherty:
> > I've been trying out using google test as a possible replacement for our unit
> > test framework and have put to together this series of patches with help from
> > Anatoly as RFC to get peoples thoughts on migrating to google test.
>
> Thanks for exploring new possibilities.
>
> > To facilitate google test this rfc patch set contains build system changes to
> > allow C++ to built within the DPDK framework, this intended for unit test code
> > only, and to support google test which is a C++ framework. Don't worry, I'm not
> > advocating making DPDK a C++ project :)
>
> You are not advocating but the unit test must be written in C++.
> I don't think it is a good idea to force people to write and maintain the tests
> in a different language than the code it tests.
>
I agree, there are lots of xunit based integration tests that are available as
pure C frameworks. Jenkins might also be a good candidate here.
> > Some of the major advantages of google test that I see over continuing to use the
> > current test include giving a consist feel to all tests, a powerful test
> > execution framework which allow individual test suites or tests to be specified
> > from the command line, support for a standard xunit output which can be integrated
> > into a continuous build systems, and a very powerful mocking library
> > which allows much more control over testing failure conditions.
>
> It would be interesting to better describe in details what is missing currently
> and what such a framework can bring.
> (I agree there is a huge room for improvements on unit tests)
>
I agree that a test framework gives a consistent look and feel to all tests, but
it seems to me that would be the case with any framework worth its salt. While
I'm not opposed to google test per-se, the fact that it requires C++ to build
makes me wonder if there isn't a better option available.
Neil
prev parent reply other threads:[~2016-08-03 11:32 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-02 20:37 Declan Doherty
2016-08-02 20:37 ` [dpdk-dev] [RFC 1/4] mk: Add support for C++ compilation Declan Doherty
2016-08-02 20:37 ` [dpdk-dev] [RFC 2/4] examples: add c++ example application Declan Doherty
2016-08-02 20:37 ` [dpdk-dev] [RFC 3/4] eal: add command line option to log output to stdout Declan Doherty
2016-08-03 11:25 ` Neil Horman
2016-08-02 20:37 ` [dpdk-dev] [RFC 4/4] app/test-gtest: example google test application Declan Doherty
2016-08-02 21:52 ` [dpdk-dev] [RFC 0/4] Use Google Test as DPDK unit test framework Thomas Monjalon
2016-08-03 9:16 ` Remy Horton
2016-08-03 9:57 ` Doherty, Declan
2016-08-03 12:51 ` Neil Horman
2016-08-03 20:46 ` Ming Zhao
2016-08-04 19:47 ` Jim Murphy
2016-08-04 19:55 ` Wiles, Keith
2016-08-05 7:42 ` Thomas Monjalon
2016-08-05 7:41 ` Yerden Zhumabekov
2016-08-05 9:11 ` Remy Horton
2016-08-05 12:59 ` Neil Horman
2016-08-05 14:54 ` Remy Horton
2016-08-03 11:31 ` Neil Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160803113155.GB3603@hmsreliant.think-freely.org \
--to=nhorman@tuxdriver.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).