From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
To: Maxime Coquelin <maxime.coquelin@redhat.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 7/7] vhost: simplify features set/get
Date: Thu, 25 Aug 2016 11:03:19 +0800 [thread overview]
Message-ID: <20160825030319.GV30752@yliu-dev.sh.intel.com> (raw)
In-Reply-To: <33936312-b630-1a4e-e478-b028dc264962@redhat.com>
On Wed, Aug 24, 2016 at 10:11:57AM +0200, Maxime Coquelin wrote:
>
>
> On 08/18/2016 10:48 AM, Yuanhan Liu wrote:
> >No need to use a pointer to store/retrieve features.
> >
> >Signed-off-by: Yuanhan Liu <yuanhan.liu@linux.intel.com>
> >---
> > lib/librte_vhost/vhost_user.c | 20 ++++++++------------
> > 1 file changed, 8 insertions(+), 12 deletions(-)
> >
> >diff --git a/lib/librte_vhost/vhost_user.c b/lib/librte_vhost/vhost_user.c
> >index ef4a0c1..eee99e9 100644
> >--- a/lib/librte_vhost/vhost_user.c
> >+++ b/lib/librte_vhost/vhost_user.c
> >@@ -155,23 +155,22 @@ vhost_user_reset_owner(struct virtio_net *dev)
> > /*
> > * The features that we support are requested.
> > */
> >-static int
> >-vhost_user_get_features(uint64_t *pu)
> >+static uint64_t
> >+vhost_user_get_features(void)
> > {
> >- *pu = VHOST_FEATURES;
> >- return 0;
> >+ return VHOST_FEATURES;
> > }
>
> This is not the topic of this series, but I wonder if it
> could make sense to be able to override supported features
> at device init time.
Not quite sure I understood it correctly: is rte_vhost_feature_disable()
the answer you are looking for?
> It may not match with the orignal purpose of supported features,
> but could be useful at least for testing without recompilation.
>
> For this patch:
> Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
Again, appreicate your time on review!
--yliu
next prev parent reply other threads:[~2016-08-25 2:53 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-18 8:48 [dpdk-dev] [PATCH 0/7] vhost: vhost-cuse removal and code path refactoring Yuanhan Liu
2016-08-18 8:48 ` [dpdk-dev] [PATCH 1/7] vhost: remove vhost-cuse Yuanhan Liu
2016-08-22 13:46 ` Thomas Monjalon
2016-08-22 14:09 ` Yuanhan Liu
2016-08-29 6:45 ` Yuanhan Liu
2016-08-24 7:42 ` Maxime Coquelin
2016-08-18 8:48 ` [dpdk-dev] [PATCH 2/7] vhost: remove sub source dir Yuanhan Liu
2016-08-24 7:44 ` Maxime Coquelin
2016-08-18 8:48 ` [dpdk-dev] [PATCH 3/7] vhost: refactor source code structure Yuanhan Liu
2016-08-24 7:53 ` Maxime Coquelin
2016-08-18 8:48 ` [dpdk-dev] [PATCH 4/7] vhost: fold common message handlers Yuanhan Liu
2016-08-24 8:01 ` Maxime Coquelin
2016-08-18 8:48 ` [dpdk-dev] [PATCH 5/7] vhost: unify function names Yuanhan Liu
2016-08-24 8:02 ` Maxime Coquelin
2016-08-18 8:48 ` [dpdk-dev] [PATCH 6/7] vhost: get device once Yuanhan Liu
2016-08-24 8:04 ` Maxime Coquelin
2016-08-18 8:48 ` [dpdk-dev] [PATCH 7/7] vhost: simplify features set/get Yuanhan Liu
2016-08-24 8:11 ` Maxime Coquelin
2016-08-25 3:03 ` Yuanhan Liu [this message]
2016-08-25 7:18 ` Maxime Coquelin
2016-08-25 8:36 ` Xu, Qian Q
2016-08-25 9:10 ` Maxime Coquelin
2016-08-26 4:15 ` Yuanhan Liu
2016-08-24 7:30 ` [dpdk-dev] [PATCH 0/7] vhost: vhost-cuse removal and code path refactoring Xu, Qian Q
2016-08-24 7:47 ` Yuanhan Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160825030319.GV30752@yliu-dev.sh.intel.com \
--to=yuanhan.liu@linux.intel.com \
--cc=dev@dpdk.org \
--cc=maxime.coquelin@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).