From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
To: Matthias Gatto <matthias.gatto@outscale.com>
Cc: dev@dpdk.org, huawei.xie@intel.com
Subject: Re: [dpdk-dev] [PATCH] virtio: remove obsolete comment
Date: Mon, 5 Sep 2016 10:25:25 +0800 [thread overview]
Message-ID: <20160905022525.GG30752@yliu-dev.sh.intel.com> (raw)
In-Reply-To: <20160902150521.680-1-matthias.gatto@outscale.com>
On Fri, Sep 02, 2016 at 05:05:21PM +0200, Matthias Gatto wrote:
> As new_device and destroy_device use an int instead of a "struct virtio_net *",
> The comment about setting VIRTIO_DEV_RUNNING doesn't make sense anymore, plus
> If I've correctly understand the code, the drivers take care of
> setting the flag before calling the callbacks, so I guess that this comment
> is obsolet and I've remove it.
Yes, it is. The flag had been moved for internal use since commit
550c9d27d143 ("vhost: set/reset device flags internally").
So, thanks and applied to dpdk-next-virtio.
--yliu
next prev parent reply other threads:[~2016-09-05 2:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-02 15:05 Matthias Gatto
2016-09-05 2:25 ` Yuanhan Liu [this message]
2016-09-05 9:18 ` Matthias Gatto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160905022525.GG30752@yliu-dev.sh.intel.com \
--to=yuanhan.liu@linux.intel.com \
--cc=dev@dpdk.org \
--cc=huawei.xie@intel.com \
--cc=matthias.gatto@outscale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).