From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
To: Zhiyong Yang <zhiyong.yang@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] virtio: xstats name issue
Date: Mon, 5 Sep 2016 12:33:29 +0800 [thread overview]
Message-ID: <20160905043329.GJ30752@yliu-dev.sh.intel.com> (raw)
In-Reply-To: <1472716874-34036-1-git-send-email-zhiyong.yang@intel.com>
Few generic (trivial) comments first:
- cc to related maintainers
- follow the right prefix, "net/virtio" but not "virtio"
- start commit summary with a verb, and start with "fix" for bug fixing patch.
On Thu, Sep 01, 2016 at 04:01:14PM +0800, Zhiyong Yang wrote:
> The patch fixes some xstats name issues and make the xstats name conform to
> code implementation(the function virtio_update_packet_stats).
I would fix it inside virtio_update_packet_stats(), to keep the consistency
of name style: starts with an even number, and ends with an odd number.
--yliu
>
> Signed-off-by: Zhiyong Yang <zhiyong.yang@intel.com>
> ---
> drivers/net/virtio/virtio_ethdev.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c
> index 07d6449..4cee067 100644
> --- a/drivers/net/virtio/virtio_ethdev.c
> +++ b/drivers/net/virtio/virtio_ethdev.c
> @@ -125,8 +125,8 @@ static const struct rte_virtio_xstats_name_off rte_virtio_rxq_stat_strings[] = {
> {"size_128_255_packets", offsetof(struct virtnet_rx, stats.size_bins[3])},
> {"size_256_511_packets", offsetof(struct virtnet_rx, stats.size_bins[4])},
> {"size_512_1023_packets", offsetof(struct virtnet_rx, stats.size_bins[5])},
> - {"size_1024_1517_packets", offsetof(struct virtnet_rx, stats.size_bins[6])},
> - {"size_1518_max_packets", offsetof(struct virtnet_rx, stats.size_bins[7])},
> + {"size_1024_1518_packets", offsetof(struct virtnet_rx, stats.size_bins[6])},
> + {"size_1519_max_packets", offsetof(struct virtnet_rx, stats.size_bins[7])},
> };
>
> /* [rt]x_qX_ is prepended to the name string here */
> @@ -142,8 +142,8 @@ static const struct rte_virtio_xstats_name_off rte_virtio_txq_stat_strings[] = {
> {"size_128_255_packets", offsetof(struct virtnet_tx, stats.size_bins[3])},
> {"size_256_511_packets", offsetof(struct virtnet_tx, stats.size_bins[4])},
> {"size_512_1023_packets", offsetof(struct virtnet_tx, stats.size_bins[5])},
> - {"size_1024_1517_packets", offsetof(struct virtnet_tx, stats.size_bins[6])},
> - {"size_1518_max_packets", offsetof(struct virtnet_tx, stats.size_bins[7])},
> + {"size_1024_1518_packets", offsetof(struct virtnet_tx, stats.size_bins[6])},
> + {"size_1519_max_packets", offsetof(struct virtnet_tx, stats.size_bins[7])},
> };
>
> #define VIRTIO_NB_RXQ_XSTATS (sizeof(rte_virtio_rxq_stat_strings) / \
> --
> 2.5.5
next prev parent reply other threads:[~2016-09-05 4:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-01 8:01 Zhiyong Yang
2016-09-05 4:33 ` Yuanhan Liu [this message]
2016-09-05 5:35 ` Yang, Zhiyong
2016-09-05 6:19 ` Yuanhan Liu
2016-09-06 7:50 ` [dpdk-dev] [PATCH v2] net/virtio: fix " Zhiyong Yang
2016-09-06 12:27 ` Yuanhan Liu
2016-09-07 1:32 ` Yang, Zhiyong
2016-09-07 6:11 ` [dpdk-dev] [PATCH v3] " Zhiyong Yang
2016-09-07 7:22 ` [dpdk-dev] [dpdk-stable] " Yuanhan Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160905043329.GJ30752@yliu-dev.sh.intel.com \
--to=yuanhan.liu@linux.intel.com \
--cc=dev@dpdk.org \
--cc=zhiyong.yang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).