From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
To: souvikdey33 <sodey@sonusnet.com>
Cc: dev@dpdk.org, stephen@networkplumber.org
Subject: Re: [dpdk-dev] [PATCH v3]virtio:add mtu set in virtio
Date: Wed, 7 Sep 2016 11:37:59 +0800 [thread overview]
Message-ID: <20160907033759.GH23158@yliu-dev.sh.intel.com> (raw)
In-Reply-To: <20160907032156.34492-1-sodey@sonusnet.com>
Firstly, thanks for the patch!
And I got few more style issues for you :) The first goes to the subject
(commit summary):
- the prefix is "net/virtio", but not "virtio"
- a space is needed after ':'
On Tue, Sep 06, 2016 at 11:21:56PM -0400, souvikdey33 wrote:
> Signed-off-by: Souvik Dey <sodey@sonusnet.com>
SoB should go the end of the commit log.
> Fixes: 1fb8e8896ca8 ("Signed-off-by: Souvik Dey <sodey@sonusnet.com>")
The fixline is needed for bug fixing patch only. Besides that, the
commit has to be an commit has been applied before.
> Reviewed-by: Stephen Hemminger <stephen@networkplumber.org>
I don't see such Reviewed-by from Stephen. I think you should not add it,
unless someone has given you that, explicitly.
> Virtio interfaces should also support setting of mtu, as in case of cloud
> it is expected to have the consistent mtu across the infrastructure that
> the dhcp server sends and not hardcoded to 1500(default).
> ---
> Corrected few style errors as reported by sys-stv.
It's better to keep old changes, such as:
v3: correct few style errors ...
v2: ....
FYI, you might want to read others patch to get more used to the right
way of making a patch.
>
> drivers/net/virtio/virtio_ethdev.c | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c
> index 07d6449..da16ad4 100644
> --- a/drivers/net/virtio/virtio_ethdev.c
> +++ b/drivers/net/virtio/virtio_ethdev.c
> @@ -92,6 +92,7 @@ static void virtio_mac_addr_add(struct rte_eth_dev *dev,
> static void virtio_mac_addr_remove(struct rte_eth_dev *dev, uint32_t index);
> static void virtio_mac_addr_set(struct rte_eth_dev *dev,
> struct ether_addr *mac_addr);
> +static int virtio_mtu_set(struct rte_eth_dev *dev, uint16_t mtu);
I think it's not necessary if you defined the function before the usage.
--yliu
next prev parent reply other threads:[~2016-09-07 3:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-07 3:21 souvikdey33
2016-09-07 3:37 ` Yuanhan Liu [this message]
2016-09-07 3:45 ` Dey, Souvik
2016-09-07 3:42 ` Yuanhan Liu
2016-09-07 3:47 ` Dey, Souvik
2016-09-07 3:53 ` Yuanhan Liu
2016-09-07 4:04 ` Dey, Souvik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160907033759.GH23158@yliu-dev.sh.intel.com \
--to=yuanhan.liu@linux.intel.com \
--cc=dev@dpdk.org \
--cc=sodey@sonusnet.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).