From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
To: "Dey, Souvik" <sodey@sonusnet.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"stephen@networkplumber.org" <stephen@networkplumber.org>
Subject: Re: [dpdk-dev] [PATCH v3]virtio:add mtu set in virtio
Date: Wed, 7 Sep 2016 11:53:59 +0800 [thread overview]
Message-ID: <20160907035359.GJ23158@yliu-dev.sh.intel.com> (raw)
In-Reply-To: <BN3PR03MB1494AB38DC5AC42ACDCCDC0CDAF80@BN3PR03MB1494.namprd03.prod.outlook.com>
On Wed, Sep 07, 2016 at 03:47:27AM +0000, Dey, Souvik wrote:
> Ok will change it. Do I need to submit a new v4 for that ?
Yes.
> can I put your name also in the reviewed by list?
Nope, you should not add that. I just offered some comments. And yes, I
reviewed your patch, but that doesn't mean you could add my Reviewed-by.
You can only add the Reviewed-by tag only when the reviewer gave it to
you, explicitly, like following:
Reviewed-by: Some One <some@one.com>
--yliu
>
> -----Original Message-----
> From: Yuanhan Liu [mailto:yuanhan.liu@linux.intel.com]
> Sent: Tuesday, September 6, 2016 11:43 PM
> To: Dey, Souvik <sodey@sonusnet.com>
> Cc: dev@dpdk.org; stephen@networkplumber.org
> Subject: Re: [dpdk-dev] [PATCH v3]virtio:add mtu set in virtio
>
> On Tue, Sep 06, 2016 at 11:21:56PM -0400, souvikdey33 wrote:
> > +static int
> > +virtio_mtu_set(struct rte_eth_dev *dev, uint16_t mtu) {
> > + struct virtio_hw *hw = dev->data->dev_private;
> > + if (mtu < VIRTIO_MIN_RX_BUFSIZE || mtu > VIRTIO_MAX_RX_PKTLEN) {
> > + PMD_INIT_LOG(ERR, "Mtu should be between 64 and 9728\n");
>
> I forgot to mention in last email, that you should not use the number (64 and 9728) directly, use the MACRO instead.
>
> --yliu
next prev parent reply other threads:[~2016-09-07 3:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-07 3:21 souvikdey33
2016-09-07 3:37 ` Yuanhan Liu
2016-09-07 3:45 ` Dey, Souvik
2016-09-07 3:42 ` Yuanhan Liu
2016-09-07 3:47 ` Dey, Souvik
2016-09-07 3:53 ` Yuanhan Liu [this message]
2016-09-07 4:04 ` Dey, Souvik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160907035359.GJ23158@yliu-dev.sh.intel.com \
--to=yuanhan.liu@linux.intel.com \
--cc=dev@dpdk.org \
--cc=sodey@sonusnet.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).