From: Stephen Hemminger <stephen@networkplumber.org>
To: zhouyangchao <zhouyates@gmail.com>
Cc: ferruh.yigit@intel.com, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] kni: unregister an unregisterd net_device could cause a kernel crash
Date: Thu, 8 Sep 2016 09:47:35 -0700 [thread overview]
Message-ID: <20160908094735.5861477b@xeon-e3> (raw)
In-Reply-To: <1473388936-2706-1-git-send-email-zhouyates@gmail.com>
On Fri, 9 Sep 2016 10:42:16 +0800
zhouyangchao <zhouyates@gmail.com> wrote:
> Signed-off-by: zhouyangchao <zhouyates@gmail.com>
> ---
> lib/librte_eal/linuxapp/kni/kni_misc.c | 3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/lib/librte_eal/linuxapp/kni/kni_misc.c b/lib/librte_eal/linuxapp/kni/kni_misc.c
> index 67e9b7d..17b6d7a 100644
> --- a/lib/librte_eal/linuxapp/kni/kni_misc.c
> +++ b/lib/librte_eal/linuxapp/kni/kni_misc.c
> @@ -361,6 +361,9 @@ kni_dev_remove(struct kni_dev *dev)
> igb_kni_remove(dev->pci_dev);
>
> if (dev->net_dev) {
> + if (dev->net_dev->state == NETREG_REGISTERED) {
> + unregister_netdev(dev->net_dev);
> + }
> unregister_netdev(dev->net_dev);
> free_netdev(dev->net_dev);
> }
The real problem is kni_dev_remove should not be called when register_netdevice
fails. Why not just fix that unwind path.
next prev parent reply other threads:[~2016-09-08 16:47 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-09 2:42 zhouyangchao
2016-09-08 16:47 ` Stephen Hemminger [this message]
2016-09-09 2:46 zhouyangchao
2016-09-08 16:44 ` Stephen Hemminger
2016-09-08 17:15 ` Ferruh Yigit
2016-09-09 12:40 ` Thomas Monjalon
2016-09-09 14:33 ` Mcnamara, John
2016-09-10 7:57 ` Thomas Monjalon
2016-09-08 17:07 ` Ferruh Yigit
2016-09-11 9:59 ` zhouyangchao
2016-09-13 13:13 ` Ferruh Yigit
2016-09-21 16:41 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160908094735.5861477b@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=zhouyates@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).