From: Stephen Hemminger <stephen@networkplumber.org>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] kni: fix build with kernel 4.8
Date: Thu, 8 Sep 2016 11:00:40 -0700 [thread overview]
Message-ID: <20160908110040.32ec79f5@xeon-e3> (raw)
In-Reply-To: <1473357296-10375-1-git-send-email-ferruh.yigit@intel.com>
On Thu, 8 Sep 2016 18:54:56 +0100
Ferruh Yigit <ferruh.yigit@intel.com> wrote:
> Linux kernel v4.8 removes macro DEFINE_PCI_DEVICE_TABLE
>
> Linux: 7e9321599011 ("treewide: remove references to the now unnecessary
> DEFINE_PCI_DEVICE_TABLE")
>
> Added the macro to compatibility headers of the kni ethtool drivers.
>
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> ---
> lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h | 7 +++++++
> lib/librte_eal/linuxapp/kni/ethtool/ixgbe/kcompat.h | 6 ++++++
> 2 files changed, 13 insertions(+)
>
> diff --git a/lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h b/lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h
> index bdd0806..9560aae 100644
> --- a/lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h
> +++ b/lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h
> @@ -3915,4 +3915,11 @@ skb_set_hash(struct sk_buff *skb, __u32 hash, __always_unused int type)
> /* ndo_bridge_getlink adds new filter_mask and vlan_fill parameters */
> #define HAVE_NDO_BRIDGE_GETLINK_FILTER_MASK_VLAN_FILL
> #endif /* >= 4.2.0 */
> +
> +#if ( LINUX_VERSION_CODE >= KERNEL_VERSION(4,8,0) )
> +#ifndef DEFINE_PCI_DEVICE_TABLE
> +#define DEFINE_PCI_DEVICE_TABLE(_table) const struct pci_device_id _table[]
> +#endif /* DEFINE_PCI_DEVICE_TABLE */
> +#endif /* >= 4.8.0 */
> +
Good to see the KNI driver staying up to date with upstream.
Please just remove use of DEFINE_PCI_DEVICE_TABLE rather than resurrecting it!
next prev parent reply other threads:[~2016-09-08 18:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-08 17:54 Ferruh Yigit
2016-09-08 18:00 ` Stephen Hemminger [this message]
2016-09-08 18:32 ` [dpdk-dev] [PATCH v2] " Ferruh Yigit
2016-09-09 22:33 ` De Lara Guarch, Pablo
2016-09-21 16:17 ` Thomas Monjalon
2016-09-19 12:21 ` Christian Ehrhardt
2016-09-20 19:03 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160908110040.32ec79f5@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).