From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
To: "Wiles, Keith" <keith.wiles@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"pmatilai@redhat.com" <pmatilai@redhat.com>
Subject: Re: [dpdk-dev] [PATCH v2] drivers/net:new PMD using tun/tap host interface
Date: Wed, 21 Sep 2016 10:13:51 +0800 [thread overview]
Message-ID: <20160921021351.GY23158@yliu-dev.sh.intel.com> (raw)
In-Reply-To: <17C91FD1-D21A-49E3-B093-71AA5C1D79C6@intel.com>
On Wed, Sep 21, 2016 at 01:32:15AM +0000, Wiles, Keith wrote:
> The concern I am having is on my standard Ubuntu 16.04 system these errors do not appear.
Yes, that's really weird. To me, it's such a solid error that could be
triggered on all linux platforms.
Anyway, I saw you removed the <net/if.h> including in v3, which makes
my robot happy :)
> I would like to understand why they appeared on your system. The ifdef __linux__ must be enabled as the defines in the linux/if_tun.h file do not give an error. I did play with the headers already and removed the ifdef, but as I could not reproduce your build failure it did not trigger anything new.
>
> I will look at it some more, but it does not make sense and I do want to make sure it works.
>
> >
> >> +#include <linux/if.h>
> >> +#include <linux/if_tun.h>
> >> +#include <linux/if_ether.h>
> >> +#else
> >> +#include <netinet/if_ether.h>
> >> +#endif
> >> +#include <fcntl.h>
> >> +
> >> +#include <poll.h>
> >> +
> >> +/* Linux based path to the TUN device */
> >> +#define TUN_TAP_DEV_PATH "/dev/net/tun"
> >
> > However, you hardcoded a linux only path here. While checking the code
> > from qemu, I saw that the path is actually different from different UNIX
> > variants, even for FreeBSD and NetBSD.
>
> I only assumed this to work for Linux and not FreeBSD/NetBSD as the handling of the opens on the tun device are different then linux. I also only added it to the common_linux configuration file.
I didn't notice the common_linux file, but I have guessed so (that you
meant to enable linux only): the "ifdef __linux" stuff just confuses me
a bit.
--yliu
>
> >
> > [yliu@yliu-dev ~/qemu]$ grep -E "/dev/.*(tap|tun)" net/tap*.c
> > net/tap-bsd.c: snprintf(dname, sizeof dname, "/dev/tun%d", i);
> > net/tap-bsd.c: snprintf(dname, sizeof dname, "/dev/tap%d", i);
> > net/tap-bsd.c:#define PATH_NET_TAP "/dev/tap"
> > net/tap-linux.c:#define PATH_NET_TUN "/dev/net/tun"
> > net/tap-solaris.c: TFR(tap_fd = open("/dev/tap", O_RDWR, 0));
> > ...
> >
> > --yliu
next prev parent reply other threads:[~2016-09-21 2:13 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-15 14:10 [dpdk-dev] [PATCH 1/3] " Keith Wiles
2016-09-15 14:10 ` [dpdk-dev] [PATCH 2/3] docs:tun/tap PMD information Keith Wiles
2016-09-15 14:13 ` Wiles, Keith
2016-09-15 14:15 ` Wiles, Keith
2016-09-21 2:00 ` [dpdk-dev] [PATCH v3] drivers/net:new PMD using tun/tap host interface Keith Wiles
2016-10-04 14:45 ` [dpdk-dev] [PATCH v4] " Keith Wiles
2016-10-11 9:40 ` Ferruh Yigit
2016-10-11 11:30 ` Michał Mirosław
2016-10-11 20:56 ` Wiles, Keith
2016-10-12 8:14 ` Michał Mirosław
2016-10-11 11:49 ` Ferruh Yigit
2016-10-11 21:07 ` Wiles, Keith
2016-10-11 12:28 ` Ferruh Yigit
2016-10-11 20:57 ` Wiles, Keith
2016-10-11 21:51 ` [dpdk-dev] [PATCH v5] " Keith Wiles
2016-10-12 14:56 ` Ferruh Yigit
2016-10-12 18:19 ` Wiles, Keith
2016-10-12 19:57 ` Wiles, Keith
2016-10-12 20:54 ` [dpdk-dev] [PATCH v6] " Keith Wiles
2016-10-13 14:41 ` Ferruh Yigit
2016-10-13 15:36 ` [dpdk-dev] [PATCH v7] " Keith Wiles
2016-10-13 16:11 ` [dpdk-dev] [PATCH v8] " Keith Wiles
2016-10-13 16:33 ` Mcnamara, John
2016-10-13 22:03 ` [dpdk-dev] [PATCH v9] " Keith Wiles
2016-10-14 6:41 ` Mcnamara, John
2016-10-14 9:39 ` Ferruh Yigit
2016-11-21 12:56 ` Ferruh Yigit
2016-11-25 19:38 ` Aws Ismail
2016-11-29 21:36 ` Aws Ismail
2016-11-29 22:16 ` Wiles, Keith
2016-12-07 19:38 ` [dpdk-dev] [PATCH v10] drivers/net:new TUN/TAP device PMD Keith Wiles
2016-12-07 20:15 ` Aws Ismail
2016-12-09 18:16 ` Ferruh Yigit
2016-12-09 19:05 ` [dpdk-dev] [PATCH v11] " Keith Wiles
2016-12-12 12:39 ` Vasily Philipov
2016-12-12 14:24 ` [dpdk-dev] [PATCH v12] net/tap: new " Keith Wiles
2016-12-12 14:38 ` Keith Wiles
2016-12-12 19:13 ` Marc
2016-12-12 21:09 ` Wiles, Keith
2016-12-13 13:54 ` Ferruh Yigit
2017-01-20 12:14 ` Ferruh Yigit
2017-01-20 14:25 ` [dpdk-dev] [PATCH] net/tap: fix IFF_MULTI_QUEUE in older kernels not found Keith Wiles
2017-01-20 14:30 ` Keith Wiles
2017-01-20 16:11 ` Ferruh Yigit
2017-01-20 17:37 ` Thomas Monjalon
2016-09-15 14:10 ` [dpdk-dev] [PATCH 3/3] drivers/net:build support for new tap device driver Keith Wiles
2016-09-16 7:36 ` Panu Matilainen
2016-09-16 14:46 ` Wiles, Keith
2016-09-16 16:22 ` [dpdk-dev] [PATCH v2] drivers/net:new PMD using tun/tap host interface Keith Wiles
2016-09-18 13:25 ` Yuanhan Liu
2016-09-18 16:20 ` Wiles, Keith
2016-09-19 0:29 ` Yuanhan Liu
2016-09-19 15:56 ` Wiles, Keith
2016-09-20 3:54 ` Yuanhan Liu
2016-09-20 4:05 ` Yuanhan Liu
2016-09-21 1:32 ` Wiles, Keith
2016-09-21 2:13 ` Yuanhan Liu [this message]
2016-09-21 8:24 ` Thomas Monjalon
2016-09-21 23:55 ` Wiles, Keith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160921021351.GY23158@yliu-dev.sh.intel.com \
--to=yuanhan.liu@linux.intel.com \
--cc=dev@dpdk.org \
--cc=keith.wiles@intel.com \
--cc=pmatilai@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).