From: Bruce Richardson <bruce.richardson@intel.com>
To: John Daley <johndale@cisco.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] net/enic: bad L4 checksum ptype set on ICMP packets
Date: Wed, 21 Sep 2016 12:19:38 +0100 [thread overview]
Message-ID: <20160921111937.GJ16464@bricha3-MOBL3> (raw)
In-Reply-To: <1471472126-8103-1-git-send-email-johndale@cisco.com>
On Wed, Aug 17, 2016 at 03:15:26PM -0700, John Daley wrote:
> The bad L4 checksum flag was set on IP packets which were not
> also TCP or UDP packets. This includes ICMP, IGMP and OSPF packets.
>
> L4 ptypes were being treated as bits instead of values within the
> L4 mask causing the code to check L4 checksum in the completion
> queue and incorrectly set the L4 bad checksum flag.
>
> Fixes: 947d860c821f ("enic: improve Rx performance")
>
> Reviewed-by: Nelson Escobar <neescoba@cisco.com>
> Signed-off-by: John Daley <johndale@cisco.com>
Applied to dpdk-next-net/rel_16_11
/Bruce
prev parent reply other threads:[~2016-09-21 11:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-17 22:15 John Daley
2016-09-21 11:19 ` Bruce Richardson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160921111937.GJ16464@bricha3-MOBL3 \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=johndale@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).