From: Bruce Richardson <bruce.richardson@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: "Iremonger, Bernard" <bernard.iremonger@intel.com>,
dev@dpdk.org, Jerin Jacob <jerin.jacob@caviumnetworks.com>,
"Shah, Rahul R" <rahul.r.shah@intel.com>,
"Lu, Wenzhuo" <wenzhuo.lu@intel.com>, azelezniak <alexz@att.com>
Subject: Re: [dpdk-dev] [RFC PATCH v2 3/5] librte_ether: add API's for VF management
Date: Fri, 23 Sep 2016 11:34:12 +0100 [thread overview]
Message-ID: <20160923103411.GA59204@bricha3-MOBL3> (raw)
In-Reply-To: <3936536.tPp6g5Daih@xps13>
On Fri, Sep 23, 2016 at 11:36:21AM +0200, Thomas Monjalon wrote:
> 2016-09-23 10:20, Bruce Richardson:
> > On Thu, Sep 22, 2016 at 07:04:37PM +0200, Thomas Monjalon wrote:
> > > 2016-09-15 16:46, Iremonger, Bernard:
> > > > > > > Do we really need to expose VF specific functions here?
> > > > > > > It can be generic(PF/VF) function indexed only through port_id.
> > > > > > > (example: as rte_eth_dev_set_vlan_anti_spoof(uint8_t port_id,
> > > > > > > uint8_t on)) For instance, In Thunderx PMD, We are not exposing a
> > > > > > > separate port_id for PF. We only enumerate 0..N VFs as 0..N ethdev
> > > > > > > port_id
> > > > > >
> > > > > > Our intention with this patch is to control the VF from the PF.
> > > > > >
> > > > > > The following librte_ether functions already work in a similar way:
> > > > > >
> > > > > > rte_eth_dev_set_vf_rxmode(uint8_t port_id, uint16_t vf, uint16_t
> > > > > > rx_mode, uint8_t on)
> > > > > >
> > > > > > rte_eth_dev_set_vf_rx(uint8_t port_id, uint16_t vf, uint8_t on)
> > > > > >
> > > > > > rte_eth_dev_set_vf_tx(uint8_t port_id, uint16_t vf, uint8_t on)
> > > > > >
> > > > > > int rte_eth_set_vf_rate_limit(uint8_t port_id, uint16_t vf, uint16_t
> > > > > > tx_rate, uint64_t q_msk)
> > > > >
> > > > > I have a bad feeling with these functions dedicated to VF from PF.
> > > > > Are we sure there is no other way?
> > > > > I mean we just need to know the VF with a port ID.
> > > >
> > > > When the VF is used in a VM the port ID of the VF is not visible to the PF.
> > > > I don't think there is another way to do this.
> > >
> > > I don't understand why we could not assign a port id to the VF from the
> > > host instead of having the couple PF port id / VF id.
> > > Can we enumerate all the VFs associated to a PF?
> > > Then can we allocate them a port id in the array rte_eth_devices?
> >
> > Hi Thomas,
> >
> > The VF is not a port visible to DPDK, though, so it shouldn't have a port id
> > IMHO. DPDK can't actually do anything with it.
>
> You say the contrary below.
>
> > The PCI device for the VF is likely passed through to a different VM and being
> > used there. Unfortunately, the VF still needs certain things done for it by the
> > PF, so if the PF is under DPDK control, it needs to provide the functionality
> > to assist the VF.
>
> Why not have a VF_from_PF driver which does the mailbox things?
> So you can manage the VF from the PF with a simple port id.
> It really seems to be the cleanest design to me.
Just to confirm I am understanding your suggestion correctly:
* for a normal app, eg. testpmd or l2fwd, things stay exactly as they are
* for an app that wants to control VFs from PFs, then we provide a new
ethdev driver, and a call in the PF to create an new instance of it
e.g. rte_eth_vf_from_pf(pf_port_id, vf_number)
* then to control the VF, you make regular rte_ethdev calls using the new
ethdev port id you got from the vf_from_pf call.
* it's up to that app to know what ports are regular ports that can do IO,
and what ports are VF control ports, though we may add in an ethdev flag value
somewhere to assist in this.
Is that basically it?
/Bruce
next prev parent reply other threads:[~2016-09-23 10:34 UTC|newest]
Thread overview: 95+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-18 13:48 [dpdk-dev] [RFC PATCH 0/5] " Bernard Iremonger
2016-08-18 13:48 ` [dpdk-dev] [RFC PATCH 1/5] librte_ether: add internal callback functions Bernard Iremonger
2016-08-18 13:48 ` [dpdk-dev] [RFC PATCH 2/5] net/ixgbe: add callback to user app on VF to PF mbox msg Bernard Iremonger
2016-08-18 13:48 ` [dpdk-dev] [RFC PATCH 3/5] librte_ether: add API's for VF management Bernard Iremonger
2016-08-18 13:48 ` [dpdk-dev] [RFC PATCH 4/5] net/ixgbe: add functions " Bernard Iremonger
2016-08-18 13:48 ` [dpdk-dev] [RFC PATCH 5/5] app/test_pmd: add tests for new API's Bernard Iremonger
2016-08-26 9:10 ` [dpdk-dev] [RFC PATCH v2 0/5] add API's for VF management Bernard Iremonger
2016-08-26 9:10 ` [dpdk-dev] [RFC PATCH v2 1/5] librte_ether: add internal callback functions Bernard Iremonger
2016-09-09 14:10 ` Jerin Jacob
[not found] ` <3C0218D8B3DD114D8DBFE6B68141FBE3185F9FE7@MISOUT7MSGUSRDI.ITServices.sbc.com>
2016-09-13 8:45 ` Jerin Jacob
[not found] ` <3C0218D8B3DD114D8DBFE6B68141FBE3185FDCDC@MISOUT7MSGUSRDI.ITServices.sbc.com>
2016-09-14 11:28 ` Jerin Jacob
2016-09-22 11:25 ` Iremonger, Bernard
2016-10-03 8:58 ` Iremonger, Bernard
2016-08-26 9:10 ` [dpdk-dev] [RFC PATCH v2 2/5] net/ixgbe: add callback to user app on VF to PF mbox msg Bernard Iremonger
2016-08-26 9:10 ` [dpdk-dev] [RFC PATCH v2 3/5] librte_ether: add API's for VF management Bernard Iremonger
2016-09-09 14:22 ` Jerin Jacob
2016-09-12 16:28 ` Iremonger, Bernard
2016-09-13 9:24 ` Thomas Monjalon
2016-09-15 16:46 ` Iremonger, Bernard
2016-09-22 17:04 ` Thomas Monjalon
2016-09-23 9:20 ` Bruce Richardson
2016-09-23 9:36 ` Thomas Monjalon
2016-09-23 9:53 ` Richardson, Bruce
2016-09-23 13:15 ` Thomas Monjalon
2016-09-23 17:02 ` Iremonger, Bernard
2016-09-23 17:18 ` Thomas Monjalon
2016-09-26 15:37 ` Iremonger, Bernard
2016-09-26 16:59 ` Thomas Monjalon
2016-09-27 10:31 ` Iremonger, Bernard
2016-09-27 13:01 ` Bruce Richardson
2016-09-27 14:13 ` Iremonger, Bernard
2016-09-28 11:23 ` Ananyev, Konstantin
2016-09-28 12:31 ` Iremonger, Bernard
2016-09-28 13:01 ` Richardson, Bruce
2016-09-28 13:03 ` Thomas Monjalon
2016-09-28 13:26 ` Ananyev, Konstantin
2016-09-28 14:24 ` Thomas Monjalon
2016-09-28 14:30 ` Ananyev, Konstantin
2016-09-28 14:48 ` Iremonger, Bernard
2016-09-28 15:00 ` Thomas Monjalon
2016-09-28 15:24 ` Iremonger, Bernard
2016-09-28 14:59 ` Thomas Monjalon
2016-09-28 16:52 ` Ananyev, Konstantin
2016-09-28 18:02 ` Thomas Monjalon
2016-09-30 9:21 ` Bruce Richardson
2016-09-23 10:34 ` Bruce Richardson [this message]
2016-08-26 9:10 ` [dpdk-dev] [RFC PATCH v2 4/5] net/ixgbe: add functions " Bernard Iremonger
2016-08-26 9:10 ` [dpdk-dev] [RFC PATCH v2 5/5] app/test_pmd: add tests for new API's Bernard Iremonger
2016-09-11 12:35 ` Yuanhan Liu
2016-09-12 15:57 ` Iremonger, Bernard
2016-09-13 4:34 ` Yuanhan Liu
2016-09-13 8:38 ` Iremonger, Bernard
2016-09-13 8:42 ` Yuanhan Liu
2016-09-07 9:18 ` [dpdk-dev] [RFC PATCH v2 0/5] add API's for VF management Pattan, Reshma
2016-09-09 8:49 ` Pattan, Reshma
2016-09-09 13:02 ` Thomas Monjalon
2016-09-16 11:05 ` [dpdk-dev] [PATCH v3 0/3] " Bernard Iremonger
2016-09-16 11:05 ` [dpdk-dev] [PATCH v3 1/3] librte_ether: " Bernard Iremonger
2016-09-16 11:05 ` [dpdk-dev] [PATCH v3 2/3] net/ixgbe: add functions " Bernard Iremonger
2016-09-16 11:05 ` [dpdk-dev] [PATCH v3 3/3] app/test_pmd: add tests for new API's Bernard Iremonger
2016-09-16 14:15 ` [dpdk-dev] [PATCH v3 0/3] add API's for VF management Bernard Iremonger
2016-09-21 10:20 ` [dpdk-dev] [PATCH v4 " Bernard Iremonger
2016-09-29 14:16 ` [dpdk-dev] [PATCH v5 " Bernard Iremonger
2016-09-30 10:30 ` [dpdk-dev] [PATCH v6 0/2] " Bernard Iremonger
2016-09-30 10:30 ` [dpdk-dev] [PATCH v6 1/2] net/ixgbe: " Bernard Iremonger
2016-10-07 10:45 ` [dpdk-dev] [PATCH v7 0/2] " Bernard Iremonger
2016-10-07 10:45 ` [dpdk-dev] [PATCH v7 1/2] net/ixgbe: " Bernard Iremonger
2016-10-07 10:45 ` [dpdk-dev] [PATCH v7 2/2] app/test_pmd: add tests for new API's Bernard Iremonger
2016-10-11 15:09 ` Ferruh Yigit
2016-10-11 15:41 ` Thomas Monjalon
2016-10-11 15:51 ` Iremonger, Bernard
2016-10-11 16:32 ` Thomas Monjalon
2016-10-11 16:35 ` Iremonger, Bernard
2016-10-12 2:05 ` De Lara Guarch, Pablo
2016-10-12 15:00 ` Iremonger, Bernard
2016-09-30 10:30 ` [dpdk-dev] [PATCH v6 " Bernard Iremonger
2016-09-29 14:16 ` [dpdk-dev] [PATCH v5 1/3] librte_ether: add API for VF management Bernard Iremonger
2016-09-29 14:30 ` Thomas Monjalon
2016-09-29 15:16 ` Iremonger, Bernard
2016-09-29 16:19 ` Thomas Monjalon
2016-09-29 16:38 ` Iremonger, Bernard
2016-09-29 16:45 ` Thomas Monjalon
2016-09-29 14:16 ` [dpdk-dev] [PATCH v5 2/3] net/ixgbe: add API's " Bernard Iremonger
2016-09-29 16:11 ` Reshma Pattan
2016-09-29 16:32 ` Iremonger, Bernard
2016-09-29 16:16 ` Pattan, Reshma
2016-09-29 16:30 ` Iremonger, Bernard
2016-09-29 14:16 ` [dpdk-dev] [PATCH v5 3/3] app/test_pmd: add tests for new API's Bernard Iremonger
2016-09-21 10:20 ` [dpdk-dev] [PATCH v4 1/3] librte_ether: add API's for VF management Bernard Iremonger
2016-09-21 10:20 ` [dpdk-dev] [PATCH v4 2/3] net/ixgbe: add functions " Bernard Iremonger
2016-09-21 10:20 ` [dpdk-dev] [PATCH v4 3/3] app/test_pmd: add tests for new API's Bernard Iremonger
2016-09-16 14:15 ` [dpdk-dev] [PATCH v3 1/3] librte_ether: add API's for VF management Bernard Iremonger
2016-09-16 14:15 ` [dpdk-dev] [PATCH v3 2/3] net/ixgbe: add functions " Bernard Iremonger
2016-09-16 14:15 ` [dpdk-dev] [PATCH v3 3/3] app/test_pmd: add tests for new API's Bernard Iremonger
2016-09-28 19:25 [dpdk-dev] [RFC PATCH v2 3/5] librte_ether: add API's for VF management ZELEZNIAK, ALEX
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160923103411.GA59204@bricha3-MOBL3 \
--to=bruce.richardson@intel.com \
--cc=alexz@att.com \
--cc=bernard.iremonger@intel.com \
--cc=dev@dpdk.org \
--cc=jerin.jacob@caviumnetworks.com \
--cc=rahul.r.shah@intel.com \
--cc=thomas.monjalon@6wind.com \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).