From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
To: Gowrishankar <gowrishankar.m@linux.vnet.ibm.com>
Cc: dpdk stable <stable@dpdk.org>,
Chao Zhu <chaozhu@linux.vnet.ibm.com>,
Cristian Dumitrescu <cristian.dumitrescu@intel.com>,
Pradeep <pradeep@us.ibm.com>
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v7 8/9] ip_pipeline: fix lcore mapping for varying SMT threads as in ppc64
Date: Tue, 27 Sep 2016 14:28:38 +0800 [thread overview]
Message-ID: <20160927062838.GF25823@yliu-dev.sh.intel.com> (raw)
In-Reply-To: <1ba7bc01d7083769a7b1bd1417efdf6b94b8ae5b.1473349652.git.gowrishankar.m@linux.vnet.ibm.com>
On Thu, Sep 08, 2016 at 10:18:10PM +0530, Gowrishankar wrote:
> From: Gowrishankar Muthukrishnan <gowrishankar.m@linux.vnet.ibm.com>
>
> This patch fixes ip_pipeline panic in app_init_core_map while preparing cpu
> core map in powerpc with SMT off. cpu_core_map_compute_linux currently prepares
> core mapping based on file existence in sysfs ie.
>
> /sys/devices/system/cpu/cpu<LCORE_NUM>/topology/physical_package_id
> /sys/devices/system/cpu/cpu<LCORE_NUM>/topology/core_id
>
> These files do not exist for lcores which are offline for any reason (as in
> powerpc, while SMT is off). In this situation, this function should further
> continue preparing map for other online lcores instead of returning with -1
> for a first unavailable lcore.
>
> Also, in SMT=off scenario for powerpc, lcore ids can not be always indexed from
> 0 upto 'number of cores present' (/sys/devices/system/cpu/present). For eg, for
> an online lcore 32, core_id returned in sysfs is 112 where online lcores are
> 10 (as in one configuration), hence sysfs lcore id can not be checked with
> indexing lcore number before positioning lcore map array.
>
> Signed-off-by: Gowrishankar Muthukrishnan <gowrishankar.m@linux.vnet.ibm.com>
> Acked by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
> Acked-by: Chao Zhu <chaozhu@linux.vnet.ibm.com>
FYI, this patch has been applied to stable branch v16.07.
It hasn't been pushed to http://dpdk.org/browse/dpdk-stable/ yet.
It will be pushed if I get no objections in around TWO days. So
please shutout if you have objections.
Thanks.
--yliu
next parent reply other threads:[~2016-09-27 6:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1473349652.git.gowrishankar.m@linux.vnet.ibm.com>
[not found] ` <1ba7bc01d7083769a7b1bd1417efdf6b94b8ae5b.1473349652.git.gowrishankar.m@linux.vnet.ibm.com>
2016-09-27 6:28 ` Yuanhan Liu [this message]
[not found] ` <3EB4FA525960D640B5BDFFD6A3D8912647A66EBC@IRSMSX108.ger.corp.intel.com>
[not found] ` <2096077.zsYv3Q4577@xps13>
2016-09-27 6:46 ` [dpdk-stable] [PATCH v7 0/9] enable lpm, acl and other missing libraries in ppc64le gowrishankar muthukrishnan
2016-09-27 7:01 ` Yuanhan Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160927062838.GF25823@yliu-dev.sh.intel.com \
--to=yuanhan.liu@linux.intel.com \
--cc=chaozhu@linux.vnet.ibm.com \
--cc=cristian.dumitrescu@intel.com \
--cc=gowrishankar.m@linux.vnet.ibm.com \
--cc=pradeep@us.ibm.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).