From: Neil Horman <nhorman@tuxdriver.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] pmdinfogen: fix clang build error
Date: Wed, 28 Sep 2016 07:35:19 -0400 [thread overview]
Message-ID: <20160928113519.GA28138@hmsreliant.think-freely.org> (raw)
In-Reply-To: <20160928100519.14885-1-ferruh.yigit@intel.com>
On Wed, Sep 28, 2016 at 11:05:19AM +0100, Ferruh Yigit wrote:
> Compile error:
> CC mlx5.o.pmd.o
> mlx5.o.pmd.c:1:227:
> error: no newline at end of file [-Werror,-Wnewline-eof]
> ...__attribute__((used)) = "PMD_INFO_STRING= {...}";
> ^
>
> Produced with clang 3.8.0 and MLX5_PMD and MLX5_DEBUG
> config options enabled.
>
> Fixes: 98b0fdb0ffc6 ("pmdinfogen: add buildtools and pmdinfogen utility")
>
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> ---
> buildtools/pmdinfogen/pmdinfogen.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/buildtools/pmdinfogen/pmdinfogen.c b/buildtools/pmdinfogen/pmdinfogen.c
> index e1bf2e4..59ab956 100644
> --- a/buildtools/pmdinfogen/pmdinfogen.c
> +++ b/buildtools/pmdinfogen/pmdinfogen.c
> @@ -386,7 +386,7 @@ static void output_pmd_info_string(struct elf_info *info, char *outfile)
> else
> fprintf(ofd, " ");
> }
> - fprintf(ofd, "]}\";");
> + fprintf(ofd, "]}\";\n");
> drv = drv->next;
> }
>
> --
> 2.7.4
>
>
What was the error this produced? It seems like a false positive to me to
require a newline at the end of a string, and it certainly doesn't provide any
benefit when pmdinfo reads it back later.
Neil
next prev parent reply other threads:[~2016-09-28 11:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-28 10:05 Ferruh Yigit
2016-09-28 11:35 ` Neil Horman [this message]
2016-09-28 12:15 ` Ferruh Yigit
2016-10-04 9:48 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160928113519.GA28138@hmsreliant.think-freely.org \
--to=nhorman@tuxdriver.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).