DPDK patches and discussions
 help / color / mirror / Atom feed
From: Adrien Mazarguil <adrien.mazarguil@6wind.com>
To: Olivier Gournet <ogournet@corp.free.fr>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix init on secondary process
Date: Tue, 11 Oct 2016 11:45:38 +0200	[thread overview]
Message-ID: <20161011094538.GO17252@6wind.com> (raw)
In-Reply-To: <1475072658-29534-1-git-send-email-ogournet@corp.free.fr>

Hi Olivier,

Secondary process support's got overlooked during this refactoring, thanks
for the patch. However can you describe the issue you're addressing as part
of the commit log?

I think problems started when txq got mistakenly converted to
primary_txq_ctrl in 21c8bb4928c9 ("net/mlx5: split Tx queue structure"), you
may add a Fixes line for that one as well.

Otherwise, this patch looks fine to me.

On Wed, Sep 28, 2016 at 04:24:18PM +0200, Olivier Gournet wrote:
> Fixes: 1d88ba171942 ("net/mlx5: refactor Tx data path")
> 
> Signed-off-by: Olivier Gournet <ogournet@corp.free.fr>
> ---
>  drivers/net/mlx5/mlx5_ethdev.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/mlx5/mlx5_ethdev.c b/drivers/net/mlx5/mlx5_ethdev.c
> index 130e15d..6f39965 100644
> --- a/drivers/net/mlx5/mlx5_ethdev.c
> +++ b/drivers/net/mlx5/mlx5_ethdev.c
> @@ -1308,11 +1308,13 @@ mlx5_secondary_data_setup(struct priv *priv)
>  			continue;
>  		primary_txq_ctrl = container_of(primary_txq,
>  						struct txq_ctrl, txq);
> -		txq_ctrl = rte_calloc_socket("TXQ", 1, sizeof(*txq_ctrl), 0,
> +		txq_ctrl = rte_calloc_socket("TXQ", 1, sizeof(*txq_ctrl) +
> +					     primary_txq->elts_n *
> +					     sizeof(struct rte_mbuf *), 0,
>  					     primary_txq_ctrl->socket);
>  		if (txq_ctrl != NULL) {
>  			if (txq_ctrl_setup(priv->dev,
> -					   primary_txq_ctrl,
> +					   txq_ctrl,
>  					   primary_txq->elts_n,
>  					   primary_txq_ctrl->socket,
>  					   NULL) == 0) {
> -- 
> 2.1.4

-- 
Adrien Mazarguil
6WIND

  parent reply	other threads:[~2016-10-11  9:45 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-28 14:24 Olivier Gournet
2016-10-10 13:32 ` Ferruh Yigit
2016-10-11  9:45 ` Adrien Mazarguil [this message]
2016-10-17 12:05   ` Ferruh Yigit
2016-10-17 12:56 ` [dpdk-dev] [PATCH v2] " Olivier Gournet
2016-10-17 13:52   ` Ferruh Yigit
2016-10-17 14:18     ` Adrien Mazarguil
2016-10-19  9:31       ` Bruce Richardson
2016-10-19 10:05         ` Adrien Mazarguil
2016-10-24 13:26       ` Bruce Richardson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161011094538.GO17252@6wind.com \
    --to=adrien.mazarguil@6wind.com \
    --cc=dev@dpdk.org \
    --cc=ogournet@corp.free.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).