From: Bruce Richardson <bruce.richardson@intel.com>
To: "Mcnamara, John" <john.mcnamara@intel.com>
Cc: John Daley <johndale@cisco.com>, "dev@dpdk.org" <dev@dpdk.org>,
Nelson Escobar <neescoba@cisco.com>
Subject: Re: [dpdk-dev] [PATCH] net/enic: update enic guide and add warning for invalid conf
Date: Wed, 12 Oct 2016 17:19:34 +0100 [thread overview]
Message-ID: <20161012161933.GH104428@bricha3-MOBL3> (raw)
In-Reply-To: <B27915DBBA3421428155699D51E4CFE20262A85C@IRSMSX103.ger.corp.intel.com>
On Mon, Oct 10, 2016 at 03:16:09PM +0100, Mcnamara, John wrote:
> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of John Daley
> > Sent: Thursday, September 29, 2016 9:55 PM
> > To: Richardson, Bruce <bruce.richardson@intel.com>
> > Cc: dev@dpdk.org; Nelson Escobar <neescoba@cisco.com>
> > Subject: [dpdk-dev] [PATCH] net/enic: update enic guide and add warning
> > for invalid conf
> >
> > From: Nelson Escobar <neescoba@cisco.com>
> >
> > Update the enic guide to better explain how to setup vNIC parameters on
> > the Cisco VIC since the introduction of rx scatter and print an error
> > message for the case of having 1 RQ configured in the vNIC.
> >
> > Signed-off-by: Nelson Escobar <neescoba@cisco.com>
>
> Hi,
>
> It would be better in the RST documentation to use ```` backticks to
> designate function and variable names as fixed width. Also, the documentation
> convention is to use Rx/Tx. However, these are minor so the patch is okay as
> it is.
>
> Acked-by: John McNamara <john.mcnamara@intel.com>
>
Applied to dpdk-next-net/rel_16_11 as "document how to configure vNIC parameters"
so as to make it clear that this is one logical change, rather than two - which
would be implied by the use of "and" in the title.
/Bruce
prev parent reply other threads:[~2016-10-12 16:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-29 20:55 John Daley
2016-10-10 14:16 ` Mcnamara, John
2016-10-12 16:19 ` Bruce Richardson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161012161933.GH104428@bricha3-MOBL3 \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=john.mcnamara@intel.com \
--cc=johndale@cisco.com \
--cc=neescoba@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).