From: John Daley <johndale@cisco.com>
To: bruce.richardson@intel.com
Cc: dev@dpdk.org, John Daley <johndale@cisco.com>
Subject: [dpdk-dev] [PATCH] net/enic: remove assert which causes compile error
Date: Wed, 12 Oct 2016 11:09:35 -0700 [thread overview]
Message-ID: <20161012180935.8366-1-johndale@cisco.com> (raw)
In-Reply-To: <20161012162442.GI104428@bricha3-MOBL3>
Remove an RTE_ASSERT which will not compile if enabled and is not needed.
Fixes: a1f7c7b3b5b2 ("net/enic: extend fdir support for 1300 series adapters")
Signed-off-by: John Daley <johndale@cisco.com>
---
Would have been nice if I caught this yesterday before you applied a1f7c7b3 :(
drivers/net/enic/enic_clsf.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/enic/enic_clsf.c b/drivers/net/enic/enic_clsf.c
index c709be9..d2413d7 100644
--- a/drivers/net/enic/enic_clsf.c
+++ b/drivers/net/enic/enic_clsf.c
@@ -142,8 +142,6 @@ copy_fltr_v2(struct filter_v2 *fltr, struct rte_eth_fdir_input *input,
struct filter_generic_1 *gp = &fltr->u.generic_1;
int i;
- RTE_ASSERT(enic->adv_filters);
-
fltr->type = FILTER_DPDK_1;
memset(gp, 0, sizeof(*gp));
--
2.10.0
next prev parent reply other threads:[~2016-10-12 18:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-29 20:56 [dpdk-dev] [PATCH 1/4] net/enic: fix fdir usage with scattered Rx John Daley
2016-09-29 20:56 ` [dpdk-dev] [PATCH 2/4] net/enic: fix segfault when restarting with fdir filters John Daley
2016-09-29 20:56 ` [dpdk-dev] [PATCH 3/4] net/enic: update VIC interface file John Daley
2016-09-29 20:56 ` [dpdk-dev] [PATCH 4/4] net/enic: extend fdir support for 1300 series adapters John Daley
2016-10-11 9:22 ` Ferruh Yigit
2016-10-11 9:25 ` John Daley (johndale)
2016-10-12 16:24 ` Bruce Richardson
2016-10-12 18:09 ` John Daley [this message]
2016-10-13 13:22 ` [dpdk-dev] [PATCH] net/enic: remove assert which causes compile error Bruce Richardson
2016-10-13 13:37 ` Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161012180935.8366-1-johndale@cisco.com \
--to=johndale@cisco.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).