From: Jerin Jacob <jerin.jacob@caviumnetworks.com>
To: "Eads, Gage" <gage.eads@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"thomas.monjalon@6wind.com" <thomas.monjalon@6wind.com>,
"Richardson, Bruce" <bruce.richardson@intel.com>,
"Vangati, Narender" <narender.vangati@intel.com>,
"hemant.agrawal@nxp.com" <hemant.agrawal@nxp.com>
Subject: Re: [dpdk-dev] [RFC] [PATCH v2] libeventdev: event driven programming model framework for DPDK
Date: Tue, 18 Oct 2016 16:49:26 +0530 [thread overview]
Message-ID: <20161018111925.GA4745@localhost.localdomain> (raw)
In-Reply-To: <9184057F7FC11744A2107296B6B8EB1E01E18A80@FMSMSX108.amr.corp.intel.com>
On Mon, Oct 17, 2016 at 08:26:33PM +0000, Eads, Gage wrote:
>
>
> > -----Original Message-----
> > From: Jerin Jacob [mailto:jerin.jacob@caviumnetworks.com]
> > Sent: Sunday, October 16, 2016 11:18 PM
> > To: Eads, Gage <gage.eads@intel.com>
> > Cc: dev@dpdk.org; thomas.monjalon@6wind.com; Richardson, Bruce
> > <bruce.richardson@intel.com>; Vangati, Narender
> > <narender.vangati@intel.com>; hemant.agrawal@nxp.com
> > Subject: Re: [dpdk-dev] [RFC] [PATCH v2] libeventdev: event driven
> > programming model framework for DPDK
> >
> > On Fri, Oct 14, 2016 at 03:00:57PM +0000, Eads, Gage wrote:
> > > Thanks Jerin, this looks good. I've put a few notes/questions inline.
> >
> > Thanks Gage.
> >
> > >
> > > > +
> > > > +/**
> > > > + * Get the device identifier for the named event device.
> > > > + *
> > > > + * @param name
> > > > + * Event device name to select the event device identifier.
> > > > + *
> > > > + * @return
> > > > + * Returns event device identifier on success.
> > > > + * - <0: Failure to find named event device.
> > > > + */
> > > > +extern uint8_t
> > > > +rte_event_dev_get_dev_id(const char *name);
> > >
> > > This return type should be int8_t, or some signed type, to support the failure
> > case.
> >
> > Makes sense. I will change to int to make consistent with
> > rte_cryptodev_get_dev_id()
> >
> > >
> > > > +};
> > > > +
> > > > +/**
> > > > + * Schedule one or more events in the event dev.
> > > > + *
> > > > + * An event dev implementation may define this is a NOOP, for
> > > > instance if + * the event dev performs its scheduling in hardware.
> > > > + *
> > > > + * @param dev_id
> > > > + * The identifier of the device.
> > > > + */
> > > > +extern void
> > > > +rte_event_schedule(uint8_t dev_id);
> > >
> > > One idea: Have the function return the number of scheduled packets (or 0 for
> > implementations that do scheduling in hardware). This could be a helpful
> > diagnostic for the software scheduler.
> >
> > How about returning an implementation specific value ?
> > Rather than defining certain function associated with returned value.
> > Just to make sure it works with all HW/SW implementations. Something like
> > below,
> >
> > /**
> > * Schedule one or more events in the event dev.
> > *
> > * An event dev implementation may define this is a NOOP, for instance if
> > * the event dev performs its scheduling in hardware.
> > *
> > * @param dev_id
> > * The identifier of the device.
> > * @return
> > * Implementation specific value from the event driver for diagnostic purpose
> > */
> > extern int
> > rte_event_schedule(uint8_t dev_id);
> >
> >
>
> That's fine by me.
OK. I will change it in v3
>
> I also had a comment on the return value of rte_event_dev_info_get() in my previous email: "I'm wondering if this return type should be int, so we can return an error if the dev_id is invalid."
>
> What do you think?
The void return was based on cryptodev_info_get().I think, it makes
sense to return "int". I will change it in v3.
>
> Thanks,
> Gage
>
> >
> >
next prev parent reply other threads:[~2016-10-18 11:19 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-04 21:49 [dpdk-dev] [RFC] " Vangati, Narender
2016-10-05 7:24 ` Jerin Jacob
2016-10-07 10:40 ` Hemant Agrawal
2016-10-09 8:27 ` Jerin Jacob
2016-10-11 19:30 ` [dpdk-dev] [RFC] [PATCH v2] " Jerin Jacob
2016-10-14 4:14 ` Bill Fischofer
2016-10-14 9:26 ` Jerin Jacob
2016-10-14 10:30 ` Hemant Agrawal
2016-10-14 12:52 ` Jerin Jacob
2016-10-14 15:00 ` Eads, Gage
2016-10-17 4:18 ` Jerin Jacob
2016-10-17 20:26 ` Eads, Gage
2016-10-18 11:19 ` Jerin Jacob [this message]
2016-10-14 16:02 ` Bruce Richardson
2016-10-17 5:10 ` Jerin Jacob
2016-10-25 17:49 ` Jerin Jacob
2016-10-26 12:11 ` Van Haaren, Harry
2016-10-26 12:24 ` Jerin Jacob
2016-10-26 12:54 ` Bruce Richardson
2016-10-28 3:01 ` Jerin Jacob
2016-10-28 8:36 ` Bruce Richardson
2016-10-28 9:06 ` Jerin Jacob
2016-11-02 11:25 ` Jerin Jacob
2016-11-02 11:35 ` Bruce Richardson
2016-11-02 13:09 ` Jerin Jacob
2016-11-02 13:56 ` Bruce Richardson
2016-11-02 14:54 ` Jerin Jacob
2016-10-26 18:37 ` Vincent Jardin
2016-10-28 13:10 ` Van Haaren, Harry
2016-11-02 10:47 ` Jerin Jacob
2016-11-02 11:45 ` Bruce Richardson
2016-11-02 12:34 ` Jerin Jacob
2016-10-26 12:43 ` Bruce Richardson
2016-10-26 17:30 ` Jerin Jacob
2016-10-28 13:48 ` Van Haaren, Harry
2016-10-28 14:16 ` Bruce Richardson
2016-11-02 8:59 ` Jerin Jacob
2016-11-02 8:06 ` Jerin Jacob
2016-11-02 11:48 ` Bruce Richardson
2016-11-02 12:57 ` Jerin Jacob
2016-10-14 15:00 Francois Ozog
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161018111925.GA4745@localhost.localdomain \
--to=jerin.jacob@caviumnetworks.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=gage.eads@intel.com \
--cc=hemant.agrawal@nxp.com \
--cc=narender.vangati@intel.com \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).