From: Bruce Richardson <bruce.richardson@intel.com>
To: Qiming Yang <qiming.yang@intel.com>
Cc: dev@dpdk.org, jingjing.wu@intel.com, helin.zhang@intel.com
Subject: Re: [dpdk-dev] [PATCH v2 1/2] net/i40e: fix link status change interrupt
Date: Tue, 25 Oct 2016 13:53:42 +0100 [thread overview]
Message-ID: <20161025125341.GA57276@bricha3-MOBL3.ger.corp.intel.com> (raw)
In-Reply-To: <1477369146-63317-1-git-send-email-qiming.yang@intel.com>
On Tue, Oct 25, 2016 at 12:19:05PM +0800, Qiming Yang wrote:
> Previously, link status interrupt in i40e is achieved by checking
> LINK_STAT_CHANGE_MASK in PFINT_ICR0 register which is provided only
> for diagnostic use. Instead, drivers need to get the link status
> change notification by using LSE (Link Status Event).
>
> This patch enables LSE and calls LSC callback when the event is
> received. This patch also removes the processing on
> LINK_STAT_CHANGE_MASK.
>
> Fixes: 4861cde46116 ("i40e: new poll mode driver")
>
> Signed-off-by: Qiming Yang <qiming.yang@intel.com>
> ---
Thanks for the V2. Unfortunately, this conflicts with some other changes
to the driver, making the patch not apply cleanly, and a manual apply I
tried did not compile successfully. Can you please do a V3 rebased on
top of dpdk-next-net/rel_16_11.
Thanks,
/Bruce
prev parent reply other threads:[~2016-10-25 12:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-25 4:19 Qiming Yang
2016-10-25 4:19 ` [dpdk-dev] [PATCH v2 2/2] net/i40e: fix VF bonded device link down Qiming Yang
2016-10-25 10:45 ` Wu, Jingjing
2016-10-28 4:18 ` [dpdk-dev] [PATCH v3 1/2] net/i40e: fix link status change interrupt Qiming Yang
2016-10-28 4:18 ` [dpdk-dev] [PATCH v3 2/2] net/i40e: fix VF bonded device link down Qiming Yang
2016-10-28 11:05 ` Ferruh Yigit
2016-11-04 9:10 ` [dpdk-dev] [PATCH v4 1/2] net/i40e: fix link status change interrupt Qiming Yang
2016-11-04 9:10 ` [dpdk-dev] [PATCH v4 2/2] net/i40e: fix VF bonded device link down Qiming Yang
2016-11-07 16:48 ` Thomas Monjalon
2016-10-25 10:43 ` [dpdk-dev] [PATCH v2 1/2] net/i40e: fix link status change interrupt Wu, Jingjing
2016-10-25 12:53 ` Bruce Richardson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161025125341.GA57276@bricha3-MOBL3.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=helin.zhang@intel.com \
--cc=jingjing.wu@intel.com \
--cc=qiming.yang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).