From: Bruce Richardson <bruce.richardson@intel.com>
To: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Cc: dev@dpdk.org, thomas.monjalon@6wind.com, hemant.agrawal@nxp.com,
gage.eads@intel.com, harry.van.haaren@intel.com
Subject: Re: [dpdk-dev] [PATCH v2 1/6] eventdev: introduce event driven programming model
Date: Thu, 8 Dec 2016 09:57:52 +0000 [thread overview]
Message-ID: <20161208095752.GB55440@bricha3-MOBL3.ger.corp.intel.com> (raw)
In-Reply-To: <20161208014800.GB22031@svelivela-lt.caveonetworks.com>
On Thu, Dec 08, 2016 at 07:18:01AM +0530, Jerin Jacob wrote:
> On Wed, Dec 07, 2016 at 11:12:51AM +0000, Bruce Richardson wrote:
> > On Tue, Dec 06, 2016 at 09:22:15AM +0530, Jerin Jacob wrote:
> > > In a polling model, lcores poll ethdev ports and associated
> > > rx queues directly to look for packet. In an event driven model,
> > > by contrast, lcores call the scheduler that selects packets for
> > > them based on programmer-specified criteria. Eventdev library
> > > adds support for event driven programming model, which offer
> > > applications automatic multicore scaling, dynamic load balancing,
> > > pipelining, packet ingress order maintenance and
> > > synchronization services to simplify application packet processing.
> > >
> > > By introducing event driven programming model, DPDK can support
> > > both polling and event driven programming models for packet processing,
> > > and applications are free to choose whatever model
> > > (or combination of the two) that best suits their needs.
> > >
> > > This patch adds the eventdev specification header file.
> > >
> > > Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> > > ---
> > > +
> > > +/**
> > > + * Link multiple source event queues supplied in *rte_event_queue_link*
> > > + * structure as *queue_id* to the destination event port designated by its
> > > + * *port_id* on the event device designated by its *dev_id*.
> > > + *
> > > + * The link establishment shall enable the event port *port_id* from
> > > + * receiving events from the specified event queue *queue_id*
> > > + *
> > > + * An event queue may link to one or more event ports.
> > > + * The number of links can be established from an event queue to event port is
> > > + * implementation defined.
> > > + *
> > > + * Event queue(s) to event port link establishment can be changed at runtime
> > > + * without re-configuring the device to support scaling and to reduce the
> > > + * latency of critical work by establishing the link with more event ports
> > > + * at runtime.
> > > + *
> > > + * @param dev_id
> > > + * The identifier of the device.
> > > + *
> > > + * @param port_id
> > > + * Event port identifier to select the destination port to link.
> > > + *
> > > + * @param link
> > > + * Points to an array of *nb_links* objects of type *rte_event_queue_link*
> > > + * structure which contain the event queue to event port link establishment
> > > + * attributes.
> > > + * NULL value is allowed, in which case this function links all the configured
> > > + * event queues *nb_event_queues* which previously supplied to
> > > + * rte_event_dev_configure() to the event port *port_id* with normal servicing
> > > + * priority(RTE_EVENT_DEV_PRIORITY_NORMAL).
> > > + *
> > > + * @param nb_links
> > > + * The number of links to establish
> > > + *
> > > + * @return
> > > + * The number of links actually established. The return value can be less than
> > > + * the value of the *nb_links* parameter when the implementation has the
> > > + * limitation on specific queue to port link establishment or if invalid
> > > + * parameters are specified in a *rte_event_queue_link*.
> > > + * If the return value is less than *nb_links*, the remaining links at the end
> > > + * of link[] are not established, and the caller has to take care of them.
> > > + * If return value is less than *nb_links* then implementation shall update the
> > > + * rte_errno accordingly, Possible rte_errno values are
> > > + * (-EDQUOT) Quota exceeded(Application tried to link the queue configured with
> > > + * RTE_EVENT_QUEUE_CFG_FLAG_SINGLE_LINK to more than one event ports)
> > > + * (-EINVAL) Invalid parameter
> > > + *
> > > + */
> > > +int
> > > +rte_event_port_link(uint8_t dev_id, uint8_t port_id,
> > > + const struct rte_event_queue_link link[],
> > > + uint16_t nb_links);
> > > +
> >
> > Hi again Jerin,
> >
> > another small suggestion here. I'm not a big fan of using small
> > structures to pass parameters into functions, especially when not all
> > fields are always going to be used. Rather than use the event queue link
> > structure, can we just pass in two array parameters here - the list of
> > QIDs, and the list of priorities. In cases where the eventdev
> > implementation does not support link prioritization, or where the app
> > does not want different priority mappings , then the second
> > array can be null [implying NORMAL priority for the don't care case].
> >
> > int
> > rte_event_port_link(uint8_t dev_id, uint8_t port_id,
> > const uint8_t queues[], const uint8_t priorities[],
> > uint16_t nb_queues);
> >
> > This just makes mapping an array of queues easier, as we can just pass
> > an array of ints directly in, and it especially makes it easier to
> > create a single link via:
> >
> > rte_event_port_link(dev_id, port_id, &queue_id, NULL, 1);
>
> The reason why I thought of creating "struct rte_event_queue_link",
> - Its easy to add new parameter in link attributes if required
Make the priority value be in a struct, perhaps. That would allow for
future expansion, while still making it easier for the case where people
just want the mappings without any prioritization.
> - Its _easy_ to implement PAUSE and RESUME in application
>
> PAUSE:
> nr_links = rte_event_port_links_get(,,link)
> rte_event_port_unlink_all
>
> RESUME:
> rte_event_port_link(,,link, nr_links);
Ok, I had missed that implication. Since that is probably an important
operation we might want to do, perhaps links_get API should be updated
too to keep parameter matching.
/Bruce
next prev parent reply other threads:[~2016-12-08 9:58 UTC|newest]
Thread overview: 109+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-18 5:44 [dpdk-dev] [PATCH 0/4] libeventdev API and northbound implementation Jerin Jacob
2016-11-18 5:44 ` [dpdk-dev] [PATCH 1/4] eventdev: introduce event driven programming model Jerin Jacob
2016-11-23 18:39 ` Thomas Monjalon
2016-11-24 1:59 ` Jerin Jacob
2016-11-24 12:26 ` Bruce Richardson
2016-11-24 15:35 ` Thomas Monjalon
2016-11-25 0:23 ` Jerin Jacob
2016-11-25 11:00 ` Bruce Richardson
2016-11-25 13:09 ` Thomas Monjalon
2016-11-26 0:57 ` Jerin Jacob
2016-11-28 9:10 ` Bruce Richardson
2016-11-26 2:54 ` Jerin Jacob
2016-11-28 9:16 ` Bruce Richardson
2016-11-28 11:30 ` Thomas Monjalon
2016-11-29 4:01 ` Jerin Jacob
2016-11-29 10:00 ` Bruce Richardson
2016-11-25 11:59 ` Van Haaren, Harry
2016-11-25 12:09 ` Richardson, Bruce
2016-11-24 16:24 ` Bruce Richardson
2016-11-24 19:30 ` Jerin Jacob
2016-12-06 3:52 ` [dpdk-dev] [PATCH v2 0/6] libeventdev API and northbound implementation Jerin Jacob
2016-12-06 3:52 ` [dpdk-dev] [PATCH v2 1/6] eventdev: introduce event driven programming model Jerin Jacob
2016-12-06 16:51 ` Bruce Richardson
2016-12-07 18:53 ` Jerin Jacob
2016-12-08 9:30 ` Bruce Richardson
2016-12-08 20:41 ` Jerin Jacob
2016-12-09 15:11 ` Bruce Richardson
2016-12-14 6:55 ` Jerin Jacob
2016-12-07 10:57 ` Van Haaren, Harry
2016-12-08 1:24 ` Jerin Jacob
2016-12-08 11:02 ` Van Haaren, Harry
2016-12-14 13:13 ` Jerin Jacob
2016-12-14 15:15 ` Bruce Richardson
2016-12-15 16:54 ` Van Haaren, Harry
2016-12-07 11:12 ` Bruce Richardson
2016-12-08 1:48 ` Jerin Jacob
2016-12-08 9:57 ` Bruce Richardson [this message]
2016-12-14 6:40 ` Jerin Jacob
2016-12-14 15:19 ` Bruce Richardson
2016-12-15 13:39 ` Jerin Jacob
2016-12-06 3:52 ` [dpdk-dev] [PATCH v2 2/6] eventdev: define southbound driver interface Jerin Jacob
2016-12-06 3:52 ` [dpdk-dev] [PATCH v2 3/6] eventdev: implement the northbound APIs Jerin Jacob
2016-12-06 17:17 ` Bruce Richardson
2016-12-07 17:02 ` Jerin Jacob
2016-12-08 9:59 ` Bruce Richardson
2016-12-14 6:28 ` Jerin Jacob
2016-12-06 3:52 ` [dpdk-dev] [PATCH v2 4/6] eventdev: implement PMD registration functions Jerin Jacob
2016-12-06 3:52 ` [dpdk-dev] [PATCH v2 5/6] event/skeleton: add skeleton eventdev driver Jerin Jacob
2016-12-06 3:52 ` [dpdk-dev] [PATCH v2 6/6] app/test: unit test case for eventdev APIs Jerin Jacob
2016-12-06 16:46 ` [dpdk-dev] [PATCH v2 0/6] libeventdev API and northbound implementation Bruce Richardson
2016-12-21 9:25 ` [dpdk-dev] [PATCH v4 " Jerin Jacob
2016-12-21 9:25 ` [dpdk-dev] [PATCH v4 1/6] eventdev: introduce event driven programming model Jerin Jacob
2017-01-25 16:32 ` Eads, Gage
2017-01-25 16:36 ` Richardson, Bruce
2017-01-25 16:53 ` Eads, Gage
2017-01-25 22:36 ` Eads, Gage
2017-01-26 9:39 ` Jerin Jacob
2017-01-26 20:39 ` Eads, Gage
2017-01-27 10:03 ` Bruce Richardson
2017-01-30 10:42 ` Jerin Jacob
2017-02-02 11:18 ` Nipun Gupta
2017-02-02 14:09 ` Jerin Jacob
2017-02-03 6:38 ` Nipun Gupta
2017-02-03 10:58 ` Hemant Agrawal
2017-02-07 4:59 ` Jerin Jacob
2016-12-21 9:25 ` [dpdk-dev] [PATCH v4 2/6] eventdev: define southbound driver interface Jerin Jacob
2017-02-02 11:19 ` Nipun Gupta
2017-02-02 11:34 ` Bruce Richardson
2017-02-02 12:53 ` Nipun Gupta
2017-02-02 13:58 ` Bruce Richardson
2017-02-03 5:59 ` Nipun Gupta
2016-12-21 9:25 ` [dpdk-dev] [PATCH v4 3/6] eventdev: implement the northbound APIs Jerin Jacob
2017-02-02 11:19 ` Nipun Gupta
2017-02-02 14:32 ` Jerin Jacob
2017-02-03 6:59 ` Nipun Gupta
2016-12-21 9:25 ` [dpdk-dev] [PATCH v4 4/6] eventdev: implement PMD registration functions Jerin Jacob
2017-02-02 11:20 ` Nipun Gupta
2017-02-05 13:04 ` Jerin Jacob
2016-12-21 9:25 ` [dpdk-dev] [PATCH v4 5/6] event/skeleton: add skeleton eventdev driver Jerin Jacob
2016-12-21 9:25 ` [dpdk-dev] [PATCH v4 6/6] app/test: unit test case for eventdev APIs Jerin Jacob
2016-11-18 5:45 ` [dpdk-dev] [PATCH 2/4] eventdev: implement the northbound APIs Jerin Jacob
2016-11-21 17:45 ` Eads, Gage
2016-11-21 19:13 ` Jerin Jacob
2016-11-21 19:31 ` Jerin Jacob
2016-11-22 15:15 ` Eads, Gage
2016-11-22 18:19 ` Jerin Jacob
2016-11-22 19:43 ` Eads, Gage
2016-11-22 20:00 ` Jerin Jacob
2016-11-22 22:48 ` Eads, Gage
2016-11-22 23:43 ` Jerin Jacob
2016-11-28 15:53 ` Eads, Gage
2016-11-29 2:01 ` Jerin Jacob
2016-11-29 3:43 ` Jerin Jacob
2016-11-29 5:46 ` Eads, Gage
2016-11-23 9:57 ` Bruce Richardson
2016-11-23 19:18 ` Thomas Monjalon
2016-11-25 4:17 ` Jerin Jacob
2016-11-25 9:55 ` Richardson, Bruce
2016-11-25 23:08 ` Jerin Jacob
2016-11-18 5:45 ` [dpdk-dev] [PATCH 3/4] event/skeleton: add skeleton eventdev driver Jerin Jacob
2016-11-18 5:45 ` [dpdk-dev] [PATCH 4/4] app/test: unit test case for eventdev APIs Jerin Jacob
2016-11-18 15:25 ` [dpdk-dev] [PATCH 0/4] libeventdev API and northbound implementation Bruce Richardson
2016-11-18 16:04 ` Bruce Richardson
2016-11-18 19:27 ` Jerin Jacob
2016-11-21 9:40 ` Thomas Monjalon
2016-11-21 9:57 ` Bruce Richardson
2016-11-22 0:11 ` Thomas Monjalon
2016-11-22 2:00 ` Yuanhan Liu
2016-11-22 9:05 ` Shreyansh Jain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161208095752.GB55440@bricha3-MOBL3.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=gage.eads@intel.com \
--cc=harry.van.haaren@intel.com \
--cc=hemant.agrawal@nxp.com \
--cc=jerin.jacob@caviumnetworks.com \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).