From: Tiwei Bie <tiwei.bie@intel.com>
To: "Xing, Beilei" <beilei.xing@intel.com>
Cc: "Wu, Jingjing" <jingjing.wu@intel.com>,
"Zhang, Helin" <helin.zhang@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2 15/17] net/i40e: add flow flush function
Date: Wed, 28 Dec 2016 15:00:36 +0800 [thread overview]
Message-ID: <20161228070035.GA85898@dpdk19> (raw)
In-Reply-To: <94479800C636CB44BD422CB454846E013158BF48@SHSMSX101.ccr.corp.intel.com>
On Wed, Dec 28, 2016 at 02:48:02PM +0800, Xing, Beilei wrote:
> > -----Original Message-----
> > From: Bie, Tiwei
> > Sent: Wednesday, December 28, 2016 1:36 PM
> > To: Xing, Beilei <beilei.xing@intel.com>
> > Cc: Wu, Jingjing <jingjing.wu@intel.com>; Zhang, Helin
> > <helin.zhang@intel.com>; dev@dpdk.org
> > Subject: Re: [dpdk-dev] [PATCH v2 15/17] net/i40e: add flow flush function
> >
> > On Tue, Dec 27, 2016 at 02:26:22PM +0800, Beilei Xing wrote:
> > > This patch adds i40e_flow_flush function to flush all filters for
> > > users. And flow director flush function is involved first.
> > >
> > > Signed-off-by: Beilei Xing <beilei.xing@intel.com>
> > > ---
> > > drivers/net/i40e/i40e_ethdev.h | 3 +++
> > > drivers/net/i40e/i40e_fdir.c | 8 ++------
> > > drivers/net/i40e/i40e_flow.c | 46
> > ++++++++++++++++++++++++++++++++++++++++++
> > > 3 files changed, 51 insertions(+), 6 deletions(-)
> > >
> > > diff --git a/drivers/net/i40e/i40e_ethdev.h
> > > b/drivers/net/i40e/i40e_ethdev.h index b8c7d41..0b736d5 100644
> > > --- a/drivers/net/i40e/i40e_ethdev.h
> > > +++ b/drivers/net/i40e/i40e_ethdev.h
> > > @@ -786,6 +786,9 @@ i40e_sw_tunnel_filter_lookup(struct
> > i40e_tunnel_rule *tunnel_rule,
> > > const struct i40e_tunnel_filter_input *input); int
> > > i40e_sw_tunnel_filter_del(struct i40e_pf *pf,
> > > struct i40e_tunnel_filter *tunnel_filter);
> > > +int i40e_sw_fdir_filter_del(struct i40e_pf *pf,
> > > + struct i40e_fdir_filter *filter); int
> > i40e_fdir_flush(struct
> > > +rte_eth_dev *dev);
> > >
> >
> > Why don't declare them as the global functions at the beginning?
>
> When I implement the store/restore function, I plan this function is only used in i40e_ethdev.c.
> I change them to the global functions since I add i40e_flow.c to rework all the flow ops.
>
These functions are also introduced in this patch set. There is no
particular reason to mark them as static at first and then turn them
into the global functions in the later patches. So it would be better
to declare them as the global ones when introducing them.
Best regards,
Tiwei Bie
next prev parent reply other threads:[~2016-12-28 7:06 UTC|newest]
Thread overview: 175+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-02 11:53 [dpdk-dev] [PATCH 00/24] net/i40e: Consistent filter API Beilei Xing
2016-12-02 11:53 ` [dpdk-dev] [PATCH 01/24] net/i40e: store ethertype filter Beilei Xing
2016-12-02 11:53 ` [dpdk-dev] [PATCH 02/24] net/i40e: store tunnel filter Beilei Xing
2016-12-02 11:53 ` [dpdk-dev] [PATCH 03/24] net/i40e: store flow director filter Beilei Xing
2016-12-02 11:53 ` [dpdk-dev] [PATCH 04/24] net/i40e: store RSS hash info Beilei Xing
2016-12-02 11:53 ` [dpdk-dev] [PATCH 05/24] net/i40e: restore ethertype filter Beilei Xing
2016-12-02 11:53 ` [dpdk-dev] [PATCH 06/24] net/i40e: restore macvlan filter Beilei Xing
2016-12-02 11:53 ` [dpdk-dev] [PATCH 07/24] net/i40e: restore tunnel filter Beilei Xing
2016-12-02 11:53 ` [dpdk-dev] [PATCH 08/24] net/i40e: restore flow director filter Beilei Xing
2016-12-02 11:53 ` [dpdk-dev] [PATCH 09/24] net/i40e: restore RSS hash info Beilei Xing
2016-12-02 11:53 ` [dpdk-dev] [PATCH 10/24] ethdev: parse ethertype filter Beilei Xing
2016-12-20 18:12 ` Ferruh Yigit
2016-12-21 3:54 ` Xing, Beilei
2016-12-23 8:43 ` Adrien Mazarguil
2016-12-27 6:36 ` Xing, Beilei
2016-12-02 11:53 ` [dpdk-dev] [PATCH 11/24] net/i40e: add flow validate function Beilei Xing
2016-12-02 11:53 ` [dpdk-dev] [PATCH 12/24] net/i40e: parse macvlan filter Beilei Xing
2016-12-02 11:53 ` [dpdk-dev] [PATCH 13/24] net/i40e: parse VXLAN filter Beilei Xing
2016-12-02 11:53 ` [dpdk-dev] [PATCH 14/24] net/i40e: parse NVGRE filter Beilei Xing
2016-12-02 11:53 ` [dpdk-dev] [PATCH 15/24] net/i40e: parse flow director filter Beilei Xing
2016-12-02 11:53 ` [dpdk-dev] [PATCH 16/24] net/i40e: add flow create function Beilei Xing
2016-12-02 11:53 ` [dpdk-dev] [PATCH 17/24] net/i40e: destroy ethertype filter Beilei Xing
2016-12-02 11:53 ` [dpdk-dev] [PATCH 18/24] net/i40e: destroy macvlan filter Beilei Xing
2016-12-02 11:53 ` [dpdk-dev] [PATCH 19/24] net/i40e: destroy tunnel filter Beilei Xing
2016-12-02 11:53 ` [dpdk-dev] [PATCH 20/24] net/i40e: destroy flow directory filter Beilei Xing
2016-12-02 11:53 ` [dpdk-dev] [PATCH 21/24] net/i40e: add flow flush function Beilei Xing
2016-12-02 11:53 ` [dpdk-dev] [PATCH 22/24] net/i40e: flush ethertype filters Beilei Xing
2016-12-02 11:53 ` [dpdk-dev] [PATCH 23/24] net/i40e: flush macvlan filters Beilei Xing
2016-12-02 11:53 ` [dpdk-dev] [PATCH 24/24] net/i40e: flush tunnel filters Beilei Xing
2016-12-27 6:26 ` [dpdk-dev] [PATCH v2 00/17] net/i40e: Consistent filter API Beilei Xing
2016-12-27 6:26 ` [dpdk-dev] [PATCH v2 01/17] net/i40e: store ethertype filter Beilei Xing
2016-12-28 2:22 ` Wu, Jingjing
2016-12-29 4:03 ` Xing, Beilei
2016-12-29 4:36 ` Xing, Beilei
2016-12-28 3:22 ` Tiwei Bie
2016-12-27 6:26 ` [dpdk-dev] [PATCH v2 02/17] net/i40e: store tunnel filter Beilei Xing
2016-12-28 3:27 ` Tiwei Bie
2016-12-27 6:26 ` [dpdk-dev] [PATCH v2 03/17] net/i40e: store flow director filter Beilei Xing
2016-12-28 3:38 ` Tiwei Bie
2016-12-28 7:10 ` Xing, Beilei
2016-12-28 7:14 ` Tiwei Bie
2016-12-28 7:36 ` Tiwei Bie
2016-12-27 6:26 ` [dpdk-dev] [PATCH v2 04/17] net/i40e: restore ethertype filter Beilei Xing
2016-12-28 2:25 ` Wu, Jingjing
2016-12-27 6:26 ` [dpdk-dev] [PATCH v2 05/17] net/i40e: restore tunnel filter Beilei Xing
2016-12-27 6:26 ` [dpdk-dev] [PATCH v2 06/17] net/i40e: restore flow director filter Beilei Xing
2016-12-27 6:26 ` [dpdk-dev] [PATCH v2 07/17] net/i40e: add flow validate function Beilei Xing
2016-12-27 12:40 ` Adrien Mazarguil
2016-12-28 9:00 ` Xing, Beilei
2016-12-28 9:29 ` Adrien Mazarguil
2016-12-28 10:03 ` Xing, Beilei
2016-12-28 2:52 ` Wu, Jingjing
2016-12-28 7:44 ` Xing, Beilei
2016-12-28 4:08 ` Tiwei Bie
2016-12-27 6:26 ` [dpdk-dev] [PATCH v2 08/17] net/i40e: parse flow director filter Beilei Xing
2016-12-27 6:26 ` [dpdk-dev] [PATCH v2 09/17] net/i40e: parse tunnel filter Beilei Xing
2016-12-27 6:26 ` [dpdk-dev] [PATCH v2 10/17] net/i40e: add flow create function Beilei Xing
2016-12-27 6:26 ` [dpdk-dev] [PATCH v2 11/17] net/i40e: add flow destroy function Beilei Xing
2016-12-27 6:26 ` [dpdk-dev] [PATCH v2 12/17] net/i40e: destroy ethertype filter Beilei Xing
2016-12-28 3:30 ` Wu, Jingjing
2016-12-28 7:29 ` Xing, Beilei
2016-12-28 4:56 ` Tiwei Bie
2016-12-28 6:57 ` Xing, Beilei
2016-12-27 6:26 ` [dpdk-dev] [PATCH v2 13/17] net/i40e: destroy tunnel filter Beilei Xing
2016-12-27 6:26 ` [dpdk-dev] [PATCH v2 14/17] net/i40e: destroy flow directory filter Beilei Xing
2016-12-27 6:26 ` [dpdk-dev] [PATCH v2 15/17] net/i40e: add flow flush function Beilei Xing
2016-12-27 12:40 ` Adrien Mazarguil
2016-12-28 8:02 ` Xing, Beilei
2016-12-28 5:35 ` Tiwei Bie
2016-12-28 6:48 ` Xing, Beilei
2016-12-28 7:00 ` Tiwei Bie [this message]
2016-12-28 7:20 ` Xing, Beilei
2016-12-27 6:26 ` [dpdk-dev] [PATCH v2 16/17] net/i40e: flush ethertype filters Beilei Xing
2016-12-27 6:26 ` [dpdk-dev] [PATCH v2 17/17] net/i40e: flush tunnel filters Beilei Xing
2016-12-29 16:04 ` [dpdk-dev] [PATCH v3 00/17] net/i40e: consistent filter API Beilei Xing
2016-12-29 16:04 ` [dpdk-dev] [PATCH v3 01/17] net/i40e: store ethertype filter Beilei Xing
2016-12-29 16:04 ` [dpdk-dev] [PATCH v3 02/17] net/i40e: store tunnel filter Beilei Xing
2016-12-29 16:04 ` [dpdk-dev] [PATCH v3 03/17] net/i40e: store flow director filter Beilei Xing
2016-12-29 16:04 ` [dpdk-dev] [PATCH v3 04/17] net/i40e: restore ethertype filter Beilei Xing
2016-12-29 16:04 ` [dpdk-dev] [PATCH v3 05/17] net/i40e: restore tunnel filter Beilei Xing
2016-12-29 16:04 ` [dpdk-dev] [PATCH v3 06/17] net/i40e: restore flow director filter Beilei Xing
2016-12-29 16:04 ` [dpdk-dev] [PATCH v3 07/17] net/i40e: add flow validate function Beilei Xing
2016-12-29 16:04 ` [dpdk-dev] [PATCH v3 08/17] net/i40e: parse flow director filter Beilei Xing
2016-12-29 16:04 ` [dpdk-dev] [PATCH v3 09/17] net/i40e: parse tunnel filter Beilei Xing
2016-12-29 16:04 ` [dpdk-dev] [PATCH v3 10/17] net/i40e: add flow create function Beilei Xing
2016-12-29 16:04 ` [dpdk-dev] [PATCH v3 11/17] net/i40e: add flow destroy function Beilei Xing
2016-12-29 16:04 ` [dpdk-dev] [PATCH v3 12/17] net/i40e: destroy ethertype filter Beilei Xing
2016-12-29 16:04 ` [dpdk-dev] [PATCH v3 13/17] net/i40e: destroy tunnel filter Beilei Xing
2016-12-29 16:04 ` [dpdk-dev] [PATCH v3 14/17] net/i40e: destroy flow directory filter Beilei Xing
2016-12-29 16:04 ` [dpdk-dev] [PATCH v3 15/17] net/i40e: add flow flush function Beilei Xing
2016-12-29 16:04 ` [dpdk-dev] [PATCH v3 16/17] net/i40e: flush ethertype filters Beilei Xing
2016-12-29 16:04 ` [dpdk-dev] [PATCH v3 17/17] net/i40e: flush tunnel filters Beilei Xing
2016-12-30 3:25 ` [dpdk-dev] [PATCH v4 00/17] net/i40e: consistent filter API Beilei Xing
2016-12-30 3:25 ` [dpdk-dev] [PATCH v4 01/17] net/i40e: store ethertype filter Beilei Xing
2016-12-30 3:25 ` [dpdk-dev] [PATCH v4 02/17] net/i40e: store tunnel filter Beilei Xing
2016-12-30 3:25 ` [dpdk-dev] [PATCH v4 03/17] net/i40e: store flow director filter Beilei Xing
2016-12-30 3:25 ` [dpdk-dev] [PATCH v4 04/17] net/i40e: restore ethertype filter Beilei Xing
2016-12-30 3:25 ` [dpdk-dev] [PATCH v4 05/17] net/i40e: restore tunnel filter Beilei Xing
2016-12-30 3:25 ` [dpdk-dev] [PATCH v4 06/17] net/i40e: restore flow director filter Beilei Xing
2016-12-30 3:25 ` [dpdk-dev] [PATCH v4 07/17] net/i40e: add flow validate function Beilei Xing
2016-12-30 3:25 ` [dpdk-dev] [PATCH v4 08/17] net/i40e: parse flow director filter Beilei Xing
2016-12-30 3:25 ` [dpdk-dev] [PATCH v4 09/17] net/i40e: parse tunnel filter Beilei Xing
2016-12-30 3:25 ` [dpdk-dev] [PATCH v4 10/17] net/i40e: add flow create function Beilei Xing
2016-12-30 3:25 ` [dpdk-dev] [PATCH v4 11/17] net/i40e: add flow destroy function Beilei Xing
2016-12-30 3:25 ` [dpdk-dev] [PATCH v4 12/17] net/i40e: destroy ethertype filter Beilei Xing
2016-12-30 3:25 ` [dpdk-dev] [PATCH v4 13/17] net/i40e: destroy tunnel filter Beilei Xing
2016-12-30 3:25 ` [dpdk-dev] [PATCH v4 14/17] net/i40e: destroy flow directory filter Beilei Xing
2016-12-30 3:25 ` [dpdk-dev] [PATCH v4 15/17] net/i40e: add flow flush function Beilei Xing
2016-12-30 3:25 ` [dpdk-dev] [PATCH v4 16/17] net/i40e: flush ethertype filters Beilei Xing
2016-12-30 3:25 ` [dpdk-dev] [PATCH v4 17/17] net/i40e: flush tunnel filters Beilei Xing
2017-01-03 3:25 ` Guo, Jia
2017-01-03 4:49 ` Xing, Beilei
2017-01-04 3:22 ` [dpdk-dev] [PATCH v5 00/17] net/i40e: consistent filter API Beilei Xing
2017-01-04 3:22 ` [dpdk-dev] [PATCH v5 01/17] net/i40e: store ethertype filter Beilei Xing
2017-01-04 3:22 ` [dpdk-dev] [PATCH v5 02/17] net/i40e: store tunnel filter Beilei Xing
2017-01-04 3:22 ` [dpdk-dev] [PATCH v5 03/17] net/i40e: store flow director filter Beilei Xing
2017-01-04 3:22 ` [dpdk-dev] [PATCH v5 04/17] net/i40e: restore ethertype filter Beilei Xing
2017-01-04 3:22 ` [dpdk-dev] [PATCH v5 05/17] net/i40e: restore tunnel filter Beilei Xing
2017-01-04 3:22 ` [dpdk-dev] [PATCH v5 06/17] net/i40e: restore flow director filter Beilei Xing
2017-01-04 3:22 ` [dpdk-dev] [PATCH v5 07/17] net/i40e: add flow validate function Beilei Xing
2017-01-04 18:57 ` Ferruh Yigit
2017-01-05 6:08 ` Xing, Beilei
2017-01-05 11:16 ` Ferruh Yigit
2017-01-05 11:52 ` Xing, Beilei
2017-01-04 3:22 ` [dpdk-dev] [PATCH v5 08/17] net/i40e: parse flow director filter Beilei Xing
2017-01-04 3:22 ` [dpdk-dev] [PATCH v5 09/17] net/i40e: parse tunnel filter Beilei Xing
2017-01-04 3:23 ` [dpdk-dev] [PATCH v5 10/17] net/i40e: add flow create function Beilei Xing
2017-01-04 3:23 ` [dpdk-dev] [PATCH v5 11/17] net/i40e: add flow destroy function Beilei Xing
2017-01-04 3:23 ` [dpdk-dev] [PATCH v5 12/17] net/i40e: destroy ethertype filter Beilei Xing
2017-01-04 3:23 ` [dpdk-dev] [PATCH v5 13/17] net/i40e: destroy tunnel filter Beilei Xing
2017-01-04 3:23 ` [dpdk-dev] [PATCH v5 14/17] net/i40e: destroy flow directory filter Beilei Xing
2017-01-04 3:23 ` [dpdk-dev] [PATCH v5 15/17] net/i40e: add flow flush function Beilei Xing
2017-01-04 3:23 ` [dpdk-dev] [PATCH v5 16/17] net/i40e: flush ethertype filters Beilei Xing
2017-01-04 3:23 ` [dpdk-dev] [PATCH v5 17/17] net/i40e: flush tunnel filters Beilei Xing
2017-01-04 6:40 ` [dpdk-dev] [PATCH v5 00/17] net/i40e: consistent filter API Wu, Jingjing
2017-01-05 15:45 ` [dpdk-dev] [PATCH v6 " Beilei Xing
2017-01-05 15:45 ` [dpdk-dev] [PATCH v6 01/17] net/i40e: store ethertype filter Beilei Xing
2017-01-05 17:46 ` Ferruh Yigit
2017-01-05 15:45 ` [dpdk-dev] [PATCH v6 02/17] net/i40e: store tunnel filter Beilei Xing
2017-01-05 15:45 ` [dpdk-dev] [PATCH v6 03/17] net/i40e: store flow director filter Beilei Xing
2017-01-05 15:45 ` [dpdk-dev] [PATCH v6 04/17] net/i40e: restore ethertype filter Beilei Xing
2017-01-05 15:45 ` [dpdk-dev] [PATCH v6 05/17] net/i40e: restore tunnel filter Beilei Xing
2017-01-05 15:45 ` [dpdk-dev] [PATCH v6 06/17] net/i40e: restore flow director filter Beilei Xing
2017-01-05 15:46 ` [dpdk-dev] [PATCH v6 07/17] net/i40e: add flow validate function Beilei Xing
2017-01-05 15:46 ` [dpdk-dev] [PATCH v6 08/17] net/i40e: parse flow director filter Beilei Xing
2017-01-05 15:46 ` [dpdk-dev] [PATCH v6 09/17] net/i40e: parse tunnel filter Beilei Xing
2017-01-05 15:46 ` [dpdk-dev] [PATCH v6 10/17] net/i40e: add flow create function Beilei Xing
2017-01-05 17:47 ` Ferruh Yigit
2017-01-05 15:46 ` [dpdk-dev] [PATCH v6 11/17] net/i40e: add flow destroy function Beilei Xing
2017-01-05 15:46 ` [dpdk-dev] [PATCH v6 12/17] net/i40e: destroy ethertype filter Beilei Xing
2017-01-05 15:46 ` [dpdk-dev] [PATCH v6 13/17] net/i40e: destroy tunnel filter Beilei Xing
2017-01-05 15:46 ` [dpdk-dev] [PATCH v6 14/17] net/i40e: destroy flow directory filter Beilei Xing
2017-01-05 15:46 ` [dpdk-dev] [PATCH v6 15/17] net/i40e: add flow flush function Beilei Xing
2017-01-05 15:46 ` [dpdk-dev] [PATCH v6 16/17] net/i40e: flush ethertype filters Beilei Xing
2017-01-05 15:46 ` [dpdk-dev] [PATCH v6 17/17] net/i40e: flush tunnel filters Beilei Xing
2017-01-05 17:46 ` [dpdk-dev] [PATCH v6 00/17] net/i40e: consistent filter API Ferruh Yigit
2017-01-06 5:27 ` [dpdk-dev] [PATCH v7 " Beilei Xing
2017-01-06 5:27 ` [dpdk-dev] [PATCH v7 01/17] net/i40e: store ethertype filter Beilei Xing
2017-01-06 5:27 ` [dpdk-dev] [PATCH v7 02/17] net/i40e: store tunnel filter Beilei Xing
2017-01-06 5:27 ` [dpdk-dev] [PATCH v7 03/17] net/i40e: store flow director filter Beilei Xing
2017-01-06 5:27 ` [dpdk-dev] [PATCH v7 04/17] net/i40e: restore ethertype filter Beilei Xing
2017-01-06 5:27 ` [dpdk-dev] [PATCH v7 05/17] net/i40e: restore tunnel filter Beilei Xing
2017-01-06 5:27 ` [dpdk-dev] [PATCH v7 06/17] net/i40e: restore flow director filter Beilei Xing
2017-01-06 5:27 ` [dpdk-dev] [PATCH v7 07/17] net/i40e: add flow validate function Beilei Xing
2017-01-06 5:27 ` [dpdk-dev] [PATCH v7 08/17] net/i40e: parse flow director filter Beilei Xing
2017-01-06 5:27 ` [dpdk-dev] [PATCH v7 09/17] net/i40e: parse tunnel filter Beilei Xing
2017-01-06 5:27 ` [dpdk-dev] [PATCH v7 10/17] net/i40e: add flow create function Beilei Xing
2017-01-06 5:27 ` [dpdk-dev] [PATCH v7 11/17] net/i40e: add flow destroy function Beilei Xing
2017-01-06 5:27 ` [dpdk-dev] [PATCH v7 12/17] net/i40e: destroy ethertype filter Beilei Xing
2017-01-06 5:27 ` [dpdk-dev] [PATCH v7 13/17] net/i40e: destroy tunnel filter Beilei Xing
2017-01-06 5:27 ` [dpdk-dev] [PATCH v7 14/17] net/i40e: destroy flow directory filter Beilei Xing
2017-01-06 5:27 ` [dpdk-dev] [PATCH v7 15/17] net/i40e: add flow flush function Beilei Xing
2017-01-06 5:27 ` [dpdk-dev] [PATCH v7 16/17] net/i40e: flush ethertype filters Beilei Xing
2017-01-06 5:27 ` [dpdk-dev] [PATCH v7 17/17] net/i40e: flush tunnel filters Beilei Xing
2017-01-06 11:54 ` [dpdk-dev] [PATCH v7 00/17] net/i40e: consistent filter API Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161228070035.GA85898@dpdk19 \
--to=tiwei.bie@intel.com \
--cc=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=helin.zhang@intel.com \
--cc=jingjing.wu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).