DPDK patches and discussions
 help / color / mirror / Atom feed
From: Adrien Mazarguil <adrien.mazarguil@6wind.com>
To: "Xing, Beilei" <beilei.xing@intel.com>
Cc: "Wu, Jingjing" <jingjing.wu@intel.com>,
	"Zhang, Helin" <helin.zhang@intel.com>,
	"dev@dpdk.org" <dev@dpdk.org>,
	"Lu, Wenzhuo" <wenzhuo.lu@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2 07/17] net/i40e: add flow validate function
Date: Wed, 28 Dec 2016 10:29:45 +0100	[thread overview]
Message-ID: <20161228092945.GF3737@6wind.com> (raw)
In-Reply-To: <94479800C636CB44BD422CB454846E013158C17B@SHSMSX101.ccr.corp.intel.com>

Hi Beilei,

On Wed, Dec 28, 2016 at 09:00:03AM +0000, Xing, Beilei wrote:
> 
> 
> > -----Original Message-----
> > From: Adrien Mazarguil [mailto:adrien.mazarguil@6wind.com]
> > Sent: Tuesday, December 27, 2016 8:40 PM
> > To: Xing, Beilei <beilei.xing@intel.com>
> > Cc: Wu, Jingjing <jingjing.wu@intel.com>; Zhang, Helin
> > <helin.zhang@intel.com>; dev@dpdk.org
> > Subject: Re: [dpdk-dev] [PATCH v2 07/17] net/i40e: add flow validate
> > function
> > 
> > Hi Beilei,
> > 
> > A few comments below.
> > 
> > On Tue, Dec 27, 2016 at 02:26:14PM +0800, Beilei Xing wrote:
> > > This patch adds i40e_flow_validation function to check if a flow is
> > > valid according to the flow pattern.
> > > i40e_parse_ethertype_filter is added first, it also gets the ethertype
> > > info.
> > > i40e_flow.c is added to handle all generic filter events.
> > >
> > > Signed-off-by: Beilei Xing <beilei.xing@intel.com>
> > > ---
> > >  drivers/net/i40e/Makefile      |   1 +
> > >  drivers/net/i40e/i40e_ethdev.c |   5 +
> > >  drivers/net/i40e/i40e_ethdev.h |  20 ++
> > >  drivers/net/i40e/i40e_flow.c   | 431
> > +++++++++++++++++++++++++++++++++++++++++
> > >  4 files changed, 457 insertions(+)
> > >  create mode 100644 drivers/net/i40e/i40e_flow.c
> > [...]
> > > diff --git a/drivers/net/i40e/i40e_flow.c
> > > b/drivers/net/i40e/i40e_flow.c new file mode 100644 index
> > > 0000000..bf451ef
> > > --- /dev/null
> > > +++ b/drivers/net/i40e/i40e_flow.c
> > [...]
> > > +	if (ethertype_filter->queue >= pf->dev_data->nb_rx_queues) {
> > > +		rte_flow_error_set(error, EINVAL,
> > > +				   RTE_FLOW_ERROR_TYPE_ACTION,
> > > +				   NULL, "Invalid queue ID for"
> > > +				   " ethertype_filter.");
> > 
> > When setting an error type related to an existing object provided by the
> > application, you should set the related cause pointer to a non-NULL value. In
> > this particular case, retrieving the action object seems difficult so it can
> > remain that way, however there are many places in this series where it can
> > be done.
> 
> OK, I got the meaning  and usage of cause pointer now. Thanks for the explaination.
> 
> > 
> > > +		return -EINVAL;
> > 
> > While this is perfectly valid, you could also return -rte_errno to avoid
> > duplicating EINVAL.
> 
> Yes, agree.
> 
> > 
> > [...]
> > > +	}
> > > +	if (ethertype_filter->ether_type == ETHER_TYPE_IPv4 ||
> > > +	    ethertype_filter->ether_type == ETHER_TYPE_IPv6) {
> > > +		rte_flow_error_set(error, ENOTSUP,
> > > +				   RTE_FLOW_ERROR_TYPE_ITEM,
> > > +				   NULL, "Unsupported ether_type in"
> > > +				   " control packet filter.");
> > > +		return -ENOTSUP;
> > > +	}
> > > +	if (ethertype_filter->ether_type == ETHER_TYPE_VLAN)
> > > +		PMD_DRV_LOG(WARNING, "filter vlan ether_type in"
> > > +			    " first tag is not supported.");
> > > +
> > > +	return ret;
> > > +}
> > [...]
> > > +/* Parse attributes */
> > > +static int
> > > +i40e_parse_attr(const struct rte_flow_attr *attr,
> > > +		struct rte_flow_error *error)
> > > +{
> > > +	/* Must be input direction */
> > > +	if (!attr->ingress) {
> > > +		rte_flow_error_set(error, EINVAL,
> > > +				   RTE_FLOW_ERROR_TYPE_ATTR_INGRESS,
> > > +				   NULL, "Only support ingress.");
> > 
> > Regarding my previous comment, &attr could replace NULL here as well as in
> > subsequent calls to rte_flow_error_set().
> 
> Got it, thanks.
> 
> > 
> > > +		return -EINVAL;
> > > +	}
> > > +
> > > +	/* Not supported */
> > > +	if (attr->egress) {
> > > +		rte_flow_error_set(error, EINVAL,
> > > +				   RTE_FLOW_ERROR_TYPE_ATTR_EGRESS,
> > > +				   NULL, "Not support egress.");
> > > +		return -EINVAL;
> > > +	}
> > > +
> > > +	/* Not supported */
> > > +	if (attr->priority) {
> > > +		rte_flow_error_set(error, EINVAL,
> > > +				   RTE_FLOW_ERROR_TYPE_ATTR_PRIORITY,
> > > +				   NULL, "Not support priority.");
> > > +		return -EINVAL;
> > > +	}
> > > +
> > > +	/* Not supported */
> > > +	if (attr->group) {
> > > +		rte_flow_error_set(error, EINVAL,
> > > +				   RTE_FLOW_ERROR_TYPE_ATTR_GROUP,
> > > +				   NULL, "Not support group.");
> > > +		return -EINVAL;
> > > +	}
> > > +
> > > +	return 0;
> > > +}
> > > +
> > > +static int
> > > +i40e_parse_ethertype_pattern(const struct rte_flow_item *pattern,
> > > +			     struct rte_flow_error *error,
> > > +			     struct rte_eth_ethertype_filter *filter) {
> > > +	const struct rte_flow_item *item = pattern;
> > > +	const struct rte_flow_item_eth *eth_spec;
> > > +	const struct rte_flow_item_eth *eth_mask;
> > > +	enum rte_flow_item_type item_type;
> > > +
> > > +	for (; item->type != RTE_FLOW_ITEM_TYPE_END; item++) {
> > > +		item_type = item->type;
> > > +		switch (item_type) {
> > > +		case RTE_FLOW_ITEM_TYPE_ETH:
> > > +			eth_spec = (const struct rte_flow_item_eth *)item-
> > >spec;
> > > +			eth_mask = (const struct rte_flow_item_eth *)item-
> > >mask;
> > > +			/* Get the MAC info. */
> > > +			if (!eth_spec || !eth_mask) {
> > > +				rte_flow_error_set(error, EINVAL,
> > > +
> > RTE_FLOW_ERROR_TYPE_ITEM,
> > > +						   NULL,
> > > +						   "NULL ETH spec/mask");
> > > +				return -EINVAL;
> > > +			}
> > 
> > While optional, I think you should allow eth_spec and eth_mask to be NULL
> > here as described in [1]:
> > 
> > - If eth_spec is NULL, you can match anything that looks like a valid
> >   Ethernet header.
> > 
> > - If eth_mask is NULL, you should assume a default mask (for Ethernet it
> >   usually means matching source/destination MACs perfectly).
> > 
> > - You must check the "last" field as well, if non-NULL it may probably be
> >   supported as long as the following condition is satisfied:
> > 
> >    (spec & mask) == (last & mask)
> > 
> > [1] http://dpdk.org/doc/guides/prog_guide/rte_flow.html#pattern-item
> > 
> 
> Thanks for the specification. In fact, we don't support the "last" for both ixgbe and i40e currently according to the original design, so we only support perfect match till now. We will support it in the future, as the deadline is coming, what do you think?

If you want to handle it later it's fine, however in that case you need to
at least generate an error when last is non-NULL (I did not see such a check
in this code).

Note that supporting it properly as defined in the API could be relatively
easy by implementing the above condition, it's just a small step above
simply checking for a NULL value.

> > [...]
> > > +	const struct rte_flow_action_queue *act_q;
> > > +	uint32_t index = 0;
> > > +
> > > +	/* Check if the first non-void action is QUEUE or DROP. */
> > > +	NEXT_ITEM_OF_ACTION(act, actions, index);
> > > +	if (act->type != RTE_FLOW_ACTION_TYPE_QUEUE &&
> > > +	    act->type != RTE_FLOW_ACTION_TYPE_DROP) {
> > > +		rte_flow_error_set(error, EINVAL,
> > RTE_FLOW_ERROR_TYPE_ACTION,
> > > +				   NULL, "Not supported action.");
> > 
> > Again, you could report &act instead of NULL here (please check all remaining
> > calls to rte_flow_error_set()).
> > 
> > [...]
> > 
> > --
> > Adrien Mazarguil
> > 6WIND

-- 
Adrien Mazarguil
6WIND

  reply	other threads:[~2016-12-28  9:29 UTC|newest]

Thread overview: 175+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-02 11:53 [dpdk-dev] [PATCH 00/24] net/i40e: Consistent filter API Beilei Xing
2016-12-02 11:53 ` [dpdk-dev] [PATCH 01/24] net/i40e: store ethertype filter Beilei Xing
2016-12-02 11:53 ` [dpdk-dev] [PATCH 02/24] net/i40e: store tunnel filter Beilei Xing
2016-12-02 11:53 ` [dpdk-dev] [PATCH 03/24] net/i40e: store flow director filter Beilei Xing
2016-12-02 11:53 ` [dpdk-dev] [PATCH 04/24] net/i40e: store RSS hash info Beilei Xing
2016-12-02 11:53 ` [dpdk-dev] [PATCH 05/24] net/i40e: restore ethertype filter Beilei Xing
2016-12-02 11:53 ` [dpdk-dev] [PATCH 06/24] net/i40e: restore macvlan filter Beilei Xing
2016-12-02 11:53 ` [dpdk-dev] [PATCH 07/24] net/i40e: restore tunnel filter Beilei Xing
2016-12-02 11:53 ` [dpdk-dev] [PATCH 08/24] net/i40e: restore flow director filter Beilei Xing
2016-12-02 11:53 ` [dpdk-dev] [PATCH 09/24] net/i40e: restore RSS hash info Beilei Xing
2016-12-02 11:53 ` [dpdk-dev] [PATCH 10/24] ethdev: parse ethertype filter Beilei Xing
2016-12-20 18:12   ` Ferruh Yigit
2016-12-21  3:54     ` Xing, Beilei
2016-12-23  8:43       ` Adrien Mazarguil
2016-12-27  6:36         ` Xing, Beilei
2016-12-02 11:53 ` [dpdk-dev] [PATCH 11/24] net/i40e: add flow validate function Beilei Xing
2016-12-02 11:53 ` [dpdk-dev] [PATCH 12/24] net/i40e: parse macvlan filter Beilei Xing
2016-12-02 11:53 ` [dpdk-dev] [PATCH 13/24] net/i40e: parse VXLAN filter Beilei Xing
2016-12-02 11:53 ` [dpdk-dev] [PATCH 14/24] net/i40e: parse NVGRE filter Beilei Xing
2016-12-02 11:53 ` [dpdk-dev] [PATCH 15/24] net/i40e: parse flow director filter Beilei Xing
2016-12-02 11:53 ` [dpdk-dev] [PATCH 16/24] net/i40e: add flow create function Beilei Xing
2016-12-02 11:53 ` [dpdk-dev] [PATCH 17/24] net/i40e: destroy ethertype filter Beilei Xing
2016-12-02 11:53 ` [dpdk-dev] [PATCH 18/24] net/i40e: destroy macvlan filter Beilei Xing
2016-12-02 11:53 ` [dpdk-dev] [PATCH 19/24] net/i40e: destroy tunnel filter Beilei Xing
2016-12-02 11:53 ` [dpdk-dev] [PATCH 20/24] net/i40e: destroy flow directory filter Beilei Xing
2016-12-02 11:53 ` [dpdk-dev] [PATCH 21/24] net/i40e: add flow flush function Beilei Xing
2016-12-02 11:53 ` [dpdk-dev] [PATCH 22/24] net/i40e: flush ethertype filters Beilei Xing
2016-12-02 11:53 ` [dpdk-dev] [PATCH 23/24] net/i40e: flush macvlan filters Beilei Xing
2016-12-02 11:53 ` [dpdk-dev] [PATCH 24/24] net/i40e: flush tunnel filters Beilei Xing
2016-12-27  6:26 ` [dpdk-dev] [PATCH v2 00/17] net/i40e: Consistent filter API Beilei Xing
2016-12-27  6:26   ` [dpdk-dev] [PATCH v2 01/17] net/i40e: store ethertype filter Beilei Xing
2016-12-28  2:22     ` Wu, Jingjing
2016-12-29  4:03       ` Xing, Beilei
2016-12-29  4:36       ` Xing, Beilei
2016-12-28  3:22     ` Tiwei Bie
2016-12-27  6:26   ` [dpdk-dev] [PATCH v2 02/17] net/i40e: store tunnel filter Beilei Xing
2016-12-28  3:27     ` Tiwei Bie
2016-12-27  6:26   ` [dpdk-dev] [PATCH v2 03/17] net/i40e: store flow director filter Beilei Xing
2016-12-28  3:38     ` Tiwei Bie
2016-12-28  7:10       ` Xing, Beilei
2016-12-28  7:14         ` Tiwei Bie
2016-12-28  7:36           ` Tiwei Bie
2016-12-27  6:26   ` [dpdk-dev] [PATCH v2 04/17] net/i40e: restore ethertype filter Beilei Xing
2016-12-28  2:25     ` Wu, Jingjing
2016-12-27  6:26   ` [dpdk-dev] [PATCH v2 05/17] net/i40e: restore tunnel filter Beilei Xing
2016-12-27  6:26   ` [dpdk-dev] [PATCH v2 06/17] net/i40e: restore flow director filter Beilei Xing
2016-12-27  6:26   ` [dpdk-dev] [PATCH v2 07/17] net/i40e: add flow validate function Beilei Xing
2016-12-27 12:40     ` Adrien Mazarguil
2016-12-28  9:00       ` Xing, Beilei
2016-12-28  9:29         ` Adrien Mazarguil [this message]
2016-12-28 10:03           ` Xing, Beilei
2016-12-28  2:52     ` Wu, Jingjing
2016-12-28  7:44       ` Xing, Beilei
2016-12-28  4:08     ` Tiwei Bie
2016-12-27  6:26   ` [dpdk-dev] [PATCH v2 08/17] net/i40e: parse flow director filter Beilei Xing
2016-12-27  6:26   ` [dpdk-dev] [PATCH v2 09/17] net/i40e: parse tunnel filter Beilei Xing
2016-12-27  6:26   ` [dpdk-dev] [PATCH v2 10/17] net/i40e: add flow create function Beilei Xing
2016-12-27  6:26   ` [dpdk-dev] [PATCH v2 11/17] net/i40e: add flow destroy function Beilei Xing
2016-12-27  6:26   ` [dpdk-dev] [PATCH v2 12/17] net/i40e: destroy ethertype filter Beilei Xing
2016-12-28  3:30     ` Wu, Jingjing
2016-12-28  7:29       ` Xing, Beilei
2016-12-28  4:56     ` Tiwei Bie
2016-12-28  6:57       ` Xing, Beilei
2016-12-27  6:26   ` [dpdk-dev] [PATCH v2 13/17] net/i40e: destroy tunnel filter Beilei Xing
2016-12-27  6:26   ` [dpdk-dev] [PATCH v2 14/17] net/i40e: destroy flow directory filter Beilei Xing
2016-12-27  6:26   ` [dpdk-dev] [PATCH v2 15/17] net/i40e: add flow flush function Beilei Xing
2016-12-27 12:40     ` Adrien Mazarguil
2016-12-28  8:02       ` Xing, Beilei
2016-12-28  5:35     ` Tiwei Bie
2016-12-28  6:48       ` Xing, Beilei
2016-12-28  7:00         ` Tiwei Bie
2016-12-28  7:20           ` Xing, Beilei
2016-12-27  6:26   ` [dpdk-dev] [PATCH v2 16/17] net/i40e: flush ethertype filters Beilei Xing
2016-12-27  6:26   ` [dpdk-dev] [PATCH v2 17/17] net/i40e: flush tunnel filters Beilei Xing
2016-12-29 16:04   ` [dpdk-dev] [PATCH v3 00/17] net/i40e: consistent filter API Beilei Xing
2016-12-29 16:04     ` [dpdk-dev] [PATCH v3 01/17] net/i40e: store ethertype filter Beilei Xing
2016-12-29 16:04     ` [dpdk-dev] [PATCH v3 02/17] net/i40e: store tunnel filter Beilei Xing
2016-12-29 16:04     ` [dpdk-dev] [PATCH v3 03/17] net/i40e: store flow director filter Beilei Xing
2016-12-29 16:04     ` [dpdk-dev] [PATCH v3 04/17] net/i40e: restore ethertype filter Beilei Xing
2016-12-29 16:04     ` [dpdk-dev] [PATCH v3 05/17] net/i40e: restore tunnel filter Beilei Xing
2016-12-29 16:04     ` [dpdk-dev] [PATCH v3 06/17] net/i40e: restore flow director filter Beilei Xing
2016-12-29 16:04     ` [dpdk-dev] [PATCH v3 07/17] net/i40e: add flow validate function Beilei Xing
2016-12-29 16:04     ` [dpdk-dev] [PATCH v3 08/17] net/i40e: parse flow director filter Beilei Xing
2016-12-29 16:04     ` [dpdk-dev] [PATCH v3 09/17] net/i40e: parse tunnel filter Beilei Xing
2016-12-29 16:04     ` [dpdk-dev] [PATCH v3 10/17] net/i40e: add flow create function Beilei Xing
2016-12-29 16:04     ` [dpdk-dev] [PATCH v3 11/17] net/i40e: add flow destroy function Beilei Xing
2016-12-29 16:04     ` [dpdk-dev] [PATCH v3 12/17] net/i40e: destroy ethertype filter Beilei Xing
2016-12-29 16:04     ` [dpdk-dev] [PATCH v3 13/17] net/i40e: destroy tunnel filter Beilei Xing
2016-12-29 16:04     ` [dpdk-dev] [PATCH v3 14/17] net/i40e: destroy flow directory filter Beilei Xing
2016-12-29 16:04     ` [dpdk-dev] [PATCH v3 15/17] net/i40e: add flow flush function Beilei Xing
2016-12-29 16:04     ` [dpdk-dev] [PATCH v3 16/17] net/i40e: flush ethertype filters Beilei Xing
2016-12-29 16:04     ` [dpdk-dev] [PATCH v3 17/17] net/i40e: flush tunnel filters Beilei Xing
2016-12-30  3:25     ` [dpdk-dev] [PATCH v4 00/17] net/i40e: consistent filter API Beilei Xing
2016-12-30  3:25       ` [dpdk-dev] [PATCH v4 01/17] net/i40e: store ethertype filter Beilei Xing
2016-12-30  3:25       ` [dpdk-dev] [PATCH v4 02/17] net/i40e: store tunnel filter Beilei Xing
2016-12-30  3:25       ` [dpdk-dev] [PATCH v4 03/17] net/i40e: store flow director filter Beilei Xing
2016-12-30  3:25       ` [dpdk-dev] [PATCH v4 04/17] net/i40e: restore ethertype filter Beilei Xing
2016-12-30  3:25       ` [dpdk-dev] [PATCH v4 05/17] net/i40e: restore tunnel filter Beilei Xing
2016-12-30  3:25       ` [dpdk-dev] [PATCH v4 06/17] net/i40e: restore flow director filter Beilei Xing
2016-12-30  3:25       ` [dpdk-dev] [PATCH v4 07/17] net/i40e: add flow validate function Beilei Xing
2016-12-30  3:25       ` [dpdk-dev] [PATCH v4 08/17] net/i40e: parse flow director filter Beilei Xing
2016-12-30  3:25       ` [dpdk-dev] [PATCH v4 09/17] net/i40e: parse tunnel filter Beilei Xing
2016-12-30  3:25       ` [dpdk-dev] [PATCH v4 10/17] net/i40e: add flow create function Beilei Xing
2016-12-30  3:25       ` [dpdk-dev] [PATCH v4 11/17] net/i40e: add flow destroy function Beilei Xing
2016-12-30  3:25       ` [dpdk-dev] [PATCH v4 12/17] net/i40e: destroy ethertype filter Beilei Xing
2016-12-30  3:25       ` [dpdk-dev] [PATCH v4 13/17] net/i40e: destroy tunnel filter Beilei Xing
2016-12-30  3:25       ` [dpdk-dev] [PATCH v4 14/17] net/i40e: destroy flow directory filter Beilei Xing
2016-12-30  3:25       ` [dpdk-dev] [PATCH v4 15/17] net/i40e: add flow flush function Beilei Xing
2016-12-30  3:25       ` [dpdk-dev] [PATCH v4 16/17] net/i40e: flush ethertype filters Beilei Xing
2016-12-30  3:25       ` [dpdk-dev] [PATCH v4 17/17] net/i40e: flush tunnel filters Beilei Xing
2017-01-03  3:25         ` Guo, Jia
2017-01-03  4:49           ` Xing, Beilei
2017-01-04  3:22       ` [dpdk-dev] [PATCH v5 00/17] net/i40e: consistent filter API Beilei Xing
2017-01-04  3:22         ` [dpdk-dev] [PATCH v5 01/17] net/i40e: store ethertype filter Beilei Xing
2017-01-04  3:22         ` [dpdk-dev] [PATCH v5 02/17] net/i40e: store tunnel filter Beilei Xing
2017-01-04  3:22         ` [dpdk-dev] [PATCH v5 03/17] net/i40e: store flow director filter Beilei Xing
2017-01-04  3:22         ` [dpdk-dev] [PATCH v5 04/17] net/i40e: restore ethertype filter Beilei Xing
2017-01-04  3:22         ` [dpdk-dev] [PATCH v5 05/17] net/i40e: restore tunnel filter Beilei Xing
2017-01-04  3:22         ` [dpdk-dev] [PATCH v5 06/17] net/i40e: restore flow director filter Beilei Xing
2017-01-04  3:22         ` [dpdk-dev] [PATCH v5 07/17] net/i40e: add flow validate function Beilei Xing
2017-01-04 18:57           ` Ferruh Yigit
2017-01-05  6:08             ` Xing, Beilei
2017-01-05 11:16               ` Ferruh Yigit
2017-01-05 11:52                 ` Xing, Beilei
2017-01-04  3:22         ` [dpdk-dev] [PATCH v5 08/17] net/i40e: parse flow director filter Beilei Xing
2017-01-04  3:22         ` [dpdk-dev] [PATCH v5 09/17] net/i40e: parse tunnel filter Beilei Xing
2017-01-04  3:23         ` [dpdk-dev] [PATCH v5 10/17] net/i40e: add flow create function Beilei Xing
2017-01-04  3:23         ` [dpdk-dev] [PATCH v5 11/17] net/i40e: add flow destroy function Beilei Xing
2017-01-04  3:23         ` [dpdk-dev] [PATCH v5 12/17] net/i40e: destroy ethertype filter Beilei Xing
2017-01-04  3:23         ` [dpdk-dev] [PATCH v5 13/17] net/i40e: destroy tunnel filter Beilei Xing
2017-01-04  3:23         ` [dpdk-dev] [PATCH v5 14/17] net/i40e: destroy flow directory filter Beilei Xing
2017-01-04  3:23         ` [dpdk-dev] [PATCH v5 15/17] net/i40e: add flow flush function Beilei Xing
2017-01-04  3:23         ` [dpdk-dev] [PATCH v5 16/17] net/i40e: flush ethertype filters Beilei Xing
2017-01-04  3:23         ` [dpdk-dev] [PATCH v5 17/17] net/i40e: flush tunnel filters Beilei Xing
2017-01-04  6:40         ` [dpdk-dev] [PATCH v5 00/17] net/i40e: consistent filter API Wu, Jingjing
2017-01-05 15:45         ` [dpdk-dev] [PATCH v6 " Beilei Xing
2017-01-05 15:45           ` [dpdk-dev] [PATCH v6 01/17] net/i40e: store ethertype filter Beilei Xing
2017-01-05 17:46             ` Ferruh Yigit
2017-01-05 15:45           ` [dpdk-dev] [PATCH v6 02/17] net/i40e: store tunnel filter Beilei Xing
2017-01-05 15:45           ` [dpdk-dev] [PATCH v6 03/17] net/i40e: store flow director filter Beilei Xing
2017-01-05 15:45           ` [dpdk-dev] [PATCH v6 04/17] net/i40e: restore ethertype filter Beilei Xing
2017-01-05 15:45           ` [dpdk-dev] [PATCH v6 05/17] net/i40e: restore tunnel filter Beilei Xing
2017-01-05 15:45           ` [dpdk-dev] [PATCH v6 06/17] net/i40e: restore flow director filter Beilei Xing
2017-01-05 15:46           ` [dpdk-dev] [PATCH v6 07/17] net/i40e: add flow validate function Beilei Xing
2017-01-05 15:46           ` [dpdk-dev] [PATCH v6 08/17] net/i40e: parse flow director filter Beilei Xing
2017-01-05 15:46           ` [dpdk-dev] [PATCH v6 09/17] net/i40e: parse tunnel filter Beilei Xing
2017-01-05 15:46           ` [dpdk-dev] [PATCH v6 10/17] net/i40e: add flow create function Beilei Xing
2017-01-05 17:47             ` Ferruh Yigit
2017-01-05 15:46           ` [dpdk-dev] [PATCH v6 11/17] net/i40e: add flow destroy function Beilei Xing
2017-01-05 15:46           ` [dpdk-dev] [PATCH v6 12/17] net/i40e: destroy ethertype filter Beilei Xing
2017-01-05 15:46           ` [dpdk-dev] [PATCH v6 13/17] net/i40e: destroy tunnel filter Beilei Xing
2017-01-05 15:46           ` [dpdk-dev] [PATCH v6 14/17] net/i40e: destroy flow directory filter Beilei Xing
2017-01-05 15:46           ` [dpdk-dev] [PATCH v6 15/17] net/i40e: add flow flush function Beilei Xing
2017-01-05 15:46           ` [dpdk-dev] [PATCH v6 16/17] net/i40e: flush ethertype filters Beilei Xing
2017-01-05 15:46           ` [dpdk-dev] [PATCH v6 17/17] net/i40e: flush tunnel filters Beilei Xing
2017-01-05 17:46           ` [dpdk-dev] [PATCH v6 00/17] net/i40e: consistent filter API Ferruh Yigit
2017-01-06  5:27           ` [dpdk-dev] [PATCH v7 " Beilei Xing
2017-01-06  5:27             ` [dpdk-dev] [PATCH v7 01/17] net/i40e: store ethertype filter Beilei Xing
2017-01-06  5:27             ` [dpdk-dev] [PATCH v7 02/17] net/i40e: store tunnel filter Beilei Xing
2017-01-06  5:27             ` [dpdk-dev] [PATCH v7 03/17] net/i40e: store flow director filter Beilei Xing
2017-01-06  5:27             ` [dpdk-dev] [PATCH v7 04/17] net/i40e: restore ethertype filter Beilei Xing
2017-01-06  5:27             ` [dpdk-dev] [PATCH v7 05/17] net/i40e: restore tunnel filter Beilei Xing
2017-01-06  5:27             ` [dpdk-dev] [PATCH v7 06/17] net/i40e: restore flow director filter Beilei Xing
2017-01-06  5:27             ` [dpdk-dev] [PATCH v7 07/17] net/i40e: add flow validate function Beilei Xing
2017-01-06  5:27             ` [dpdk-dev] [PATCH v7 08/17] net/i40e: parse flow director filter Beilei Xing
2017-01-06  5:27             ` [dpdk-dev] [PATCH v7 09/17] net/i40e: parse tunnel filter Beilei Xing
2017-01-06  5:27             ` [dpdk-dev] [PATCH v7 10/17] net/i40e: add flow create function Beilei Xing
2017-01-06  5:27             ` [dpdk-dev] [PATCH v7 11/17] net/i40e: add flow destroy function Beilei Xing
2017-01-06  5:27             ` [dpdk-dev] [PATCH v7 12/17] net/i40e: destroy ethertype filter Beilei Xing
2017-01-06  5:27             ` [dpdk-dev] [PATCH v7 13/17] net/i40e: destroy tunnel filter Beilei Xing
2017-01-06  5:27             ` [dpdk-dev] [PATCH v7 14/17] net/i40e: destroy flow directory filter Beilei Xing
2017-01-06  5:27             ` [dpdk-dev] [PATCH v7 15/17] net/i40e: add flow flush function Beilei Xing
2017-01-06  5:27             ` [dpdk-dev] [PATCH v7 16/17] net/i40e: flush ethertype filters Beilei Xing
2017-01-06  5:27             ` [dpdk-dev] [PATCH v7 17/17] net/i40e: flush tunnel filters Beilei Xing
2017-01-06 11:54             ` [dpdk-dev] [PATCH v7 00/17] net/i40e: consistent filter API Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161228092945.GF3737@6wind.com \
    --to=adrien.mazarguil@6wind.com \
    --cc=beilei.xing@intel.com \
    --cc=dev@dpdk.org \
    --cc=helin.zhang@intel.com \
    --cc=jingjing.wu@intel.com \
    --cc=wenzhuo.lu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).