From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
To: "Charles (Chas) Williams" <ciwillia@brocade.com>
Cc: dev@dpdk.org, mtetsuyah@gmail.com
Subject: Re: [dpdk-dev] [PATCH v3 2/2] net/vhost: emulate device start/stop behavior
Date: Tue, 3 Jan 2017 16:29:13 +0800 [thread overview]
Message-ID: <20170103082913.GD21228@yliu-dev.sh.intel.com> (raw)
In-Reply-To: <1483297317-20315-2-git-send-email-ciwillia@brocade.com>
On Sun, Jan 01, 2017 at 02:01:57PM -0500, Charles (Chas) Williams wrote:
> .dev_start()/.dev_stop() roughly corresponds to the local device's
> port being up or down. This is different from the remote client being
> connected which is roughtly link up or down. Emulate the behavior by
> separately tracking the local start/stop state to determine if we should
> allow packets to be queued to the remote client.
>
> Signed-off-by: Chas Williams <ciwillia@brocade.com>
> ---
> drivers/net/vhost/rte_eth_vhost.c | 65 ++++++++++++++++++++++++++++++++-------
> 1 file changed, 54 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/net/vhost/rte_eth_vhost.c b/drivers/net/vhost/rte_eth_vhost.c
> index 6b11e40..d5a4540 100644
> --- a/drivers/net/vhost/rte_eth_vhost.c
> +++ b/drivers/net/vhost/rte_eth_vhost.c
> @@ -100,7 +100,8 @@ struct vhost_stats {
>
> struct vhost_queue {
> int vid;
> - rte_atomic32_t allow_queuing;
> + rte_atomic32_t connected;
> + rte_atomic32_t ready;
> rte_atomic32_t while_queuing;
> struct pmd_internal *internal;
> struct rte_mempool *mb_pool;
> @@ -383,18 +384,25 @@ vhost_update_packet_xstats(struct vhost_queue *vq,
> }
> }
>
> +static inline bool
> +queuing_stopped(struct vhost_queue *r)
> +{
> + return unlikely(rte_atomic32_read(&r->connected) == 0 ||
> + rte_atomic32_read(&r->ready) == 0);
> +}
That's one more check comparing to the old code, meaning a bit more
expensive than before.
I think we could maintain the same effort by:
- introduce per-device "started" flag: set/unset on dev_start/stop,
respectively.
- introduce per-device "dev_attached" flag: set/unset on
new/destory_device(), respectively.
On update of each flag, setting "allow_queuing" properly.
Okay to you?
--yliu
next prev parent reply other threads:[~2017-01-03 8:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-01 19:01 [dpdk-dev] [PATCH v3 1/2] net/vhost: create datagram sockets immediately Charles (Chas) Williams
2017-01-01 19:01 ` [dpdk-dev] [PATCH v3 2/2] net/vhost: emulate device start/stop behavior Charles (Chas) Williams
2017-01-03 8:29 ` Yuanhan Liu [this message]
2017-01-03 8:22 ` [dpdk-dev] [PATCH v3 1/2] net/vhost: create datagram sockets immediately Yuanhan Liu
2017-01-03 13:52 ` Charles (Chas) Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170103082913.GD21228@yliu-dev.sh.intel.com \
--to=yuanhan.liu@linux.intel.com \
--cc=ciwillia@brocade.com \
--cc=dev@dpdk.org \
--cc=mtetsuyah@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).