From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
To: Yong Wang <wang.yong19@zte.com.cn>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] lib/librte_vhost: fix memory leak
Date: Wed, 4 Jan 2017 12:02:10 +0800 [thread overview]
Message-ID: <20170104040210.GE21228@yliu-dev.sh.intel.com> (raw)
In-Reply-To: <1483502275-18482-1-git-send-email-wang.yong19@zte.com.cn>
On Tue, Jan 03, 2017 at 10:57:55PM -0500, Yong Wang wrote:
> In function vhost_new_device(), current code dose not free 'dev'
> in "i == MAX_VHOST_DEVICE" condition statements. It will lead to a
> memory leak.
Nice catch!
Here are few minor stuff you might need pay attention to for future
contribution:
- a fix patch needs a fixline, like following
Fixes: 45ca9c6f7bc6 ("vhost: get rid of linked list for devices")
- the prefix for vhost lib is "vhost: ". And FYI, for PMD drivers, it's
'net/PMD_NAME', say 'net/virtio'.
For you convenience, I have fixed the two while applying. And thanks
for the fix.
Applied to dpdk-next-virtio.
--yliu
next prev parent reply other threads:[~2017-01-04 4:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-04 3:57 Yong Wang
2017-01-04 4:02 ` Yuanhan Liu [this message]
2017-01-04 6:55 ` [dpdk-dev] 答复: " wang.yong19
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170104040210.GE21228@yliu-dev.sh.intel.com \
--to=yuanhan.liu@linux.intel.com \
--cc=dev@dpdk.org \
--cc=wang.yong19@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).