DPDK patches and discussions
 help / color / mirror / Atom feed
From: Adrien Mazarguil <adrien.mazarguil@6wind.com>
To: Yongseok Koh <yskoh@mellanox.com>
Cc: ferruh.yigit@intel.com, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] net/mlx5: add support for ConnectX-5 NICs
Date: Thu, 5 Jan 2017 11:38:21 +0100	[thread overview]
Message-ID: <20170105103821.GM12822@6wind.com> (raw)
In-Reply-To: <20170105023219.10146-1-yskoh@mellanox.com>

Hi Koh,

On Wed, Jan 04, 2017 at 06:32:19PM -0800, Yongseok Koh wrote:
> Add PCI device ID for ConnectX-5 and enable multi-packet send for PF and
> VF.
> 
> Signed-off-by: Yongseok Koh <yskoh@mellanox.com>
> ---
> 
> ConnectX-5 is a newly announced NIC of Mellanox. This patch includes basic
> enablement of ConnectX-5.
> 
>  drivers/net/mlx5/mlx5.c        | 42 +++++++++++++++++++++++++++++++++++++-----
>  drivers/net/mlx5/mlx5.h        |  4 ++++
>  drivers/net/mlx5/mlx5_ethdev.c |  7 ++-----
>  drivers/net/mlx5/mlx5_txq.c    |  2 +-
>  4 files changed, 44 insertions(+), 11 deletions(-)
[...]

While the changes made by this patch are fine, it is missing the mandatory
update of related documentation, specifically:

- doc/guides/nics/mlx5.rst: places where ConnectX-4 is also mentioned must
  be updated.

- doc/guides/rel_notes/release_17_02.rst: support for ConnectX-5 must appear
  somewhere (you can use past release notes as a template).

-- 
Adrien Mazarguil
6WIND

  reply	other threads:[~2017-01-05 10:38 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-05  2:32 Yongseok Koh
2017-01-05 10:38 ` Adrien Mazarguil [this message]
2017-01-05 11:52 ` [dpdk-dev] [PATCH v2] " Yongseok Koh
2017-01-05 20:26   ` Adrien Mazarguil
2017-01-06  0:49 ` [dpdk-dev] [PATCH v3] " Yongseok Koh
2017-01-06  8:50   ` Adrien Mazarguil
2017-01-06  9:09     ` Thomas Monjalon
2017-01-06 13:32     ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170105103821.GM12822@6wind.com \
    --to=adrien.mazarguil@6wind.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=yskoh@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).