From: Adrien Mazarguil <adrien.mazarguil@6wind.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>,
dev@dpdk.org, stable@dpdk.org
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] net/mlx5: fix Tx doorbell
Date: Thu, 5 Jan 2017 17:32:26 +0100 [thread overview]
Message-ID: <20170105163226.GP12822@6wind.com> (raw)
In-Reply-To: <2da35386-f774-a1ca-c4f2-cc77f74f6e2c@intel.com>
Hi Ferruh,
On Thu, Jan 05, 2017 at 03:19:35PM +0000, Ferruh Yigit wrote:
> On 12/9/2016 1:27 PM, Nelio Laranjeiro wrote:
> > Too much data is uselessly written to the Tx doorbell.
> >
> > Fixes: 1d88ba171942 ("net/mlx5: refactor Tx data path")
> >
> > Signed-off-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
> > Acked-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
> >
>
> Applied to dpdk-next-net/master, thanks.
>
> Is not CC'ing stable intentional, since this patch depends on a patch
> introduced in this release? If not intentional, please CC stable.
I intended to update the commit message for this patch as in the meantime we
discovered it addresses a significant regression introduced in v16.11.
CC'ing stable now.
If possible, can you amend the commit log with:
---
net/mlx5: fix Tx doorbell
Too much data is uselessly written to the Tx doorbell, which since v16.11
may also cause Tx queues to behave erratically and crash applications.
This regression was seen on VF devices when the BlueFlame buffer size is
zero (txq->cqe_n == 0) due to the following change:
- cqe = &(*txq->cqes)[ci & (txq->cqe_n - 1)].cqe64;
+ cqe = &(*txq->cqes)[ci & ((1 << txq->cqe_n) - 1)];
Fixes: 1d88ba171942 ("net/mlx5: refactor Tx data path")
Fixes: e2f116ee3cac ("net/mlx5: reduce memory overhead for CQE handling")
Signed-off-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
Acked-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
Cc: stable@dpdk.org
---
Thanks,
--
Adrien Mazarguil
6WIND
next parent reply other threads:[~2017-01-05 16:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1481290078-4530-1-git-send-email-nelio.laranjeiro@6wind.com>
[not found] ` <2da35386-f774-a1ca-c4f2-cc77f74f6e2c@intel.com>
2017-01-05 16:32 ` Adrien Mazarguil [this message]
2017-01-05 16:52 ` Adrien Mazarguil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170105163226.GP12822@6wind.com \
--to=adrien.mazarguil@6wind.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=nelio.laranjeiro@6wind.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).