From: Jerin Jacob <jerin.jacob@caviumnetworks.com>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: <dev@dpdk.org>, <thomas.monjalon@6wind.com>,
<hemant.agrawal@nxp.com>, <gage.eads@intel.com>,
<harry.van.haaren@intel.com>
Subject: Re: [dpdk-dev] [PATCH v3 0/6] libeventdev API and northbound implementation
Date: Wed, 11 Jan 2017 21:22:28 +0530 [thread overview]
Message-ID: <20170111155227.GA30964@localhost.localdomain> (raw)
In-Reply-To: <20161220132251.GA211688@bricha3-MOBL3.ger.corp.intel.com>
On Tue, Dec 20, 2016 at 01:22:51PM +0000, Bruce Richardson wrote:
> On Tue, Dec 20, 2016 at 06:39:30PM +0530, Jerin Jacob wrote:
> > On Tue, Dec 20, 2016 at 11:13:42AM +0000, Bruce Richardson wrote:
> > > On Sun, Dec 18, 2016 at 07:51:29PM +0530, Jerin Jacob wrote:
> > > > As previously discussed in RFC v1 [1], RFC v2 [2], with changes
> > > > described in [3] (also pasted below), here is the first non-draft series
> > > > for this new API.
> > > >
> > > > [1] http://dpdk.org/ml/archives/dev/2016-August/045181.html
> > > > [2] http://dpdk.org/ml/archives/dev/2016-October/048592.html
> > > > [3] http://dpdk.org/ml/archives/dev/2016-October/048196.html
> > > >
> > > > v2..v3:
> > > >
> > > > - This patch set is check-patch clean with an exception that
> > > > 03/06 has one WARNING:MACRO_WITH_FLOW_CONTROL
> > > > - Looking forward to getting additional maintainers for libeventdev
> > > >
> > > > TODO:
> > > > 1) Create user guide
> > > >
> > > > Jerin Jacob (6):
> > > > eventdev: introduce event driven programming model
> > > > eventdev: define southbound driver interface
> > > > eventdev: implement the northbound APIs
> > > > eventdev: implement PMD registration functions
> > > > event/skeleton: add skeleton eventdev driver
> > > > app/test: unit test case for eventdev APIs
> > > >
> > > Hi Jerin,
> >
> > Hi Bruce,
> >
> > >
> > > other than the couple of comments I've made in replies to the individual
> > > patches, this looks pretty good to me. Only additional comment I have is
> >
> > Thanks
> >
> > > that some of the macro names are a little long, and maybe we can shorten
> > > them For example, you've added "_FLAG_" into the config flag macros,
> > > and I'm not sure that is necessary. Similarly, I think we can drop
> > > "_DEV_" from the PRIORITY names to shorten them.
> >
> > OK. I will remove the explicit _FLAG_ to shorten macro name.
> > The _DEV_ in PRIORITY is not that long. So I would like to keep it for
> > consistency and to denote it across priorities in event dev.
> >
> > >
> > > Irrespective of these naming suggestions, once the other couple of
> > > comments are taken care of, I think this set is suitable for merging to
> > > the next-event tree.
> >
> > I will send v4 with fixes and your suggestions. If their is no further
> > comment on that, we will merge to next-event tree
> >
> I'm not sure a v4 is needed, unless you especially want to do one.
> Given the scope of the suggested changes I think you can just make
> those changes on apply to the next-event tree.
Applied to dpdk-next-eventdev tree.
Thanks
>
> /Bruce
next prev parent reply other threads:[~2017-01-11 15:52 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-20 8:00 [dpdk-dev] [PATCH] eal: postpone vdev initialization Jerin Jacob
2016-11-20 16:05 ` David Marchand
2016-11-21 5:09 ` Shreyansh Jain
2016-11-21 16:56 ` Jerin Jacob
2016-11-21 9:54 ` Ferruh Yigit
2016-11-21 17:02 ` Jerin Jacob
2016-11-21 17:35 ` Ferruh Yigit
2016-11-23 0:07 ` Jerin Jacob
2016-11-23 13:29 ` Thomas Monjalon
2016-12-03 20:55 ` [dpdk-dev] [PATCH v2 0/2] " Jerin Jacob
2016-12-03 20:55 ` [dpdk-dev] [PATCH v2 1/2] eal: " Jerin Jacob
2016-12-03 20:55 ` [dpdk-dev] [PATCH v2 2/2] eal: rename dev init API for consistency Jerin Jacob
2016-12-05 10:12 ` Shreyansh Jain
2016-12-05 10:24 ` Jerin Jacob
2016-12-05 14:03 ` Shreyansh Jain
2016-12-18 14:21 ` [dpdk-dev] [PATCH v3 0/6] libeventdev API and northbound implementation Jerin Jacob
2016-12-18 14:21 ` [dpdk-dev] [PATCH v3 1/6] eventdev: introduce event driven programming model Jerin Jacob
2016-12-18 14:21 ` [dpdk-dev] [PATCH v3 2/6] eventdev: define southbound driver interface Jerin Jacob
2016-12-19 15:50 ` Bruce Richardson
2016-12-18 14:21 ` [dpdk-dev] [PATCH v3 3/6] eventdev: implement the northbound APIs Jerin Jacob
2016-12-18 14:21 ` [dpdk-dev] [PATCH v3 4/6] eventdev: implement PMD registration functions Jerin Jacob
2016-12-18 14:21 ` [dpdk-dev] [PATCH v3 5/6] event/skeleton: add skeleton eventdev driver Jerin Jacob
2016-12-19 11:58 ` Bruce Richardson
2016-12-18 14:21 ` [dpdk-dev] [PATCH v3 6/6] app/test: unit test case for eventdev APIs Jerin Jacob
2016-12-19 5:16 ` [dpdk-dev] [PATCH v3 0/6] libeventdev API and northbound implementation Shreyansh Jain
2016-12-20 11:13 ` Bruce Richardson
2016-12-20 13:09 ` Jerin Jacob
2016-12-20 13:22 ` Bruce Richardson
2017-01-11 15:52 ` Jerin Jacob [this message]
2016-12-21 14:39 ` [dpdk-dev] [PATCH v2 0/2] postpone vdev initialization Thomas Monjalon
2016-12-21 14:42 ` [dpdk-dev] [PATCH] eal: " Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170111155227.GA30964@localhost.localdomain \
--to=jerin.jacob@caviumnetworks.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=gage.eads@intel.com \
--cc=harry.van.haaren@intel.com \
--cc=hemant.agrawal@nxp.com \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).