From: Tiwei Bie <tiwei.bie@intel.com>
To: Olivier MATZ <olivier.matz@6wind.com>
Cc: Thomas Monjalon <thomas.monjalon@6wind.com>,
"Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
Adrien Mazarguil <adrien.mazarguil@6wind.com>,
dev@dpdk.org, "Lu, Wenzhuo" <wenzhuo.lu@intel.com>,
"Mcnamara, John" <john.mcnamara@intel.com>,
"Zhang, Helin" <helin.zhang@intel.com>,
"Dai, Wei" <wei.dai@intel.com>,
"Wang, Xiao W" <xiao.w.wang@intel.com>
Subject: Re: [dpdk-dev] [PATCH v5 3/8] ethdev: reserve capability flags for PMD-specific API
Date: Thu, 12 Jan 2017 10:08:26 +0800 [thread overview]
Message-ID: <20170112020826.GA24682@debian> (raw)
In-Reply-To: <20170111183248.38a27193@glumotte.dev.6wind.com>
On Wed, Jan 11, 2017 at 06:32:48PM +0100, Olivier MATZ wrote:
> Hi Tiwei, Hi Thomas,
>
> On Mon, 09 Jan 2017 12:26:53 +0100, Thomas Monjalon
> <thomas.monjalon@6wind.com> wrote:
> > 2017-01-09 11:57, Tiwei Bie:
> > > On Sun, Jan 08, 2017 at 08:39:55PM +0800, Ananyev, Konstantin
> > > wrote:
> > > > > Well my first reply to this thread was asking why isn't the
> > > > > whole API global from the start then?
> > > >
> > > > That's good question, and my preference would always be to have
> > > > the API to configure this feature as generic one.
> > > > I guess the main reason why it is not right now we don't reach an
> > > > agreement how this API should look like:
> > > > http://dpdk.org/ml/archives/dev/2016-September/047810.html
> > > > But I'll leave it to the author to provide the real reason
> > > > here.
> > >
> > > Yes, currently this work just provided a thin layer over 82599's
> > > hardware MACsec offload support to allow users configure 82599's
> > > MACsec offload engine. The current API may be too specific and may
> > > need a rework to be used with other NICs.
> >
> > I think it is a really good approach to start such API privately in a
> > driver. It will give us more time and experience to design a proper
> > generic API.
> >
> > Regarding the mbuf flag, it looks straight-forward, and as it is IEEE
> > standardized, I do not see any objection to add it now.
> > However, I will wait for the approval of Olivier - as maintainer of
> > mbuf.
> >
>
> Generally speaking, we have to be careful when introducing new mbuf
> flags, since we don't have so much of them (~25 remaining out of 64,
> which mean we may run out of them in 3-4 years).
>
> In this particular case, despite the flag is added for an ixgbe-specific
> API, when MACsec will be implemented on another PMD, the exact same
> flag would also be needed. That's the same for the ethdev capability
> flag. Moreover, as Thomas stated, it's a standardized protocol so it's
> legitimate to have it included in rte_mbuf.h.
>
> For me, having PMD-specific APIs for a new feature is not a problem,
> but I think we should try to have a generic API as soon as the feature
> is supported by several PMDs.
>
Sure! Thank you very much!
Best regards,
Tiwei Bie
next prev parent reply other threads:[~2017-01-12 2:09 UTC|newest]
Thread overview: 79+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-03 14:59 [dpdk-dev] [PATCH 0/3] Add MACsec offload support for ixgbe Tiwei Bie
2016-12-03 14:59 ` [dpdk-dev] [PATCH 1/3] lib: add MACsec offload flags Tiwei Bie
2016-12-03 14:59 ` [dpdk-dev] [PATCH 2/3] net/ixgbe: add MACsec offload support Tiwei Bie
2016-12-03 14:59 ` [dpdk-dev] [PATCH 3/3] app/testpmd: add ixgbe " Tiwei Bie
2016-12-16 1:43 ` [dpdk-dev] [PATCH v2 0/4] Add MACsec offload support for ixgbe Tiwei Bie
2016-12-16 1:43 ` [dpdk-dev] [PATCH v2 1/4] lib: add MACsec offload flags Tiwei Bie
2016-12-16 1:43 ` [dpdk-dev] [PATCH v2 2/4] net/ixgbe: add MACsec offload support Tiwei Bie
2016-12-16 1:43 ` [dpdk-dev] [PATCH v2 3/4] app/testpmd: add ixgbe " Tiwei Bie
2016-12-16 1:43 ` [dpdk-dev] [PATCH v2 4/4] doc: add ixgbe specific APIs Tiwei Bie
2016-12-16 10:29 ` Mcnamara, John
2016-12-25 14:57 ` [dpdk-dev] [PATCH v3 0/6] Add MACsec offload support for ixgbe Tiwei Bie
2016-12-25 14:57 ` [dpdk-dev] [PATCH v3 1/6] mbuf: add flag for MACsec Tiwei Bie
2016-12-25 14:57 ` [dpdk-dev] [PATCH v3 2/6] ethdev: add event type " Tiwei Bie
2016-12-25 14:57 ` [dpdk-dev] [PATCH v3 3/6] ethdev: add MACsec offload capability flags Tiwei Bie
2016-12-25 14:57 ` [dpdk-dev] [PATCH v3 4/6] net/ixgbe: add MACsec offload support Tiwei Bie
2016-12-25 14:57 ` [dpdk-dev] [PATCH v3 5/6] app/testpmd: add MACsec offload commands Tiwei Bie
2016-12-25 14:58 ` [dpdk-dev] [PATCH v3 6/6] doc: add ixgbe specific APIs Tiwei Bie
2016-12-26 15:15 ` [dpdk-dev] [PATCH v3 0/6] Add MACsec offload support for ixgbe Adrien Mazarguil
2016-12-27 1:33 ` Tiwei Bie
2016-12-27 14:37 ` Adrien Mazarguil
2016-12-27 17:42 ` Tiwei Bie
2016-12-28 15:41 ` [dpdk-dev] [PATCH v4 0/7] " Tiwei Bie
2016-12-28 15:41 ` [dpdk-dev] [PATCH v4 1/7] mbuf: reserve a Tx offload flag for PMD-specific API Tiwei Bie
2016-12-28 15:41 ` [dpdk-dev] [PATCH v4 2/7] ethdev: reserve an event type " Tiwei Bie
2016-12-28 15:41 ` [dpdk-dev] [PATCH v4 3/7] ethdev: reserve capability flags " Tiwei Bie
2016-12-28 15:41 ` [dpdk-dev] [PATCH v4 4/7] net/ixgbe: add MACsec offload support Tiwei Bie
2016-12-28 15:41 ` [dpdk-dev] [PATCH v4 5/7] app/testpmd: add MACsec offload commands Tiwei Bie
2016-12-28 15:41 ` [dpdk-dev] [PATCH v4 6/7] doc: add ixgbe specific APIs Tiwei Bie
2016-12-28 15:41 ` [dpdk-dev] [PATCH v4 7/7] doc: update the release notes for the reserved flags Tiwei Bie
2017-01-03 6:15 ` [dpdk-dev] [PATCH v4 0/7] Add MACsec offload support for ixgbe Lu, Wenzhuo
2017-01-04 7:21 ` [dpdk-dev] [PATCH v5 0/8] " Tiwei Bie
2017-01-04 7:21 ` [dpdk-dev] [PATCH v5 1/8] mbuf: reserve a Tx offload flag for PMD-specific API Tiwei Bie
2017-01-04 7:21 ` [dpdk-dev] [PATCH v5 2/8] ethdev: reserve an event type " Tiwei Bie
2017-01-04 7:21 ` [dpdk-dev] [PATCH v5 3/8] ethdev: reserve capability flags " Tiwei Bie
2017-01-04 14:21 ` Ananyev, Konstantin
2017-01-04 14:39 ` Tiwei Bie
2017-01-04 15:14 ` Ananyev, Konstantin
2017-01-04 17:00 ` Tiwei Bie
2017-01-04 17:44 ` Ananyev, Konstantin
2017-01-04 23:56 ` Tiwei Bie
2017-01-05 8:33 ` Adrien Mazarguil
2017-01-05 10:05 ` Tiwei Bie
2017-01-05 11:32 ` Ananyev, Konstantin
2017-01-05 18:21 ` Adrien Mazarguil
2017-01-08 12:39 ` Ananyev, Konstantin
2017-01-09 3:57 ` Tiwei Bie
2017-01-09 11:26 ` Thomas Monjalon
2017-01-10 2:08 ` Tiwei Bie
2017-01-11 17:32 ` Olivier MATZ
2017-01-12 2:08 ` Tiwei Bie [this message]
2017-01-12 2:42 ` Yuanhan Liu
2017-01-09 14:41 ` Adrien Mazarguil
2017-01-04 7:21 ` [dpdk-dev] [PATCH v5 4/8] net/ixgbe: add MACsec offload support Tiwei Bie
2017-01-04 7:21 ` [dpdk-dev] [PATCH v5 5/8] app/testpmd: add MACsec offload commands Tiwei Bie
2017-01-04 7:21 ` [dpdk-dev] [PATCH v5 6/8] doc: add ixgbe specific APIs Tiwei Bie
2017-01-04 7:21 ` [dpdk-dev] [PATCH v5 7/8] doc: update the release notes for the reserved flags Tiwei Bie
2017-01-04 7:21 ` [dpdk-dev] [PATCH v5 8/8] doc: add MACsec offload into NIC feature list Tiwei Bie
2017-01-04 8:29 ` [dpdk-dev] [PATCH v5 0/8] Add MACsec offload support for ixgbe Peng, Yuan
2017-01-11 4:31 ` [dpdk-dev] [PATCH v6 0/6] " Tiwei Bie
2017-01-11 4:31 ` [dpdk-dev] [PATCH v6 1/6] mbuf: add flag for MACsec Tiwei Bie
2017-01-11 17:41 ` Olivier MATZ
2017-01-11 4:31 ` [dpdk-dev] [PATCH v6 2/6] ethdev: add event type " Tiwei Bie
2017-01-11 4:31 ` [dpdk-dev] [PATCH v6 3/6] ethdev: add MACsec offload capability flags Tiwei Bie
2017-01-11 4:31 ` [dpdk-dev] [PATCH v6 4/6] net/ixgbe: add MACsec offload support Tiwei Bie
2017-01-11 4:31 ` [dpdk-dev] [PATCH v6 5/6] app/testpmd: add MACsec offload commands Tiwei Bie
2017-01-13 9:07 ` Thomas Monjalon
2017-01-13 9:16 ` Tiwei Bie
2017-01-11 4:31 ` [dpdk-dev] [PATCH v6 6/6] doc: add ixgbe specific APIs Tiwei Bie
2017-01-13 11:21 ` [dpdk-dev] [PATCH v7 0/6] Add MACsec offload support for ixgbe Tiwei Bie
2017-01-13 11:21 ` [dpdk-dev] [PATCH v7 1/6] mbuf: add flag for MACsec Tiwei Bie
2017-01-13 11:21 ` [dpdk-dev] [PATCH v7 2/6] ethdev: add event type " Tiwei Bie
2017-01-16 2:31 ` Ananyev, Konstantin
2017-01-13 11:21 ` [dpdk-dev] [PATCH v7 3/6] ethdev: add MACsec offload capability flags Tiwei Bie
2017-01-16 2:33 ` Ananyev, Konstantin
2017-01-13 11:21 ` [dpdk-dev] [PATCH v7 4/6] net/ixgbe: add MACsec offload support Tiwei Bie
2017-01-13 11:21 ` [dpdk-dev] [PATCH v7 5/6] app/testpmd: add MACsec offload commands Tiwei Bie
2017-01-13 11:21 ` [dpdk-dev] [PATCH v7 6/6] doc: add ixgbe specific APIs Tiwei Bie
2017-01-15 18:19 ` [dpdk-dev] [PATCH v7 0/6] Add MACsec offload support for ixgbe Thomas Monjalon
2017-01-23 2:30 ` Peng, Yuan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170112020826.GA24682@debian \
--to=tiwei.bie@intel.com \
--cc=adrien.mazarguil@6wind.com \
--cc=dev@dpdk.org \
--cc=helin.zhang@intel.com \
--cc=john.mcnamara@intel.com \
--cc=konstantin.ananyev@intel.com \
--cc=olivier.matz@6wind.com \
--cc=thomas.monjalon@6wind.com \
--cc=wei.dai@intel.com \
--cc=wenzhuo.lu@intel.com \
--cc=xiao.w.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).