From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
To: Jan Viktorin <viktorin@rehivetech.com>
Cc: "Thomas Monjalon" <thomas.monjalon@6wind.com>,
"Jianbo Liu" <jianbo.liu@linaro.org>,
"Jerin Jacob" <jerin.jacob@cavium.com>,
"Chao Zhu" <chaozhu@linux.vnet.ibm.com>,
dev@dpdk.org, "Tan Jianfeng" <jianfeng.tan@intel.com>,
"Wang Zhihong" <zhihong.wang@intel.com>,
"Olivier Matz" <olivier.matz@6wind.com>,
"Maxime Coquelin" <maxime.coquelin@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Orsák Michal" <xorsak01@stud.fit.vutbr.cz>
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH 1/2] net/virtio: fix performance regression due to TSO enabling
Date: Mon, 16 Jan 2017 15:12:18 +0800 [thread overview]
Message-ID: <20170116071218.GN9770@yliu-dev.sh.intel.com> (raw)
In-Reply-To: <20170113061309.GF9770@yliu-dev.sh.intel.com>
On Fri, Jan 13, 2017 at 02:13:09PM +0800, Yuanhan Liu wrote:
> But it's not the test methodology I'd expect. You are purely testing
> the instruction cycles. The drop on ARM is something more like "the
> if instruction takes more cycles than the simple assignment".
>
> This macro is used in the case that one process is heavily writing
> same value (0 here) again and again while another process is heavily
> read it also again and again. That means cache violation always
> happen. With this macro, however, this cache issue could be avoided,
> since no write happens.
>
> For such workload, I don't think it would behaviour worse on ARM.
No reply yet; I will treat it as no objections, and please shout out if any.
Both applied to dpdk-next-virtio.
--yliu
next prev parent reply other threads:[~2017-01-16 7:10 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-11 4:27 [dpdk-dev] [PATCH 0/2] net/virtio: optimize virtio net header reset Yuanhan Liu
2017-01-11 4:27 ` [dpdk-dev] [PATCH 1/2] net/virtio: fix performance regression due to TSO enabling Yuanhan Liu
2017-01-11 7:59 ` Maxime Coquelin
2017-01-11 8:08 ` Yuanhan Liu
2017-01-11 8:22 ` Olivier MATZ
2017-01-11 14:51 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
2017-01-12 2:30 ` Yuanhan Liu
2017-01-12 15:02 ` Jan Viktorin
2017-01-13 6:13 ` Yuanhan Liu
2017-01-16 7:12 ` Yuanhan Liu [this message]
[not found] ` <46569522-b2c3-2a33-9111-049b73c79760@stud.fit.vutbr.cz>
[not found] ` <20170116111256.GA11439@yliu-dev.sh.intel.com>
[not found] ` <8e8178c6-caa2-1b6e-10a0-c83820868db5@stud.fit.vutbr.cz>
2017-01-16 11:21 ` Yuanhan Liu
[not found] ` <a12848b4-76ef-29bc-f512-81bd8c1b9b76@stud.fit.vutbr.cz>
2017-01-30 13:30 ` Yuanhan Liu
2017-01-30 13:54 ` Maxime Coquelin
2017-01-30 14:10 ` Yuanhan Liu
2017-01-11 4:27 ` [dpdk-dev] [PATCH 2/2] net/virtio: optimize header reset on any layout Yuanhan Liu
2017-01-11 8:01 ` Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170116071218.GN9770@yliu-dev.sh.intel.com \
--to=yuanhan.liu@linux.intel.com \
--cc=chaozhu@linux.vnet.ibm.com \
--cc=dev@dpdk.org \
--cc=jerin.jacob@cavium.com \
--cc=jianbo.liu@linaro.org \
--cc=jianfeng.tan@intel.com \
--cc=maxime.coquelin@redhat.com \
--cc=mst@redhat.com \
--cc=olivier.matz@6wind.com \
--cc=thomas.monjalon@6wind.com \
--cc=viktorin@rehivetech.com \
--cc=xorsak01@stud.fit.vutbr.cz \
--cc=zhihong.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).