From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
To: "Tan, Jianfeng" <jianfeng.tan@intel.com>
Cc: "Yigit, Ferruh" <ferruh.yigit@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [PATCH] net/virtio-user: fix missing driver name
Date: Thu, 19 Jan 2017 16:16:25 +0800 [thread overview]
Message-ID: <20170119081625.GV9046@yliu-dev.sh.intel.com> (raw)
In-Reply-To: <ED26CBA2FAD1BF48A8719AEF02201E3651118DC0@SHSMSX103.ccr.corp.intel.com>
On Thu, Jan 19, 2017 at 09:16:58AM +0800, Tan, Jianfeng wrote:
> > >> On 1/18/2017 11:44 AM, Jianfeng Tan wrote:
> > >>> API rte_eth_dev_info_get() fills driver name according to drv_name
> > >>> of rte_eth_dev_data. But we have not fill such info in virtio_user.
> > >>>
> > >>> We do not use the same one with virtio device as some applications
> > >>> might depend on driver name to differetiate kinds of devices, such
> > >>> as VPP.
> > >>>
> > >>> Fixes: e9efa4d93821 ("net/virtio-user: add new virtual PCI driver")
> > >>> CC: stable@dpdk.org
> > >>>
> > >>> Signed-off-by: Jianfeng Tan <jianfeng.tan@intel.com>
> > >>> ---
> > >>> drivers/net/virtio/virtio_user_ethdev.c | 1 +
> > >>> 1 file changed, 1 insertion(+)
> > >>>
> > >>> diff --git a/drivers/net/virtio/virtio_user_ethdev.c
> > >> b/drivers/net/virtio/virtio_user_ethdev.c
> > >>> index c877968..110f6a9 100644
> > >>> --- a/drivers/net/virtio/virtio_user_ethdev.c
> > >>> +++ b/drivers/net/virtio/virtio_user_ethdev.c
> > >>> @@ -312,6 +312,7 @@ virtio_user_eth_dev_alloc(const char *name)
> > >>> hw->use_simple_rxtx = 0;
> > >>> hw->virtio_user_dev = dev;
> > >>> data->dev_private = hw;
> > >>> + data->drv_name = "virtio_user PMD";
> > >>
> > >> How driver naming done changed in next-net.
> > >> Please check any other virtual driver in next-net for sample.
> > >
> > > Thank you for the info. And it seems that it's already fixed by that patch.
> >
> > That patch modified during merge, can you please confirm the latest
> > version in the repo?
>
> Just checked latest master repo, this problem has been fixed by commit 73db5badb04 ("net: align ethdev and eal driver names"). Thanks to David Marchand.
>
> Yuanhan, do you think this patch can be applied to the stable repo?
I think I would partially backport that commit to a stable release: just
pick the virtio changes, with a brand new commit log, stating the issue
need to be fixed and it's a partial backport from 73db5badb04 ("net: align
ethdev and eal driver names").
Okay to you?
--yliu
next prev parent reply other threads:[~2017-01-19 8:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-18 11:44 Jianfeng Tan
2017-01-18 11:52 ` Ferruh Yigit
2017-01-18 13:49 ` Tan, Jianfeng
2017-01-18 15:54 ` Ferruh Yigit
2017-01-19 1:16 ` Tan, Jianfeng
2017-01-19 8:16 ` Yuanhan Liu [this message]
2017-01-19 8:23 ` Tan, Jianfeng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170119081625.GV9046@yliu-dev.sh.intel.com \
--to=yuanhan.liu@linux.intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=jianfeng.tan@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).