From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: dev@dpdk.org, Thomas Monjalon <thomas.monjalon@6wind.com>,
Remy Horton <remy.horton@intel.com>
Subject: Re: [dpdk-dev] [PATCH] ethdev: fix wrong memset
Date: Mon, 23 Jan 2017 18:34:17 +0800 [thread overview]
Message-ID: <20170123103417.GB10293@yliu-dev.sh.intel.com> (raw)
In-Reply-To: <3451afa6-12fb-dc65-f379-873facc0301c@intel.com>
On Mon, Jan 23, 2017 at 09:41:35AM +0000, Ferruh Yigit wrote:
> On 1/22/2017 2:45 AM, Yuanhan Liu wrote:
> > On Fri, Jan 20, 2017 at 03:27:43PM +0000, Ferruh Yigit wrote:
> >> On 1/20/2017 11:21 AM, Ferruh Yigit wrote:
> >>> On 1/20/2017 8:04 AM, Yuanhan Liu wrote:
> >>>> Fix an silly error by auto-complete while managing the merge conflicts.
> >>>> It's the eth_dev_data (but not eth_dev) entry should be memset.
> >>>>
> >>>> Fixes: d948f596fee2 ("ethdev: fix port data mismatched in multiple process model")
> >>>>
> >>>> Reported-by: Ferruh Yigit <ferruh.yigit@intel.com>
> >>>> Signed-off-by: Yuanhan Liu <yuanhan.liu@linux.intel.com>
> >>>> ---
> >>>> lib/librte_ether/rte_ethdev.c | 2 +-
> >>>> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>>>
> >>>> diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c
> >>>> index 4790faf..61f44e2 100644
> >>>> --- a/lib/librte_ether/rte_ethdev.c
> >>>> +++ b/lib/librte_ether/rte_ethdev.c
> >>>> @@ -225,7 +225,7 @@ struct rte_eth_dev *
> >>>> return NULL;
> >>>> }
> >>>>
> >>>> - memset(&rte_eth_devices[port_id], 0, sizeof(*eth_dev->data));
> >>>> + memset(&rte_eth_dev_data[port_id], 0, sizeof(struct rte_eth_dev_data));
> >>>
> >>> Not directly related to the this issue, but, after fix, this may have
> >>> issues with secondary process.
> >>>
> >>> There were patches sent to fix this.
> >>
> >> I mean this one:
> >> http://dpdk.org/ml/archives/dev/2017-January/054422.html
> >
> > d948f596fee2 ("ethdev: fix port data mismatched in multiple process
> > model") should have fixed it.
>
> Think about case, where secondary process uses a virtual PMD, which does
> a rte_eth_dev_allocate() call, shouldn't this corrupt primary process
> device data?
Yes, it may. However, I doubt that's the typical usage. Besides that,
most of virtual PMDs don't support Multipleprocess: git grep shows pcap
is the only one that does claim Multipleprocess is supported.
--yliu
next prev parent reply other threads:[~2017-01-23 10:31 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-20 8:04 Yuanhan Liu
2017-01-20 10:20 ` Thomas Monjalon
2017-01-20 10:34 ` Yuanhan Liu
2017-01-20 11:09 ` Ferruh Yigit
2017-01-20 18:05 ` Thomas Monjalon
2017-01-20 11:21 ` Ferruh Yigit
2017-01-20 15:27 ` Ferruh Yigit
2017-01-22 2:45 ` Yuanhan Liu
2017-01-23 9:41 ` Ferruh Yigit
2017-01-23 10:34 ` Yuanhan Liu [this message]
2017-01-23 11:05 ` Ferruh Yigit
2017-01-23 11:24 ` Yuanhan Liu
2017-01-23 11:32 ` Ferruh Yigit
2017-01-23 11:40 ` Yuanhan Liu
2017-01-23 11:56 ` Yuanhan Liu
2017-01-23 12:44 ` Ananyev, Konstantin
2017-01-23 12:52 ` Yuanhan Liu
2017-01-23 13:06 ` Ananyev, Konstantin
2017-01-23 13:09 ` Ferruh Yigit
2017-01-25 11:16 ` Thomas Monjalon
2017-01-28 13:14 ` Yuanhan Liu
2017-01-30 11:07 ` Remy Horton
2017-01-24 8:29 ` Remy Horton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170123103417.GB10293@yliu-dev.sh.intel.com \
--to=yuanhan.liu@linux.intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=remy.horton@intel.com \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).