From: Olivier Matz <olivier.matz@6wind.com>
To: Sergey Vyazmitinov <s.vyazmitinov@brain4net.com>
Cc: konstantin.ananyev@intel.com, stephen@networkplumber.org,
yuanhan.liu@linux.intel.com, ferruh.yigit@intel.com,
dev@dpdk.org, mirqus@gmail.com
Subject: Re: [dpdk-dev] [PATCH v6 1/2] kni: add bulk function to free mbufs
Date: Mon, 23 Jan 2017 13:59:47 +0100 [thread overview]
Message-ID: <20170123135947.0e5cbe83@platinum> (raw)
In-Reply-To: <1484801219-1312-2-git-send-email-s.vyazmitinov@brain4net.com>
Hi,
On Thu, 19 Jan 2017 11:46:58 +0700, Sergey Vyazmitinov
<s.vyazmitinov@brain4net.com> wrote:
> Suggested-by: Stephen Hemminger <stephen@networkplumber.org>
> Signed-off-by: Sergey Vyazmitinov <s.vyazmitinov@brain4net.com>
> ---
> v3:
> * Fixed issue with possible different mempools in buffer list.
> * Fixed issue with wrong rte_pktmbuf_alloc_bulk function return value
> processing in the kni_allocate_mbufs.
> ---
> lib/librte_mbuf/rte_mbuf.h | 49
> ++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 49
> insertions(+)
>
> diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h
> index 4476d75..69d314f 100644
> --- a/lib/librte_mbuf/rte_mbuf.h
> +++ b/lib/librte_mbuf/rte_mbuf.h
> @@ -306,6 +306,9 @@ extern "C" {
> /** Alignment constraint of mbuf private area. */
> #define RTE_MBUF_PRIV_ALIGN 8
>
> +/** Maximum number of mbufs freed in bulk. */
> +#define RTE_MBUF_BULK_FREE 64
> +
> /**
> * Get the name of a RX offload flag
> *
> @@ -1261,6 +1264,52 @@ static inline void rte_pktmbuf_free(struct
> rte_mbuf *m) }
>
> /**
> + * Free n packets mbuf back into its original mempool.
> + *
> + * Free each mbuf, and all its segments in case of chained buffers.
> Each
> + * segment is added back into its original mempool.
> + *
> + * @param mp
> + * The packets mempool.
This parameter was removed, it could be removed from the API comment.
> + * @param mbufs
> + * The packets mbufs array to be freed.
> + * @param n
> + * Number of packets.
> + */
> +static inline void rte_pktmbuf_free_bulk(struct rte_mbuf **mbufs,
> + unsigned int n)
I suggest we could use mbuf instead of pktmbuf in the function name.
It's a bit shorter, and the function would also apply on ctrlmbuf.
Also, the struct rte_mbuf **mbufs could probably be replaced by struct
rte_mbuf * const *mbufs.
> +{
> + void *tofree[RTE_MBUF_BULK_FREE];
> + struct rte_mempool *mp = NULL;
> + unsigned int i, count = 0;
> +
> + for (i = 0; i < n; i++) {
> + struct rte_mbuf *m, *m_next;
> +
> + for (m = mbufs[i]; m; m = m_next) {
> + m_next = m->next;
> +
> + if (count > 0 &&
> + (unlikely(m->pool != mp ||
> + count == RTE_MBUF_BULK_FREE))) {
> + rte_mempool_put_bulk(mp, tofree,
> count);
> + count = 0;
> + }
> +
> + mp = m->pool;
> +
> + if (likely(__rte_pktmbuf_prefree_seg(m) !=
> NULL)) {
> + m->next = NULL;
> + tofree[count++] = m;
> + }
> + }
> + }
> +
> + if (likely(count > 0))
> + rte_mempool_put_bulk(mp, tofree, count);
> +}
> +
> +/**
> * Creates a "clone" of the given packet mbuf.
> *
The function looks good to me, thank you. It looks also better than
what I've suggested in [1], since it properly manage mbuf chains. On
the other hand, I think my proposal could also help in drivers, where
segments are already unchained. I'll submit it in a RFC.
[1] http://dpdk.org/ml/archives/dev/2017-January/054538.html
One more thing, maybe it's worth adding a basic test in
app/test/test_mbuf.c.
Thanks,
Olivier
next prev parent reply other threads:[~2017-01-23 12:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-19 4:46 [dpdk-dev] [PATCH v6 0/2] kni: use bulk functions to allocate and " Sergey Vyazmitinov
2017-01-19 4:46 ` [dpdk-dev] [PATCH v6 1/2] kni: add bulk function to " Sergey Vyazmitinov
2017-01-23 12:59 ` Olivier Matz [this message]
2017-01-23 13:19 ` Olivier Matz
2017-01-19 4:46 ` [dpdk-dev] [PATCH v6 2/2] kni: Use bulk functions to allocate and " Sergey Vyazmitinov
2017-01-25 20:10 ` Ferruh Yigit
2017-01-25 19:04 ` [dpdk-dev] [PATCH v6 0/2] kni: use " Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170123135947.0e5cbe83@platinum \
--to=olivier.matz@6wind.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=konstantin.ananyev@intel.com \
--cc=mirqus@gmail.com \
--cc=s.vyazmitinov@brain4net.com \
--cc=stephen@networkplumber.org \
--cc=yuanhan.liu@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).