From: Bruce Richardson <bruce.richardson@intel.com>
To: Robin Jarry <robin.jarry@6wind.com>
Cc: Olivier Matz <olivier.matz@6wind.com>,
dev@dpdk.org, ferruh.yigit@intel.com, thomas.monjalon@6wind.com
Subject: Re: [dpdk-dev] [PATCH] mk: optimize directory dependencies
Date: Tue, 24 Jan 2017 11:26:33 +0000 [thread overview]
Message-ID: <20170124112633.GA156840@bricha3-MOBL3.ger.corp.intel.com> (raw)
In-Reply-To: <20170124111949.6jcif4uliwg6bgxv@6wind.com>
On Tue, Jan 24, 2017 at 12:19:49PM +0100, Robin Jarry wrote:
> Hi Olivier,
>
> 2017-01-23, Olivier Matz:
> > Before this patch, the management of dependencies between directories
> > had several issues:
> >
> > - the generation of .depdirs, done at configuration is slow: it can take
> > more than one minute on some slow targets (usually ~10s on a standard
> > PC).
>
> Indeed, on a Qualcomm development board where disk I/O is quite slow:
>
> $ git describe
> v17.02-rc1-3-g61207d014fc9
>
> $ time make config T=arm64-armv8a-linuxapp-gcc
> real 1m4.308s
>
Wow, what is the build time in that case?
> > - for instance, it is possible to expressed a dependency like:
>
> s/expressed/express/
>
> > - we cannot use "make -d" for debug, because the output of make is used
> > for the generation of .depdirs.
>
> That is really annoying when debugging makefiles.
>
> After applying this patch:
>
> $ git am mk-optimize-directory-dependencies.patch
> Applying: mk: optimize directory dependencies
> $ rm -rf build/
>
> $ time make config T=arm64-armv8a-linuxapp-gcc
> real 0m0.111s
>
> Almost 600 times faster than before!
>
> I prefer this solution to the one proposed by Ferruh (which is interesting
> but requires to run parallel make). Here is a test with the other patch:
>
> $ git am mk-parallelize-make-config.patch
> Applying: mk: parallelize make config
> $ rm -rf build/
> $ grep -c processor /proc/cpuinfo
> 24
>
> $ time make config T=arm64-armv8a-linuxapp-gcc -j24
> real 0m11.253s
>
> Here only 6 times faster than before, even when using 24 parallel processes.
>
> Tested-by: Robin Jarry <robin.jarry@6wind.com>
Hi Robin,
what are the differences in the patches like when doing a build rather
than just a config? If the build is minutes long because of slow IO,
is the extra 10 seconds really going to make that much of a difference?
Regards,
/Bruce
next prev parent reply other threads:[~2017-01-24 11:26 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-22 1:50 [dpdk-dev] [PATCH] mk: parallelize make config Ferruh Yigit
2017-01-23 17:18 ` Olivier Matz
2017-01-23 17:19 ` [dpdk-dev] [PATCH] mk: optimize directory dependencies Olivier Matz
2017-01-24 11:19 ` Robin Jarry
2017-01-24 11:26 ` Bruce Richardson [this message]
2017-01-24 12:31 ` Robin Jarry
2017-01-24 11:40 ` Jerin Jacob
2017-01-24 12:15 ` Bruce Richardson
2017-01-24 12:56 ` Jerin Jacob
2017-01-24 13:26 ` Richardson, Bruce
2017-01-24 14:50 ` Olivier MATZ
2017-01-24 14:55 ` Wiles, Keith
2017-03-01 11:25 ` Thomas Monjalon
2017-03-01 12:10 ` Bruce Richardson
2017-03-01 12:30 ` Olivier Matz
2017-01-24 13:05 ` Ferruh Yigit
2017-03-17 17:13 ` Olivier Matz
2017-03-17 17:47 ` Robin Jarry
2017-03-20 8:31 ` Olivier Matz
2017-03-24 13:21 ` [dpdk-dev] [PATCH v2] " Olivier Matz
2017-03-27 21:33 ` Thomas Monjalon
2017-03-28 10:34 ` Ferruh Yigit
2017-03-30 8:51 ` Olivier Matz
2017-03-30 9:27 ` Ferruh Yigit
2017-03-30 12:11 ` Olivier Matz
2017-03-30 12:32 ` [dpdk-dev] [PATCH] mk: fix dependencies to optional configs Olivier Matz
2017-03-30 12:37 ` Ferruh Yigit
2017-03-30 13:37 ` Thomas Monjalon
2017-01-23 17:50 ` [dpdk-dev] [PATCH] mk: parallelize make config Wiles, Keith
2017-01-24 8:42 ` Olivier MATZ
2017-01-24 10:02 ` Bruce Richardson
2017-01-23 19:03 ` Michał Mirosław
2017-01-30 9:41 ` Ferruh Yigit
2017-01-24 10:52 ` Bruce Richardson
2017-01-29 15:29 ` Thomas Monjalon
2017-01-30 9:46 ` Ferruh Yigit
2017-01-30 10:21 ` [dpdk-dev] [PATCH v2] " Ferruh Yigit
2017-01-30 18:13 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170124112633.GA156840@bricha3-MOBL3.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=olivier.matz@6wind.com \
--cc=robin.jarry@6wind.com \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).