From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
To: Emmanuel Roullit <emmanuel.roullit@gmail.com>
Cc: huawei.xie@intel.com, dev@dpdk.org,
Thomas Monjalon <thomas.monjalon@6wind.com>,
stable@dpdk.org
Subject: Re: [dpdk-stable] [PATCH] net/virtio: do not gso when no header is present
Date: Mon, 30 Jan 2017 20:42:41 +0800 [thread overview]
Message-ID: <20170130124241.GF20916@yliu-dev.sh.intel.com> (raw)
In-Reply-To: <20170124203603.3887-1-emmanuel.roullit@gmail.com>
On Tue, Jan 24, 2017 at 09:36:03PM +0100, Emmanuel Roullit wrote:
> Found with clang static analysis:
> lib/librte_vhost/virtio_net.c:723:17: warning:
> Access to field 'data_off' results in a dereference of a null pointer
> (loaded from variable 'tcp_hdr')
> m->l4_len = (tcp_hdr->data_off & 0xf0) >> 2;
> ^~~~~~~~~~~~~~~~~
This is a good fix, thanks. But there are few minor nits. Firstly,
prefix is wrong: it should be "vhost" but not "net/virtio".
> Fixes: 2a51b1091cb5 ("vhost: support indirect descriptor in non-mergeable Rx")
That's not the original commit introduced such issue, d0cf91303d73
("vhost: add Tx offload capabilities") is.
I actually saw you have made this kind of mistakes (referencing the
wrong culprit commit) few times. I'm wondering how did you get that.
Besides those, I think it's a good candidate for a stable release:
thinking that a malicious guest might forge some invalid virtio net
headers, which would make this potential NULL dereference become real.
So, Cc: stable@dpdk.org,
And Applied to dpdk-next-virtio.
--yliu
parent reply other threads:[~2017-01-30 12:40 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20170124203603.3887-1-emmanuel.roullit@gmail.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170130124241.GF20916@yliu-dev.sh.intel.com \
--to=yuanhan.liu@linux.intel.com \
--cc=dev@dpdk.org \
--cc=emmanuel.roullit@gmail.com \
--cc=huawei.xie@intel.com \
--cc=stable@dpdk.org \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).