From: Jerin Jacob <jerin.jacob@caviumnetworks.com>
To: Gage Eads <gage.eads@intel.com>
Cc: dev@dpdk.org, bruce.richardson@intel.com, hemant.agrawal@nxp.com,
harry.van.haaren@intel.com, nipun.gupta@nxp.com
Subject: Re: [dpdk-dev] [PATCH] eventdev: Add rte_errno return values to the enqueue and dequeue functions
Date: Tue, 14 Feb 2017 09:40:10 +0530 [thread overview]
Message-ID: <20170214041009.GB6091@localhost.localdomain> (raw)
In-Reply-To: <1486760541-12568-1-git-send-email-gage.eads@intel.com>
On Fri, Feb 10, 2017 at 03:02:21PM -0600, Gage Eads wrote:
> This change allows user software to differentiate between an invalid argument
> (such as an invalid queue_id or sched_type in an enqueued event) and
> backpressure from the event device.
>
> The port and device ID checks are placed in RTE_LIBRTE_EVENTDEV_DEBUG header
> guards to avoid the performance hit in non-debug execution.
>
> Signed-off-by: Gage Eads <gage.eads@intel.com>
> ---
> static inline uint16_t
> @@ -1127,6 +1133,21 @@ rte_event_enqueue_burst(uint8_t dev_id, uint8_t port_id,
> {
> struct rte_eventdev *dev = &rte_eventdevs[dev_id];
>
> + rte_errno = 0;
I don't think it is required. If at all required, move this under
RTE_LIBRTE_EVENTDEV_DEBUG to save store to rte_errno cycles on fastpath
> +#ifdef RTE_LIBRTE_EVENTDEV_DEBUG
> + if (rte_eventdevs[dev_id].attached == RTE_EVENTDEV_DETACHED) {
> + RTE_EDEV_LOG_DEBUG("Invalid dev_id=%d\n", dev_id);
> + rte_errno = -EINVAL;
> + return 0;
> + }
> +
> + if (port_id >= dev->data->nb_ports) {
> + RTE_EDEV_LOG_DEBUG("Invalid port_id=%d\n", port_id);
> + rte_errno = -EINVAL;
> + return 0;
> + }
> +#endif
> +
> /*
> * Allow zero cost non burst mode routine invocation if application
> * requests nb_events as const one
> @@ -1235,6 +1256,21 @@ rte_event_dequeue_burst(uint8_t dev_id, uint8_t port_id, struct rte_event ev[],
> {
> struct rte_eventdev *dev = &rte_eventdevs[dev_id];
>
> +#ifdef RTE_LIBRTE_EVENTDEV_DEBUG
> + rte_errno = 0;
> + if (rte_eventdevs[dev_id].attached == RTE_EVENTDEV_DETACHED) {
> + RTE_EDEV_LOG_DEBUG("Invalid dev_id=%d\n", dev_id);
> + rte_errno = -EINVAL;
> + return 0;
> + }
> +
> + if (port_id >= dev->data->nb_ports) {
> + RTE_EDEV_LOG_DEBUG("Invalid port_id=%d\n", port_id);
> + rte_errno = -EINVAL;
> + return 0;
> + }
> +#endif
> +
> /*
> * Allow zero cost non burst mode routine invocation if application
> * requests nb_events as const one
> --
> 2.7.4
>
next prev parent reply other threads:[~2017-02-14 4:10 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-10 21:02 Gage Eads
2017-02-13 10:38 ` Bruce Richardson
2017-02-13 11:48 ` Jerin Jacob
2017-02-13 12:08 ` Bruce Richardson
2017-02-13 16:05 ` Eads, Gage
2017-02-14 4:10 ` Jerin Jacob [this message]
2017-02-15 0:14 ` Eads, Gage
2017-02-15 17:09 ` [dpdk-dev] [PATCH v2] " Gage Eads
2017-03-16 10:28 ` Jerin Jacob
2017-03-16 20:12 ` [dpdk-dev] [PATCH v3] eventdev: add errno-style return values Gage Eads
2017-03-17 3:10 ` Jerin Jacob
2017-03-17 14:34 ` Eads, Gage
2017-03-17 14:51 ` [dpdk-dev] [PATCH v4] " Gage Eads
2017-03-21 11:06 ` Jerin Jacob
2017-03-21 20:38 ` Eads, Gage
2017-03-22 6:53 ` Jerin Jacob
2017-03-22 14:58 ` [dpdk-dev] [PATCH v5] " Gage Eads
2017-03-22 17:17 ` Jerin Jacob
2017-03-23 22:32 ` Eads, Gage
2017-03-23 22:30 ` [dpdk-dev] [PATCH v6] " Gage Eads
2017-03-24 2:38 ` Jerin Jacob
2017-03-25 5:11 ` Jerin Jacob
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170214041009.GB6091@localhost.localdomain \
--to=jerin.jacob@caviumnetworks.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=gage.eads@intel.com \
--cc=harry.van.haaren@intel.com \
--cc=hemant.agrawal@nxp.com \
--cc=nipun.gupta@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).