From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
To: hanxueluo@126.com
Cc: dev@dpdk.org, Huanle Han <hanxueluo@gmail.com>,
Thomas Monjalon <thomas.monjalon@6wind.com>,
"Yigit, Ferruh" <ferruh.yigit@intel.com>
Subject: Re: [dpdk-dev] [PATCH 1/3] net/virtio: fix dev detachable flag
Date: Wed, 22 Feb 2017 10:34:23 +0800 [thread overview]
Message-ID: <20170222023423.GN18844@yliu-dev.sh.intel.com> (raw)
In-Reply-To: <1487599487-12574-1-git-send-email-hanxueluo@126.com>
On Mon, Feb 20, 2017 at 10:04:45PM +0800, hanxueluo@126.com wrote:
> From: Huanle Han <hanxueluo@gmail.com>
>
> The dev detachable flag was removed by
> commit f229eb4 ("net/virtio: fix rewriting LSC flag").
>
> Signed-off-by: Huanle Han <hanxueluo@gmail.com>
> ---
> drivers/net/virtio/virtio_ethdev.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c
> index 4dc03b9..8465e1a 100644
> --- a/drivers/net/virtio/virtio_ethdev.c
> +++ b/drivers/net/virtio/virtio_ethdev.c
> @@ -1336,6 +1336,7 @@ virtio_init_device(struct rte_eth_dev *eth_dev, uint64_t req_features)
> if (eth_dev->device) {
> pci_dev = RTE_DEV_TO_PCI(eth_dev->device);
> rte_eth_copy_pci_info(eth_dev, pci_dev);
> + eth_dev->data->dev_flags |= RTE_ETH_DEV_DETACHABLE;
This is a partial fix. The major issue here is rte_eth_copy_pci_info has
an undocumented side effect: it resets the dev_flags unconditionally.
Removing such reset should be able to fix it: it also looks like the right
fix to me. Thomas, Ferruh?
If not, we could at least call rte_eth_copy_pci_info() at eth_virtio_dev_init(),
before we set any dev_flags bits.
--yliu
next prev parent reply other threads:[~2017-02-22 2:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-20 14:04 hanxueluo
2017-02-20 14:04 ` [dpdk-dev] [PATCH 2/3] net/virtio: fix crash when close virtio dev twice hanxueluo
2017-02-22 2:24 ` Yuanhan Liu
2017-04-28 4:56 ` Yuanhan Liu
2017-02-20 14:04 ` [dpdk-dev] [PATCH 3/3] pci: fix crash caused by invaild memory write hanxueluo
2017-02-22 2:36 ` Yuanhan Liu
2017-05-01 22:59 ` Thomas Monjalon
2017-02-22 2:34 ` Yuanhan Liu [this message]
2017-04-28 4:58 ` [dpdk-dev] [PATCH 1/3] net/virtio: fix dev detachable flag Yuanhan Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170222023423.GN18844@yliu-dev.sh.intel.com \
--to=yuanhan.liu@linux.intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=hanxueluo@126.com \
--cc=hanxueluo@gmail.com \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).