From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
To: Matthias Gatto <matthias.gatto@outscale.com>
Cc: dev@dpdk.org, stable@dpdk.org
Subject: Re: [dpdk-stable] [PATCH] vhost: try to shrink pfdset when fdset_add fails
Date: Thu, 23 Feb 2017 12:37:15 +0800 [thread overview]
Message-ID: <20170223043715.GT18844@yliu-dev.sh.intel.com> (raw)
In-Reply-To: <CAAsw5BcH6H5qZC31uwJj1Y8nVGMNTdzguE5nxFNe6-787FEy6w@mail.gmail.com>
On Wed, Feb 22, 2017 at 11:01:43AM +0100, Matthias Gatto wrote:
> On Wed, Feb 22, 2017 at 2:59 AM, Yuanhan Liu
> <yuanhan.liu@linux.intel.com> wrote:
> >
> > On Tue, Feb 21, 2017 at 03:25:30PM +0100, Matthias Gatto wrote:
> > > fdset_add increment pfdset->num, but fdset_del doesn't decrement pfdset->num,
> > > so if we call fdset_add then fdset_del in a loop witout calling
> > > fdset_shrink, we can easily exceed MAX_FDS with only a few number of fds
> > > used.
> >
> > I'm assuming you were doing some tests like following?
> >
> > while true; do
> > ovs-vsctl add-port br vhost_n -- ...
> > ovs-vsctl del-port vhost_n
> > done
> >
>
> Something pretty close to this yes.
Fixes: 59317cef249c ("vhost: allow many vhost-user ports")
Cc: stable@dpdk.org
And applied to dpdk-next-virtio, with few typos in commit log fixed.
Thanks!
--yliu
parent reply other threads:[~2017-02-23 4:35 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <CAAsw5BcH6H5qZC31uwJj1Y8nVGMNTdzguE5nxFNe6-787FEy6w@mail.gmail.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170223043715.GT18844@yliu-dev.sh.intel.com \
--to=yuanhan.liu@linux.intel.com \
--cc=dev@dpdk.org \
--cc=matthias.gatto@outscale.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).