From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
To: Ami Sabo <amis@radware.com>
Cc: dev@dpdk.org, Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [dpdk-dev] [PATCH] net/virtio-user: fix multi-process issue
Date: Fri, 24 Feb 2017 16:22:55 +0800 [thread overview]
Message-ID: <20170224082255.GC18844@yliu-dev.sh.intel.com> (raw)
In-Reply-To: <1487851096-32479-1-git-send-email-amis@radware.com>
On Thu, Feb 23, 2017 at 01:58:16PM +0200, Ami Sabo wrote:
> Secondary process doesn't properly attach to the rte_eth_device
> initialized by the primary process.
>
> Accessing device from secondary process (e.g. via rte_eth_rx_burst),
> causes process to crash. because rte_eth_dev_data is not properly set.
>
> The issue was flood by
> 'commit 7f95f78a8aea ("ethdev: clear data when allocating device")'
> which now clears rte_eth_dev_data entry.
>
> So, most of the rte_eth_dev_data fields are not initialized.
> For pci devices these fields are initialized by rte_eth_dev_pci_probe
> ->eth_dev_attach_secondary().
> However, for virtio-user virtio_user_pmd_probe() is called instead of
> rte_eth_dev_pci_probe().
> To fix it: Allow non-pci drivers call to dev_attach_secondary() and
> call it (for secondary process) from virtio_user_pmd_probe.
>
> Signed-off-by: Ami Sabo <amis@radware.com>
Firstly, two minor comments:
- A fix path needs a fixline (check dpdk.org/dev for HOWTO)
- It fixes a bug in former releases, thus it need be picked into a stable
release. Then you need add following just before you Signed-off-by:
Cc: stable@dpdk.org
> /**
> * @internal
> + * Attach to the ethdev already initialized by the primary
> + * process.
> + *
> + * @param name Ethernet device's name.
> + @return
> + * - Slot in the rte_dev_devices array for attached device;
Yes, that's what it returns on success. You also need to add the case
when it fails.
> + */
> +struct rte_eth_dev *rte_eth_dev_attach_secondary(const char *name);
> +
> +/**
> + * @internal
> * Release the specified ethdev port.
> *
> * @param eth_dev
> diff --git a/lib/librte_ether/rte_ether_version.map b/lib/librte_ether/rte_ether_version.map
> index c6c9d0d..f8bf2ee 100644
> --- a/lib/librte_ether/rte_ether_version.map
> +++ b/lib/librte_ether/rte_ether_version.map
> @@ -152,5 +152,6 @@ DPDK_17.02 {
> rte_flow_flush;
> rte_flow_query;
> rte_flow_validate;
> + rte_eth_dev_attach_secondary;
>
> } DPDK_16.11;
17.02 is released, you should add a new table for 17.05 and add it there.
Besides, I would suggest you to split this patch into two:
- one for exporting rte_eth_dev_attach_secondary
- another for fixing the bug
--yliu
next prev parent reply other threads:[~2017-02-24 8:23 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-23 11:58 Ami Sabo
2017-02-24 8:22 ` Yuanhan Liu [this message]
2017-02-26 9:55 ` [dpdk-dev] [PATCH 0/2] Fix virtio-user multi-process crash Ami Sabo
2017-02-26 9:55 ` [dpdk-dev] [PATCH 1/2] lib/librte_ether: export secondary attach function Ami Sabo
2017-02-28 6:37 ` Yuanhan Liu
2017-03-02 7:51 ` [dpdk-dev] [PATCH v2 0/3] Fix virtio-user multi-process crash Ami Sabo
2017-03-02 7:51 ` [dpdk-dev] [PATCH v2 1/3] lib/librte_ether: export secondary attach function Ami Sabo
2017-03-02 7:51 ` [dpdk-dev] [PATCH v2 2/3] net/virtio-user: fix multi-process issue Ami Sabo
2017-03-02 7:51 ` [dpdk-dev] [PATCH v2 3/3] lib/librte_ether: fix code style issues Ami Sabo
2017-03-02 8:12 ` Yuanhan Liu
2017-03-02 9:00 ` [dpdk-dev] [PATCH 0/2] Fix virtio-user multi-process crash Ami Sabo
2017-03-02 9:00 ` [dpdk-dev] [PATCH 1/2] lib/librte_ether: export secondary attach function Ami Sabo
2017-03-02 9:00 ` [dpdk-dev] [PATCH 2/2] net/virtio-user: fix multi-process issue Ami Sabo
2017-03-08 11:40 ` [dpdk-dev] [PATCH 0/2] Fix virtio-user multi-process crash Thomas Monjalon
2017-04-06 20:14 ` Thomas Monjalon
2017-04-07 6:33 ` Tan, Jianfeng
2017-04-14 12:13 ` Thomas Monjalon
2017-02-26 9:55 ` [dpdk-dev] [PATCH 2/2] net/virtio-user: fix multi-process issue Ami Sabo
2017-02-28 6:40 ` Yuanhan Liu
2017-02-28 7:50 ` Ami Sabo
-- strict thread matches above, loose matches on Subject: below --
2017-02-22 11:21 [dpdk-dev] [PATCH] " Ami Sabo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170224082255.GC18844@yliu-dev.sh.intel.com \
--to=yuanhan.liu@linux.intel.com \
--cc=amis@radware.com \
--cc=dev@dpdk.org \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).