From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
To: Ami Sabo <amis@radware.com>
Cc: thomas.monjalon@6wind.com, dev@dpdk.org, stable@dpdk.org
Subject: Re: [dpdk-stable] [PATCH v2 3/3] lib/librte_ether: fix code style issues
Date: Thu, 2 Mar 2017 16:12:25 +0800 [thread overview]
Message-ID: <20170302081225.GR18844@yliu-dev.sh.intel.com> (raw)
In-Reply-To: <1488441084-6039-4-git-send-email-amis@radware.com>
On Thu, Mar 02, 2017 at 09:51:24AM +0200, Ami Sabo wrote:
> Fixed code style issues following Yuanhan Liu's review.
Patch 1 is not merged yet. You should squash this fix into patch 1,
instead of sending another patch.
Meanwhile, when you do so, you should add version log, and put it
at .....>
>
> Signed-off-by: Ami Sabo <amis@radware.com>
> ---
... here (right below the ---). It could be something like:
- v2: fix coding style issues (Yuanhan Liu)
If you are still unsure, just find some examples from the mailing list.
--yliu
next prev parent reply other threads:[~2017-03-02 8:13 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1487851096-32479-1-git-send-email-amis@radware.com>
2017-02-26 9:55 ` [dpdk-stable] [PATCH 0/2] Fix virtio-user multi-process crash Ami Sabo
2017-02-26 9:55 ` [dpdk-stable] [PATCH 1/2] lib/librte_ether: export secondary attach function Ami Sabo
2017-02-28 6:37 ` Yuanhan Liu
2017-03-02 7:51 ` [dpdk-stable] [PATCH v2 0/3] Fix virtio-user multi-process crash Ami Sabo
2017-03-02 7:51 ` [dpdk-stable] [PATCH v2 1/3] lib/librte_ether: export secondary attach function Ami Sabo
2017-03-02 7:51 ` [dpdk-stable] [PATCH v2 2/3] net/virtio-user: fix multi-process issue Ami Sabo
2017-03-02 7:51 ` [dpdk-stable] [PATCH v2 3/3] lib/librte_ether: fix code style issues Ami Sabo
2017-03-02 8:12 ` Yuanhan Liu [this message]
2017-03-02 9:00 ` [dpdk-stable] [PATCH 0/2] Fix virtio-user multi-process crash Ami Sabo
2017-03-02 9:00 ` [dpdk-stable] [PATCH 1/2] lib/librte_ether: export secondary attach function Ami Sabo
2017-03-02 9:00 ` [dpdk-stable] [PATCH 2/2] net/virtio-user: fix multi-process issue Ami Sabo
2017-04-14 12:13 ` [dpdk-stable] [PATCH 0/2] Fix virtio-user multi-process crash Thomas Monjalon
2017-02-26 9:55 ` [dpdk-stable] [PATCH 2/2] net/virtio-user: fix multi-process issue Ami Sabo
2017-02-28 6:40 ` Yuanhan Liu
2017-02-28 7:50 ` Ami Sabo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170302081225.GR18844@yliu-dev.sh.intel.com \
--to=yuanhan.liu@linux.intel.com \
--cc=amis@radware.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).