From: "Gaëtan Rivet" <gaetan.rivet@6wind.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: Allain Legacy <allain.legacy@windriver.com>,
thomas.monjalon@6wind.com, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] devtools: add long lines to the list of options
Date: Thu, 2 Mar 2017 14:04:28 +0100 [thread overview]
Message-ID: <20170302130428.GE1821@bidouze.vm.6wind.com> (raw)
In-Reply-To: <20170301100851.60c3e46c@xeon-e3>
On Wed, Mar 01, 2017 at 10:08:51AM -0800, Stephen Hemminger wrote:
>On Wed, 1 Mar 2017 12:44:19 -0500
>Allain Legacy <allain.legacy@windriver.com> wrote:
>
>> The checkpatch.pl tool is flagging warnings on long debug log strings.
>> Since splitting these strings makes it difficult to search for logs it is
>> preferred to allow these as exceptions to the long line rule. The addition
>> of the LONG_LINE_STRINGS to the list of exceptions will allow lines that
>> end with a string to exceed the maximum line length, but lines that end
>> with variables or other constructs will still be flagged as errors. Also,
>> lines that make use of PRIx64 with string concatenation will still be
>> flagged if the beginning of the last string fragment begins after the 80
>> character threshold.
>>
>> Signed-off-by: Allain Legacy <allain.legacy@windriver.com>
>> ---
>> devtools/checkpatches.sh | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh
>> index 78e155e..26ff419 100755
>> --- a/devtools/checkpatches.sh
>> +++ b/devtools/checkpatches.sh
>> @@ -45,7 +45,7 @@ options="$options --ignore=LINUX_VERSION_CODE,FILE_PATH_CHANGES,\
>> VOLATILE,PREFER_PACKED,PREFER_ALIGNED,PREFER_PRINTF,\
>> PREFER_KERNEL_TYPES,BIT_MACRO,CONST_STRUCT,\
>> SPLIT_STRING,LINE_SPACING,PARENTHESIS_ALIGNMENT,NETWORKING_BLOCK_COMMENT_STYLE,\
>> -NEW_TYPEDEFS,COMPARISON_TO_NULL"
>> +NEW_TYPEDEFS,COMPARISON_TO_NULL,LONG_LINE_STRING"
>>
>> print_usage () {
>> cat <<- END_OF_HELP
>
>Maybe it is time to have our own DPDK version of checkpatch which knows about
>DPDK API's like logging functions?
Additionally, accepting the format strings PRIu8 and consort would be
nice, as they are currently flagged as CamelCase. Same as some EAL
functions (like eal_parse_pci_DomBDF and eal_parse_pci_BDF), but
renaming those could be a better solution.
--
Gaëtan Rivet
6WIND
next prev parent reply other threads:[~2017-03-02 13:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-01 17:44 Allain Legacy
2017-03-01 18:08 ` Stephen Hemminger
2017-03-01 18:38 ` Thomas Monjalon
2017-03-02 12:49 ` Mcnamara, John
2017-03-02 13:04 ` Gaëtan Rivet [this message]
2017-03-06 15:03 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170302130428.GE1821@bidouze.vm.6wind.com \
--to=gaetan.rivet@6wind.com \
--cc=allain.legacy@windriver.com \
--cc=dev@dpdk.org \
--cc=stephen@networkplumber.org \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).