DPDK patches and discussions
 help / color / mirror / Atom feed
From: Jerin Jacob <jerin.jacob@caviumnetworks.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] kni: fix build with kernel 4.11
Date: Mon, 20 Mar 2017 17:04:58 +0530	[thread overview]
Message-ID: <20170320113457.dxqj7ogu2mtxi432@localhost.localdomain> (raw)
In-Reply-To: <20170320112208.7941-1-ferruh.yigit@intel.com>

On Mon, Mar 20, 2017 at 11:22:08AM +0000, Ferruh Yigit wrote:
> compile error:
> .../build/build/lib/librte_eal/linuxapp/kni/kni_net.c:124:6:
> error: implicit declaration of function ‘signal_pending’
> [-Werror=implicit-function-declaration]
>   if (signal_pending(current) || ret_val <= 0) {
>       ^~~~~~~~~~~~~~
> 
> Linux 4.11 moves signal function declarations to its own header file:
> Linux: 174cd4b1e5fb ("sched/headers: Prepare to move signal wakeup &
> sigpending methods from <linux/sched.h> into <linux/sched/signal.h>")
> 
> User new header file "linux/sched/signal.h" to fix build error.
> 
> Reported-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>

Tested-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>

Kernel version: 4.11-rc3

> ---
>  lib/librte_eal/linuxapp/kni/compat.h  | 6 ++++++
>  lib/librte_eal/linuxapp/kni/kni_dev.h | 6 ++++++
>  2 files changed, 12 insertions(+)
> 
> diff --git a/lib/librte_eal/linuxapp/kni/compat.h b/lib/librte_eal/linuxapp/kni/compat.h
> index 78da08e..d96275a 100644
> --- a/lib/librte_eal/linuxapp/kni/compat.h
> +++ b/lib/librte_eal/linuxapp/kni/compat.h
> @@ -2,6 +2,8 @@
>   * Minimal wrappers to allow compiling kni on older kernels.
>   */
>  
> +#include <linux/version.h>
> +
>  #ifndef RHEL_RELEASE_VERSION
>  #define RHEL_RELEASE_VERSION(a, b) (((a) << 8) + (b))
>  #endif
> @@ -67,3 +69,7 @@
>  	(LINUX_VERSION_CODE < KERNEL_VERSION(2, 6, 34)))
>  #undef NET_NAME_UNKNOWN
>  #endif
> +
> +#if LINUX_VERSION_CODE >= KERNEL_VERSION(4, 11, 0)
> +#define HAVE_SIGNAL_FUNCTIONS_OWN_HEADER
> +#endif
> diff --git a/lib/librte_eal/linuxapp/kni/kni_dev.h b/lib/librte_eal/linuxapp/kni/kni_dev.h
> index 002e5fa..72385ab 100644
> --- a/lib/librte_eal/linuxapp/kni/kni_dev.h
> +++ b/lib/librte_eal/linuxapp/kni/kni_dev.h
> @@ -30,9 +30,15 @@
>  #endif
>  #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
>  
> +#include "compat.h"
> +
>  #include <linux/if.h>
>  #include <linux/wait.h>
> +#ifdef HAVE_SIGNAL_FUNCTIONS_OWN_HEADER
> +#include <linux/sched/signal.h>
> +#else
>  #include <linux/sched.h>
> +#endif
>  #include <linux/netdevice.h>
>  #include <linux/spinlock.h>
>  #include <linux/list.h>
> -- 
> 2.9.3
> 

  reply	other threads:[~2017-03-20 11:35 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-20 11:22 Ferruh Yigit
2017-03-20 11:34 ` Jerin Jacob [this message]
2017-03-21  7:12 ` Pankaj Gupta
2017-03-21  9:54 ` [dpdk-dev] [PATCH v2] " Ferruh Yigit
2017-03-30 14:44   ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170320113457.dxqj7ogu2mtxi432@localhost.localdomain \
    --to=jerin.jacob@caviumnetworks.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).