From: Jerin Jacob <jerin.jacob@caviumnetworks.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] net/thunderx: sync mailbox definitions with Linux PF driver
Date: Wed, 22 Mar 2017 15:09:33 +0530 [thread overview]
Message-ID: <20170322093931.2u5z3n645cnobi63@localhost.localdomain> (raw)
In-Reply-To: <8059571c-9747-ca33-0d61-f453e43afa48@intel.com>
On Tue, Mar 21, 2017 at 02:53:29PM +0000, Ferruh Yigit wrote:
> On 3/21/2017 2:38 PM, Jerin Jacob wrote:
> > On Tue, Mar 21, 2017 at 02:31:41PM +0000, Ferruh Yigit wrote:
> >> On 3/20/2017 2:10 PM, Jerin Jacob wrote:
> >>> - bgx_link_status mbox definition was changed in Linux
> >>> commit 1cc702591bae ("net: thunderx: Add ethtool support")
> >>> - NIC_MBOX_MSG_RES_BIT related changes were never part of Linux PF driver
> >>>
> >>> Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> >>
> >> <...>
> >>
> >>> @@ -157,6 +151,7 @@ struct rss_cfg_msg {
> >>> /* Physical interface link status */
> >>> struct bgx_link_status {
> >>> uint8_t msg;
> >>> + uint8_t mac_type;
> >>
> >> Hi Jerin,
> >>
> >> Is this modification related to this patch?
> >
> > Yes Ferruh.
> >
> > This was related to the following section in git log comment.
> > ----
> > - bgx_link_status mbox definition was changed in Linux
> > commit 1cc702591bae ("net: thunderx: Add ethtool support")
> > ---
>
> I see now, thanks. Since this is to sync with Linux PF, shouldn't it be
> used in driver, perhaps something like in Linux driver:
> "nic->mac_type = mbx.link_status.mac_type"
>
> What is the point of just adding definition without using it?
That is to keep "link_up"(next element in the struct bgx_link_status) points
to correct location after the kernel change. I thought about, the backward
compatibility with older kernel, Is it OK to use linux/version.h in PMD drivers
to detect the kernel version? drivers/net/mlx5/mlx5_ethdev.c has similar
kernel detection mechanism to make it backward compatible.
If there are no issue with such approach, I will roll out a new revision.
>
> >
> >
> >>
> >>> uint8_t link_up;
> >>> uint8_t duplex;
> >>> uint32_t speed;
> >>>
> >>
>
next prev parent reply other threads:[~2017-03-22 9:39 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-20 14:10 Jerin Jacob
2017-03-21 14:31 ` Ferruh Yigit
2017-03-21 14:38 ` Jerin Jacob
2017-03-21 14:53 ` Ferruh Yigit
2017-03-22 9:39 ` Jerin Jacob [this message]
2017-03-22 10:33 ` Ferruh Yigit
2017-03-23 13:20 ` Jerin Jacob
2017-03-23 13:26 ` Ferruh Yigit
2017-03-23 14:00 ` Jerin Jacob
2017-03-23 14:02 ` Ferruh Yigit
2017-03-23 14:09 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170322093931.2u5z3n645cnobi63@localhost.localdomain \
--to=jerin.jacob@caviumnetworks.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).