From: Bruce Richardson <bruce.richardson@intel.com>
To: "László Molnár" <laszlo.molnar@ericsson.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] bug in LPM handling (16.04+)
Date: Wed, 29 Mar 2017 15:41:18 +0100 [thread overview]
Message-ID: <20170329144117.GA10824@bricha3-MOBL3.ger.corp.intel.com> (raw)
In-Reply-To: <20170329123813.GP2871@elxafv3bk32>
On Wed, Mar 29, 2017 at 02:38:13PM +0200, László Molnár wrote:
> --- rte_lpm.c~3 2017-03-29 12:19:06.146933973 +0200
> +++ rte_lpm.c 2017-03-29 12:19:06.000000000 +0200
> @@ -1034,7 +1034,7 @@
> */
>
> struct rte_lpm_tbl_entry new_tbl24_entry = {
> - .group_idx = (uint8_t)tbl8_group_index,
> + .group_idx = tbl8_group_index,
> .valid = VALID,
> .valid_group = 1,
> .depth = 0,
> @@ -1080,7 +1080,7 @@
> */
>
> struct rte_lpm_tbl_entry new_tbl24_entry = {
> - .group_idx = (uint8_t)tbl8_group_index,
> + .group_idx = tbl8_group_index,
> .valid = VALID,
> .valid_group = 1,
> .depth = 0,
>
Hi,
this fix looks reasonable. Can you perhaps resend as a proper patch with
signoff, as described in contributors guide doc? See:
http://dpdk.org/doc/guides/contributing/patches.html#make-your-changes
Thanks,
/Bruce
prev parent reply other threads:[~2017-03-29 14:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-29 12:25 László Molnár
2017-03-29 12:38 ` László Molnár
2017-03-29 14:41 ` Bruce Richardson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170329144117.GA10824@bricha3-MOBL3.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=laszlo.molnar@ericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).