From: Aaron Conole <aconole@redhat.com>
To: dev@dpdk.org
Subject: [dpdk-dev] [PATCH] eal: deprecate rte_cpu_check_supported
Date: Fri, 31 Mar 2017 14:31:22 -0400 [thread overview]
Message-ID: <20170331183122.22961-1-aconole@redhat.com> (raw)
It's likely that this function isn't used anywhere, but since it was part of
the public API, mark the function for deprecation for at least one release.
Signed-off-by: Aaron Conole <aconole@redhat.com>
---
lib/librte_eal/bsdapp/eal/rte_eal_version.map | 7 +++++++
lib/librte_eal/common/arch/x86/rte_cpuflags.c | 1 +
lib/librte_eal/common/arch/x86/rte_spinlock.c | 1 +
lib/librte_eal/common/include/generic/rte_cpuflags.h | 3 ++-
lib/librte_eal/linuxapp/eal/rte_eal_version.map | 7 +++++++
5 files changed, 18 insertions(+), 1 deletion(-)
diff --git a/lib/librte_eal/bsdapp/eal/rte_eal_version.map b/lib/librte_eal/bsdapp/eal/rte_eal_version.map
index 67f2ffb..82f0f9f 100644
--- a/lib/librte_eal/bsdapp/eal/rte_eal_version.map
+++ b/lib/librte_eal/bsdapp/eal/rte_eal_version.map
@@ -182,3 +182,10 @@ DPDK_17.02 {
rte_bus_unregister;
} DPDK_16.11;
+
+DPDK_17.05 {
+ global;
+
+ rte_cpu_is_supported;
+
+} DPDK_17.02;
diff --git a/lib/librte_eal/common/arch/x86/rte_cpuflags.c b/lib/librte_eal/common/arch/x86/rte_cpuflags.c
index 0138257..04f0852 100644
--- a/lib/librte_eal/common/arch/x86/rte_cpuflags.c
+++ b/lib/librte_eal/common/arch/x86/rte_cpuflags.c
@@ -31,6 +31,7 @@
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/
+#include "rte_common.h"
#include "rte_cpuflags.h"
#include <stdio.h>
diff --git a/lib/librte_eal/common/arch/x86/rte_spinlock.c b/lib/librte_eal/common/arch/x86/rte_spinlock.c
index c383e9f..f1b1a4e 100644
--- a/lib/librte_eal/common/arch/x86/rte_spinlock.c
+++ b/lib/librte_eal/common/arch/x86/rte_spinlock.c
@@ -33,6 +33,7 @@
#include <stdint.h>
+#include "rte_common.h"
#include "rte_cpuflags.h"
uint8_t rte_rtm_supported; /* cache the flag to avoid the overhead
diff --git a/lib/librte_eal/common/include/generic/rte_cpuflags.h b/lib/librte_eal/common/include/generic/rte_cpuflags.h
index f01624d..df66939 100644
--- a/lib/librte_eal/common/include/generic/rte_cpuflags.h
+++ b/lib/librte_eal/common/include/generic/rte_cpuflags.h
@@ -78,9 +78,10 @@ rte_cpu_get_flag_enabled(enum rte_cpu_flag_t feature);
* This function checks that the currently used CPU supports the CPU features
* that were specified at compile time. It is called automatically within the
* EAL, so does not need to be used by applications.
+ * This version is replaced by rte_cpu_is_supported
*/
void
-rte_cpu_check_supported(void);
+rte_cpu_check_supported(void) __rte_deprecated;
/**
* This function checks that the currently used CPU supports the CPU features
diff --git a/lib/librte_eal/linuxapp/eal/rte_eal_version.map b/lib/librte_eal/linuxapp/eal/rte_eal_version.map
index 9c134b4..461f15d 100644
--- a/lib/librte_eal/linuxapp/eal/rte_eal_version.map
+++ b/lib/librte_eal/linuxapp/eal/rte_eal_version.map
@@ -186,3 +186,10 @@ DPDK_17.02 {
rte_bus_unregister;
} DPDK_16.11;
+
+DPDK_17.05 {
+ global;
+
+ rte_cpu_is_supported;
+
+} DPDK_17.02;
--
2.9.3
next reply other threads:[~2017-03-31 18:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-31 18:31 Aaron Conole [this message]
2017-04-03 8:55 ` Bruce Richardson
2017-04-04 13:26 ` Thomas Monjalon
2017-04-04 13:39 ` Aaron Conole
2017-04-04 14:01 ` Thomas Monjalon
2017-04-04 15:38 ` [dpdk-dev] [PATCH 1/2] eal: add rte_cpu_is_supported to map Aaron Conole
2017-04-04 15:38 ` [dpdk-dev] [PATCH 2/2] eal: deprecate rte_cpu_check_supported Aaron Conole
2017-04-06 20:58 ` [dpdk-dev] [PATCH 1/2] eal: add rte_cpu_is_supported to map Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170331183122.22961-1-aconole@redhat.com \
--to=aconole@redhat.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).