From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
To: dev@dpdk.org
Cc: Maxime Coquelin <maxime.coquelin@redhat.com>
Subject: Re: [dpdk-dev] [PATCH] vhost: remove a hack on queue allocation
Date: Sat, 1 Apr 2017 16:35:21 +0800 [thread overview]
Message-ID: <20170401083521.GX18844@yliu-dev.sh.intel.com> (raw)
In-Reply-To: <20170401083258.GW18844@yliu-dev.sh.intel.com>
On Sat, Apr 01, 2017 at 04:32:58PM +0800, Yuanhan Liu wrote:
> On Wed, Mar 22, 2017 at 04:56:12PM +0800, Yuanhan Liu wrote:
> > On Wed, Mar 22, 2017 at 09:41:07AM +0100, Maxime Coquelin wrote:
> > >
> > >
> > > On 03/02/2017 07:16 AM, Yuanhan Liu wrote:
> > > >We used to allocate queues based on the index from SET_VRING_CALL
> > > >request: if corresponding queue hasn't been allocated, allocate it.
> > > >
> > > >Though it's pratically right (it's the first per-vring request we
> > > >will get from QEMU for vhost-user negotiation), but it's not technically
> > > >right: it's not documented in the vhost-user spec that it will always
> > > >be the first per-vring request. For example, SET_VRING_ADDR could also
> > > >be the first per-vring request.
> > > >
> > > >Thus, we should not depend the SET_VRING_CALL on queue allocation.
> > > >Instead, we could catch all the per-vring messages at the entrance of
> > > >request handler, and allocate one if it hasn't been allocated before.
> > > >
> > > >By that, we could remove a hack.
> > > >
> > > >Signed-off-by: Yuanhan Liu <yuanhan.liu@linux.intel.com>
> > > >---
> > > >
> > > >v2: add missing break
> > > >---
> > > > lib/librte_vhost/vhost_user.c | 61 ++++++++++++++++++++++++++++++++++---------
> > > > 1 file changed, 48 insertions(+), 13 deletions(-)
> > >
> > >
> > > Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
> >
> > Thanks.
> >
> > Applied to dpdk-next-virtio.
>
> Reworked, as there is a silly error that cause crash.
Re-applied.
--yliu
> -- >8 --
> >From 269ba9b3a6a1671f463b9f9d4cc0d51954f7a2f5 Mon Sep 17 00:00:00 2001
> From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
> Date: Thu, 2 Mar 2017 14:16:07 +0800
> Subject: [PATCH v3] vhost: remove a hack on queue allocation
prev parent reply other threads:[~2017-04-01 8:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-02 5:59 Yuanhan Liu
2017-03-02 6:16 ` Yuanhan Liu
2017-03-22 8:41 ` Maxime Coquelin
2017-03-22 8:56 ` Yuanhan Liu
2017-04-01 8:32 ` Yuanhan Liu
2017-04-01 8:35 ` Yuanhan Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170401083521.GX18844@yliu-dev.sh.intel.com \
--to=yuanhan.liu@linux.intel.com \
--cc=dev@dpdk.org \
--cc=maxime.coquelin@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).