From: Bruce Richardson <bruce.richardson@intel.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: helin.zhang@intel.com, jingjing.wu@intel.com, dev@dpdk.org,
jerin.jacob@caviumnetworks.com, jianbo.liu@linaro.org
Subject: Re: [dpdk-dev] [PATCH 2/2] net/i40e: remove option to disable offload flags
Date: Mon, 3 Apr 2017 15:51:39 +0100 [thread overview]
Message-ID: <20170403145138.GA676@bricha3-MOBL3.ger.corp.intel.com> (raw)
In-Reply-To: <84c55d48-513b-f9c2-c9e2-8e2cc920f989@intel.com>
On Mon, Apr 03, 2017 at 03:45:46PM +0100, Ferruh Yigit wrote:
> On 4/3/2017 3:39 PM, Bruce Richardson wrote:
> > Having packets received without any offload flags given in the mbuf is not
> > very useful, and performance tests with testpmd indicates little to no
> > benefit is got with the current code by turning off the flags. This makes
> > the build-time option pointless, so we can remove it.
> >
> > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> > ---
> > config/common_base | 1 -
> > doc/guides/nics/i40e.rst | 5 -----
> > drivers/net/i40e/i40e_rxtx_vec_common.h | 8 --------
> > drivers/net/i40e/i40e_rxtx_vec_neon.c | 11 -----------
> > drivers/net/i40e/i40e_rxtx_vec_sse.c | 11 -----------
>
> Should this patch also update powerpc vector PMD (i40e_rxtx_vec_altivec.c) ?
>
Yes, good catch. I based this work off the main tree rather than
next-net as I was looking at the mbuf changes primarily. Once we get
either next-net or the mbuf patches merged in, I'll do a V2 with all
updates included.
/Bruce
next prev parent reply other threads:[~2017-04-03 14:51 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-03 14:39 [dpdk-dev] [PATCH 0/2] reduce writes in i40e driver Bruce Richardson
2017-04-03 14:39 ` [dpdk-dev] [PATCH 1/2] net/i40e: eliminate mbuf write on rearm Bruce Richardson
2017-04-03 14:39 ` [dpdk-dev] [PATCH 2/2] net/i40e: remove option to disable offload flags Bruce Richardson
2017-04-03 14:45 ` Ferruh Yigit
2017-04-03 14:51 ` Bruce Richardson [this message]
2017-04-06 5:53 ` [dpdk-dev] [PATCH 0/2] reduce writes in i40e driver Jianbo Liu
2017-04-06 5:56 ` Jianbo Liu
2017-04-06 11:32 ` [dpdk-dev] [PATCH v2 " Bruce Richardson
2017-04-06 11:32 ` [dpdk-dev] [PATCH v2 1/2] net/i40e: eliminate mbuf write on rearm Bruce Richardson
2017-04-06 16:24 ` Zhang, Qi Z
2017-04-07 8:26 ` Bruce Richardson
2017-04-06 11:32 ` [dpdk-dev] [PATCH v2 2/2] net/i40e: remove option to disable offload flags Bruce Richardson
2017-04-10 13:13 ` [dpdk-dev] [PATCH v2 0/2] reduce writes in i40e driver Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170403145138.GA676@bricha3-MOBL3.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=helin.zhang@intel.com \
--cc=jerin.jacob@caviumnetworks.com \
--cc=jianbo.liu@linaro.org \
--cc=jingjing.wu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).