From: Yongseok Koh <yskoh@mellanox.com>
To: "Nélio Laranjeiro" <nelio.laranjeiro@6wind.com>
Cc: <ferruh.yigit@intel.com>, <dev@dpdk.org>, <adrien.mazarguil@6wind.com>
Subject: Re: [dpdk-dev] [PATCH] net/mlx5: change calculating inline room for Tx
Date: Fri, 14 Apr 2017 09:52:25 -0700 [thread overview]
Message-ID: <20170414165224.GB11566@mtidpdk.mti.labs.mlnx> (raw)
In-Reply-To: <20170414065139.GD14075@autoinstall.dev.6wind.com>
On Fri, Apr 14, 2017 at 08:51:39AM +0200, Nélio Laranjeiro wrote:
> Hi Yongseok,
>
> On Thu, Apr 13, 2017 at 10:46:51AM -0700, Yongseok Koh wrote:
> > Current implementation is error-prone if the max inline size
> > (txq->max_inilne) is decoupled from txq->inline_en and becomes zero. If it
> > becomes zero, HW can crash due to WQ overflow.
>
> By reading this log, it seems more to be a fix, no?
It doesn't fix any existing bug in the code but to protect from potential
disaster by adding new features in the future. Also, there's a customer who
wants to change txq->max_inilne in runtime.
>
> > Signed-off-by: Yongseok Koh <yskoh@mellanox.com>
> > Acked-by: Shahaf Shuler <shahafs@mellanox.com>
> > ---
> > drivers/net/mlx5/mlx5_rxtx.c | 12 +++++++-----
> > 1 file changed, 7 insertions(+), 5 deletions(-)
> >
> > diff --git a/drivers/net/mlx5/mlx5_rxtx.c b/drivers/net/mlx5/mlx5_rxtx.c
> > index 2e208bf96..6254228a9 100644
> > --- a/drivers/net/mlx5/mlx5_rxtx.c
> > +++ b/drivers/net/mlx5/mlx5_rxtx.c
> > @@ -499,6 +499,8 @@ mlx5_tx_burst(void *dpdk_txq, struct rte_mbuf **pkts, uint16_t pkts_n)
> > unsigned int j = 0;
> > unsigned int k = 0;
> > unsigned int max;
> > + unsigned int max_inline = txq->max_inline;
>
> Cannot it be declared as const too? Seems it is only read in the whole
> Tx burst function, as it a chance to be update in the middle?
This is used just for calculation not for conditional expression. So, I didn't
think this makes difference.
Thanks
Yongseok
next prev parent reply other threads:[~2017-04-14 16:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-13 17:46 Yongseok Koh
2017-04-14 6:51 ` Nélio Laranjeiro
2017-04-14 16:52 ` Yongseok Koh [this message]
2017-04-18 6:43 ` Nélio Laranjeiro
2017-04-18 9:35 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170414165224.GB11566@mtidpdk.mti.labs.mlnx \
--to=yskoh@mellanox.com \
--cc=adrien.mazarguil@6wind.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=nelio.laranjeiro@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).