From: Adrien Mazarguil <adrien.mazarguil@6wind.com>
To: John Daley <johndale@cisco.com>
Cc: john.mcnamara@intel.com, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v4] doc: fix flow validate comments
Date: Fri, 21 Apr 2017 10:11:43 +0200 [thread overview]
Message-ID: <20170421081142.GY3790@6wind.com> (raw)
In-Reply-To: <20170420184933.27450-1-johndale@cisco.com>
On Thu, Apr 20, 2017 at 11:49:33AM -0700, John Daley wrote:
> Change comments for rte_flow_validate() function to indicate that flow
> rule collision and resource validation is optional for PMDs and
> therefore the return codes may have different meanings.
>
> Fixes: b1a4b4cbc0a8 ("ethdev: introduce generic flow API")
>
> Signed-off-by: John Daley <johndale@cisco.com>
One last nit below (not sure if you need to send a new version). In any
case:
Acked-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
[...]
> @@ -1360,8 +1362,13 @@ Return values:
> - ``-EINVAL``: unknown or invalid rule specification.
> - ``-ENOTSUP``: valid but unsupported rule specification (e.g. partial
> bit-masks are unsupported).
> -- ``-EEXIST``: collision with an existing rule.
> -- ``-ENOMEM``: not enough resources.
> +- ``EEXIST``: collision with an existing rule. Only returned if device
> + supports flow rule collision checking and there was a flow rule
> + collision. Not receiving this return code is no guarantee that creating
> + the rule will not fail due to a collision.
> +- ``ENOMEM``: not enough memory to execute the function, or if the device
> + supports resource validation, resource limitation on the device.
> +
This new empty line should be removed.
> - ``-EBUSY``: action cannot be performed due to busy device resources, may
> succeed if the affected queues or even the entire port are in a stopped
> state (see ``rte_eth_dev_rx_queue_stop()`` and ``rte_eth_dev_stop()``).
[...]
Thanks.
--
Adrien Mazarguil
6WIND
next prev parent reply other threads:[~2017-04-21 8:11 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-24 2:36 [dpdk-dev] [PATCH 0/1] proposed minor change in rte_flow_validate semantics John Daley
2017-03-24 2:36 ` [dpdk-dev] [PATCH 1/1] ethdev: don't consider device state when validating flows John Daley
2017-04-06 20:50 ` Thomas Monjalon
2017-04-06 22:41 ` [dpdk-dev] [PATCH v2 0/1] fix flow validate comments John Daley
2017-04-06 22:41 ` [dpdk-dev] [PATCH v2 1/1] ethdev: " John Daley
2017-04-07 0:23 ` [dpdk-dev] [PATCH v3] " John Daley
2017-04-11 10:01 ` Adrien Mazarguil
2017-04-20 18:49 ` [dpdk-dev] [PATCH v4] doc: " John Daley
2017-04-21 8:11 ` Adrien Mazarguil [this message]
2017-04-21 8:42 ` Thomas Monjalon
2017-03-24 9:46 ` [dpdk-dev] [PATCH 0/1] proposed minor change in rte_flow_validate semantics Adrien Mazarguil
2017-03-24 17:23 ` John Daley (johndale)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170421081142.GY3790@6wind.com \
--to=adrien.mazarguil@6wind.com \
--cc=dev@dpdk.org \
--cc=john.mcnamara@intel.com \
--cc=johndale@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).