From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] devtools: list stable commits do not have fixline
Date: Fri, 28 Apr 2017 17:01:30 +0800 [thread overview]
Message-ID: <20170428090130.GZ11512@yliu-dev.sh.intel.com> (raw)
In-Reply-To: <4676086.N97G0cgc3q@xps>
On Fri, Apr 28, 2017 at 11:00:07AM +0200, Thomas Monjalon wrote:
> 28/04/2017 10:27, Yuanhan Liu:
> > On Fri, Apr 28, 2017 at 10:15:46AM +0200, Thomas Monjalon wrote:
> > > 28/04/2017 09:21, Yuanhan Liu:
> > > > Some commits for stable releases (with Cc stable tag) may not have the
> > > > fixline. For example:
> > > > http://dpdk.org/dev/patchwork/patch/23955/
> > > >
> > > > It disables a feature we have implemented in last release. The feature
> > > > is done right. It's the QEMU implementaton being buggy, that we have to
> > > > disable it to workaround those buggy QEMU releases (v2.7 - v2.9). Without
> > > > such workaround, QEMU won't start when queue number >= 2.
> > > >
> > > > That said, we also have to backport it to stable releases, though there
> > > > is no fixline (there was no DPDK bug to fix after all).
> > >
> > > How do we know where should it be backported?
> >
> > Good question. As a stable maintainer, I may not know. But the developer
> > should know. For such case, he may add something like:
> >
> > Cc: stable@dpdk.org # for v17.02+
>
> It breaks backport semi-automation.
But it should be (easily) fixed.
> > It's a trick used widely in kernel and QEMU community.
> >
> > > It is fixing a bug with a correct implementation because of
> > > a buggy dependency. But it is still a bug.
> > > So I think we should put a Fixes: line.
> >
> > I don't have strong objection to this. It just doesn't make too much
> > sense to me: there is no bug in the DPDK implementation after all.
> >
> > But if you insist, I'm okay with it.
>
> Yes I insist :)
> It is fixing code to work with some dependencies.
Okay.
Besides, okay to merge this patch? As you stated, it does no harm.
--yliu
next prev parent reply other threads:[~2017-04-28 9:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-28 7:21 Yuanhan Liu
2017-04-28 8:15 ` Thomas Monjalon
2017-04-28 8:27 ` Yuanhan Liu
2017-04-28 9:00 ` Thomas Monjalon
2017-04-28 9:01 ` Yuanhan Liu [this message]
2017-04-28 10:07 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170428090130.GZ11512@yliu-dev.sh.intel.com \
--to=yuanhan.liu@linux.intel.com \
--cc=dev@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).