From: Jerin Jacob <jerin.jacob@caviumnetworks.com>
To: Jianbo Liu <jianbo.liu@linaro.org>
Cc: dev@dpdk.org, thomas@monjalon.net,
Jan Viktorin <viktorin@rehivetech.com>
Subject: Re: [dpdk-dev] [PATCH 3/6] eal/arm64: rte pause implementation for arm64
Date: Thu, 18 May 2017 15:46:59 +0530 [thread overview]
Message-ID: <20170518101657.GA17993@jerin> (raw)
In-Reply-To: <CAP4Qi396iLCTzFXFuM7WakRyaH2oRAKFSZf-fBe5svyUoQi-5w@mail.gmail.com>
-----Original Message-----
> Date: Thu, 18 May 2017 17:40:58 +0800
> From: Jianbo Liu <jianbo.liu@linaro.org>
> To: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> Cc: dev@dpdk.org, thomas@monjalon.net, Jan Viktorin
> <viktorin@rehivetech.com>
> Subject: Re: [dpdk-dev] [PATCH 3/6] eal/arm64: rte pause implementation for
> arm64
>
> On 11 May 2017 at 18:10, Jerin Jacob <jerin.jacob@caviumnetworks.com> wrote:
> > CC: Jianbo Liu <jianbo.liu@linaro.org>
> > Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> > ---
> > lib/librte_eal/common/include/arch/arm/rte_pause.h | 4 ++
> > .../common/include/arch/arm/rte_pause_64.h | 55 ++++++++++++++++++++++
> > 2 files changed, 59 insertions(+)
> > create mode 100644 lib/librte_eal/common/include/arch/arm/rte_pause_64.h
> >
> > diff --git a/lib/librte_eal/common/include/arch/arm/rte_pause.h b/lib/librte_eal/common/include/arch/arm/rte_pause.h
> > index 0fe88aba9..9b79405e6 100644
> > --- a/lib/librte_eal/common/include/arch/arm/rte_pause.h
> > +++ b/lib/librte_eal/common/include/arch/arm/rte_pause.h
> > @@ -37,7 +37,11 @@
> > extern "C" {
> > #endif
> >
> > +#ifdef RTE_ARCH_64
> > +#include <rte_pause_64.h>
> > +#else
> > #include <rte_pause_32.h>
> > +#endif
> >
> > #ifdef __cplusplus
> > }
> > diff --git a/lib/librte_eal/common/include/arch/arm/rte_pause_64.h b/lib/librte_eal/common/include/arch/arm/rte_pause_64.h
> > new file mode 100644
> > index 000000000..cae996de8
> > --- /dev/null
> > +++ b/lib/librte_eal/common/include/arch/arm/rte_pause_64.h
> > @@ -0,0 +1,55 @@
> > +/*
> > + * BSD LICENSE
> > + *
> > + * Copyright(c) 2017 Cavium. All rights reserved.
> > + *
> > + * Redistribution and use in source and binary forms, with or without
> > + * modification, are permitted provided that the following conditions
> > + * are met:
> > + *
> > + * * Redistributions of source code must retain the above copyright
> > + * notice, this list of conditions and the following disclaimer.
> > + * * Redistributions in binary form must reproduce the above copyright
> > + * notice, this list of conditions and the following disclaimer in
> > + * the documentation and/or other materials provided with the
> > + * distribution.
> > + * * Neither the name of Cavium nor the names of its
> > + * contributors may be used to endorse or promote products derived
> > + * from this software without specific prior written permission.
> > + *
> > + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
> > + * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
> > + * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
> > + * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
> > + * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
> > + * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
> > + * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
> > + * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
> > + * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
> > + * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
> > + * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
> > + */
> > +
> > +#ifndef _RTE_PAUSE_ARM64_H_
> > +#define _RTE_PAUSE_ARM64_H_
> > +
> > +#ifdef __cplusplus
> > +extern "C" {
> > +#endif
> > +
> > +#include <rte_common.h>
> > +#include "generic/rte_pause.h"
> > +
> > +static inline void rte_pause(void)
> > +{
> > + /* YIELD hints the CPU to switch to another thread if possible
> > + * and executes as a NOP otherwise.
>
> I think you can remove the second line if you are trying to explain
> what YIELD instruction is.
> And I wonder if it can save power as rte_thread is bounded to certain
> core and always polling while YIELD is only a hint instruction.
AFAIK, It is HW thread not software OS thread.ie Simultaneous Multi-Threading (SMT)
or Hyper threading.
For example, Cavium 99xx has 4 HW threads per physical core.
I agree on comment. I think, I can remove the comment as YIELD is just a hint
and varies based on arm64 implementation. Will fix it v2.
>
> > + */
> > + asm volatile("yield" ::: "memory");
> > +}
> > +
> > +#ifdef __cplusplus
> > +}
> > +#endif
> > +
> > +#endif /* _RTE_PAUSE_ARM64_H_ */
> > --
> > 2.12.2
> >
next prev parent reply other threads:[~2017-05-18 10:17 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-11 10:10 [dpdk-dev] [PATCH 1/6] eal: change rte pause as architecture specific function Jerin Jacob
2017-05-11 10:10 ` [dpdk-dev] [PATCH 2/6] eal/arm32: rte pause implementation for arm32 Jerin Jacob
2017-05-18 8:11 ` Jan Viktorin
2017-05-18 9:14 ` Jianbo Liu
2017-05-11 10:10 ` [dpdk-dev] [PATCH 3/6] eal/arm64: rte pause implementation for arm64 Jerin Jacob
2017-05-18 9:40 ` Jianbo Liu
2017-05-18 10:16 ` Jerin Jacob [this message]
2017-05-19 1:46 ` Jianbo Liu
2017-05-11 10:10 ` [dpdk-dev] [PATCH 4/6] eal/x86: rte pause implementation for x86 Jerin Jacob
2017-05-11 10:10 ` [dpdk-dev] [PATCH 5/6] eal/ppc64: rte pause implementation for ppc64 Jerin Jacob
2017-05-18 6:35 ` Chao Zhu
2017-05-11 10:10 ` [dpdk-dev] [PATCH 6/6] eal: switchover to architecture specific rte pause function Jerin Jacob
2017-06-05 8:58 ` [dpdk-dev] [PATCH v2 1/6] eal: change rte pause as architecture specific function Jerin Jacob
2017-06-05 8:58 ` [dpdk-dev] [PATCH v2 2/6] eal/arm32: rte pause implementation for arm32 Jerin Jacob
2017-06-05 8:58 ` [dpdk-dev] [PATCH v2 3/6] eal/arm64: rte pause implementation for arm64 Jerin Jacob
2017-06-06 1:36 ` Jianbo Liu
2017-06-05 8:58 ` [dpdk-dev] [PATCH v2 4/6] eal/x86: rte pause implementation for x86 Jerin Jacob
2017-06-05 8:58 ` [dpdk-dev] [PATCH v2 5/6] eal/ppc64: rte pause implementation for ppc64 Jerin Jacob
2017-06-05 8:58 ` [dpdk-dev] [PATCH v2 6/6] eal: switchover to architecture specific rte pause function Jerin Jacob
2017-07-03 21:59 ` [dpdk-dev] [PATCH v2 1/6] eal: change rte pause as architecture specific function Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170518101657.GA17993@jerin \
--to=jerin.jacob@caviumnetworks.com \
--cc=dev@dpdk.org \
--cc=jianbo.liu@linaro.org \
--cc=thomas@monjalon.net \
--cc=viktorin@rehivetech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).